From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= Newsgroups: gmane.emacs.bugs Subject: bug#50244: 28.0.50; Support project-wide diagnostics reports in flymake.el Date: Tue, 14 Sep 2021 09:20:50 +0100 Message-ID: <87wnnj36vx.fsf@gmail.com> References: <87bl5hm5qj.fsf@gmail.com> <87y283536t.fsf@gmail.com> <41cd4854-d162-bc6c-900e-96a4245e2c59@yandex.ru> <87o88w4al4.fsf@gmail.com> <061838b7-bf19-b899-f1aa-76760fb35607@yandex.ru> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="2464"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: 50244@debbugs.gnu.org, Philipp Stephani , Theodor Thornhill To: Dmitry Gutov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue Sep 14 10:21:17 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mQ3gr-0000SK-A4 for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 14 Sep 2021 10:21:17 +0200 Original-Received: from localhost ([::1]:60706 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mQ3gp-0008LW-Lt for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 14 Sep 2021 04:21:15 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:50760) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mQ3gd-0008Js-FI for bug-gnu-emacs@gnu.org; Tue, 14 Sep 2021 04:21:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:35887) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mQ3gc-0006BN-GK for bug-gnu-emacs@gnu.org; Tue, 14 Sep 2021 04:21:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1mQ3gc-0003Dw-A4 for bug-gnu-emacs@gnu.org; Tue, 14 Sep 2021 04:21:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 14 Sep 2021 08:21:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 50244 X-GNU-PR-Package: emacs Original-Received: via spool by 50244-submit@debbugs.gnu.org id=B50244.163160765912361 (code B ref 50244); Tue, 14 Sep 2021 08:21:02 +0000 Original-Received: (at 50244) by debbugs.gnu.org; 14 Sep 2021 08:20:59 +0000 Original-Received: from localhost ([127.0.0.1]:47433 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mQ3gZ-0003DI-Cn for submit@debbugs.gnu.org; Tue, 14 Sep 2021 04:20:59 -0400 Original-Received: from mail-wr1-f54.google.com ([209.85.221.54]:46001) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mQ3gX-0003D6-QG for 50244@debbugs.gnu.org; Tue, 14 Sep 2021 04:20:58 -0400 Original-Received: by mail-wr1-f54.google.com with SMTP id d21so11087680wra.12 for <50244@debbugs.gnu.org>; Tue, 14 Sep 2021 01:20:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version:content-transfer-encoding; bh=GkbIWqYfm0a3C6ZBQF/wAsjDfCWuu4YkHRJOb0huSo8=; b=KlRwq9wdUBTEQ+6xIa+TRVikDl6ySpeuSB5bO9wbvp9+p0fcnXBbqVb86fyHr0CqqB diSFcSaiyquMjyGd8AjH4XW6SCd4ODLPQfjoBAHcUHKI6Cutf2Qxz7731+lzT8aa+sb4 PaL/e0Z1exxNhGvK/jOpflZSMV2uhA3y9/iO0sh3WrM2fq946jlVn4xxmrVEwUSc364b 4mcAAF6gOJGjpiEcKASreCsTS3duJrHAu1sNObDb4FGotPCQHrMRA8dONi9j2QFiAzY5 /2ohWsObFy4rvB6YbIsJ4Hi/b9h1FPdNbHxz3eZXovR8iDrbxlwEp6avnb7tJUki+JSF tGig== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version:content-transfer-encoding; bh=GkbIWqYfm0a3C6ZBQF/wAsjDfCWuu4YkHRJOb0huSo8=; b=w/B9F4A5uVWzLFbFEm9xwHOB9TiZfSXzXadZw0Ybo1eSWqmdwJAPTZdz+e/eTEZr+2 dyMMNybczFnlY5PBtvPd6r0dE1LZFEhC+QjVMeWG0tgsK79Y+GSfJ65eBRVoVnB4Uh1S SyZuAshD3BtdZWpUR0jh618i2e6B1L8Xliksvdxx8GuPoGjyIF+a/riIOowtrxcFiCtV cUr/YatgHJnBCppqjUw2EnRbhC2zKRO9mRvY7PzNNYCX+cfuvKgdifKhmZXIhiT0UqFg fsQeINyuRpgJCerNB2hHt1RhfeCEUkjOQHTw21XEXbhqlAB/ysmbpda6ON8o26i/TJbr k+Lg== X-Gm-Message-State: AOAM531hYrJm32dk5WYJ2WMAsdP3Ri7eYzg3QFuRoLs9JC8Jb051fO0a frrG/ZAsoehtyoGh16AWf1k= X-Google-Smtp-Source: ABdhPJyoR9kloDPLBgZkND8P6qSLOcxUHsYrzQPoKIP+egA0PpwqB6VoYd1AJ2fWwne1lZFPgpTtPg== X-Received: by 2002:adf:e643:: with SMTP id b3mr17329937wrn.299.1631607651766; Tue, 14 Sep 2021 01:20:51 -0700 (PDT) Original-Received: from nadja (a83-132-177-247.cpe.netcabo.pt. [83.132.177.247]) by smtp.gmail.com with ESMTPSA id x21sm397089wmi.15.2021.09.14.01.20.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 14 Sep 2021 01:20:51 -0700 (PDT) In-Reply-To: <061838b7-bf19-b899-f1aa-76760fb35607@yandex.ru> (Dmitry Gutov's message of "Mon, 13 Sep 2021 23:11:51 +0300") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:214283 Archived-At: Dmitry Gutov writes: > On 13.09.2021 21:03, Jo=C3=A3o T=C3=A1vora wrote: >> The only outstanding issue preventing me from landing this in main is >> that I need to bump project.el's version so that the new >> `project-buffers` API generic function becomes officially available to >> the new bumped flymake.el version. Dmitry is it OK for me to do so? > > Yes, please go ahead. All the latest additions seem stable. Thanks. > Like mentioned previously, I think using project.el for this is > probably not ideal (rather, the diagnostic source can decide which > diagnostics belong to the current default-directory), Yes, it can, and it does (have you read the change?) In fact the diagnostic source knows nothing about projects. But at a certain point, someone will have to know about "projects", because the request is not for "default-directory-wide diagnostics", it's for project-wide diagnostics. I don't know what better library to use for segregating diagnostics into projects other than project.el: it works quite well, to be frank. That said, if even that bothers you, the uses of project.el in flymake.el are minimal and are the simplest part of this whole job. If you or someone can get rid of them and somehow keep a coherent M-x flymake-show-project-diagnostics command, it's not unthinkable. Maybe you'd prefer it renamed to M-x flymake-show-aggregated-diagnostics to get the "project" word out of there. But frankly I think the current command name and implementation is really spot-on what was requested here. At least it seems to make sense to Theodor and me as a user. Indeed, I even thought that flymake-show-project-diagnostics could go into the 'C-x p' map. But users can do that easily if they want to, so I won't argue for that now. Jo=C3=A3o