From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Amin Bandali Newsgroups: gmane.emacs.bugs Subject: bug#50007: 28.0.50; normalize logic surrounding erc-server-reconnecting Date: Wed, 22 Sep 2021 00:37:32 -0400 Message-ID: <87wnn98bub.fsf@gnu.org> References: <87a6lojcij.fsf@neverwas.me> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="25379"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: 50007@debbugs.gnu.org, "J.P." To: Stefan Kangas Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Sep 22 06:38:41 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mSu1p-0006PM-EB for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 22 Sep 2021 06:38:41 +0200 Original-Received: from localhost ([::1]:41134 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mSu1o-0002zh-4B for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 22 Sep 2021 00:38:40 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:38628) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mSu1D-00026K-5I for bug-gnu-emacs@gnu.org; Wed, 22 Sep 2021 00:38:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:36997) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mSu1C-00089r-Td for bug-gnu-emacs@gnu.org; Wed, 22 Sep 2021 00:38:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1mSu1C-0004Oy-Gr for bug-gnu-emacs@gnu.org; Wed, 22 Sep 2021 00:38:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Amin Bandali Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 22 Sep 2021 04:38:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 50007 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 50007-submit@debbugs.gnu.org id=B50007.163228546216881 (code B ref 50007); Wed, 22 Sep 2021 04:38:02 +0000 Original-Received: (at 50007) by debbugs.gnu.org; 22 Sep 2021 04:37:42 +0000 Original-Received: from localhost ([127.0.0.1]:48543 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mSu0s-0004OC-DH for submit@debbugs.gnu.org; Wed, 22 Sep 2021 00:37:42 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:49680) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mSu0q-0004Nv-Et for 50007@debbugs.gnu.org; Wed, 22 Sep 2021 00:37:41 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:51312) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mSu0k-0007lP-8p; Wed, 22 Sep 2021 00:37:34 -0400 Original-Received: from [2607:fea8:3fdf:f2d9:401a:7067:fa05:5628] (port=57954 helo=langa) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mSu0k-0004cG-3m; Wed, 22 Sep 2021 00:37:34 -0400 In-Reply-To: X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:215054 Archived-At: Hi Stefan, all, Stefan Kangas writes: > "J.P." writes: > >> Tags: patch >> >> Knowing when we're reconnecting and having that logic be as sane and >> straightforward as possible is (IMO) a critical component of unraveling >> the buffer-association game I've been trying to drag everyone into. >> >> The existing approach is troublesome because it's basically inscrutable >> in the sense of being too difficult to sit down and reason through once >> session identities enter the fray (at least for a simpleton like me). >> And though the solution I'm proposing may seem underwhelming, it wasn't >> just intuited out of thin air but rather discovered with the backing of >> behavioral tests like the ones included in these patches [1]. Thanks. >> >> >> [1] https://debbugs.gnu.org/cgi/bugreport.cgi?bug=48598 >> https://debbugs.gnu.org/cgi/bugreport.cgi?bug=49860 > > Copying in the ERC maintainer Amin Bandali here. > > Amin, could you help review this patch? I will review this patch -- and the other two you tagged me on -- but most likely not before emacs-28 is cut: per J.P.[0] the tests covering these three patches live in another, rather large, patch and I would prefer to leave the merging of these to after the other large patch is reviewed and merged (which may not be until a few more weeks). [0]: https://lists.gnu.org/r/emacs-erc/2021-09/msg00004.html Of course if you're volunteering to help test/review the large patch(es) and these three that would be very welcome. :)