From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.bugs Subject: bug#51056: 29.0.50; Making `gnus-define-keys' obsolete Date: Wed, 06 Oct 2021 12:14:13 +0200 Message-ID: <87wnmq5ukq.fsf@gnus.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="2135"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Stephen Gildea To: 51056@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Oct 06 12:15:44 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mY3xe-0000Hr-Uz for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 06 Oct 2021 12:15:42 +0200 Original-Received: from localhost ([::1]:57612 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mY3xd-0007Oc-RZ for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 06 Oct 2021 06:15:41 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:56282) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mY3x0-0007Mh-Kz for bug-gnu-emacs@gnu.org; Wed, 06 Oct 2021 06:15:05 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:59330) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mY3x0-00065Y-Cl for bug-gnu-emacs@gnu.org; Wed, 06 Oct 2021 06:15:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1mY3x0-0002E9-7M for bug-gnu-emacs@gnu.org; Wed, 06 Oct 2021 06:15:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 06 Oct 2021 10:15:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 51056 X-GNU-PR-Package: emacs X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Original-Received: via spool by submit@debbugs.gnu.org id=B.16335152658486 (code B ref -1); Wed, 06 Oct 2021 10:15:02 +0000 Original-Received: (at submit) by debbugs.gnu.org; 6 Oct 2021 10:14:25 +0000 Original-Received: from localhost ([127.0.0.1]:42643 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mY3wP-0002Cm-AV for submit@debbugs.gnu.org; Wed, 06 Oct 2021 06:14:25 -0400 Original-Received: from lists.gnu.org ([209.51.188.17]:59534) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mY3wN-0002Cf-LH for submit@debbugs.gnu.org; Wed, 06 Oct 2021 06:14:24 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:56212) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mY3wN-0006NF-F5 for bug-gnu-emacs@gnu.org; Wed, 06 Oct 2021 06:14:23 -0400 Original-Received: from quimby.gnus.org ([2a01:4f9:2b:f0f::2]:41838) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mY3wL-0005XE-3Z for bug-gnu-emacs@gnu.org; Wed, 06 Oct 2021 06:14:23 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:Date:Subject:Cc:To:From: Sender:Reply-To:Content-Transfer-Encoding:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: In-Reply-To:References:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=9w0ajc1Ba+FUdhdmzd9yFOclnsp2CZB990Q4Pvr0zoI=; b=r5F/o7hwDaMM6YYn215BwOnwsp 7Vgw4856vspFh8cuWbDRPZ6JSTvd0ofMC7/4TXMk2y2ZWnIYvZKcRFEPbt5NcXKPnCoCXNQoCkm5Y iwENZUUGKysrDMhaCyXdVFv9J+5GXfAu2bEiV29T5n8lVnhTHBSKjjmPVc+ZC+R1jd54=; Original-Received: from [84.212.220.105] (helo=elva) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mY3wD-0000te-Vc; Wed, 06 Oct 2021 12:14:16 +0200 X-Now-Playing: Stephan Mathieu's _Radiance (10): Her Dark Gaze Drowned in Light_: "Nacht" Received-SPF: pass client-ip=2a01:4f9:2b:f0f::2; envelope-from=larsi@gnus.org; helo=quimby.gnus.org X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:216537 Archived-At: Emacs 29 has grown a new function to define keymaps, `define-keymap' somewhat inspired by the more than two-decades-old macro `gnus-define-keys'. So I've now replaced all the usages of `gnus-define-keys' in Emacs 29 with `define-keymap' and was about to make `gnus-define-keys' obsolete, but that macro is used by mh-e, too. mh-e is also distributed outside Emacs, if I understand correctly, so this code can't be converted. Stephen, would it make sense to copy the Gnus macro into mh-e, and rename it mh-define-keys? That way `gnus-define-keys' could be obsoleted. A different solution would be to write a new mh-define-keymap that more closely mimics the new `define-keymap' function, and then use it instead in mh-e -- that's probably a better long-term solution, because you could then remove the mh-define-keymap function at some later date (when you shift the mh-e target to Emacs 29+). In GNU Emacs 29.0.50 (build 36, x86_64-pc-linux-gnu, GTK+ Version 3.24.24, cairo version 1.16.0) of 2021-10-06 built on elva Repository revision: 8e37466efc36dab153a9c784ce1ff41c5a663318 Repository branch: master Windowing system distributor 'The X.Org Foundation', version 11.0.12011000 System Description: Debian GNU/Linux 11 (bullseye) -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no