From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.bugs Subject: bug#51037: [PATCH] Make `print-level` & `print-length` customizable in ERT batch tests Date: Wed, 27 Oct 2021 15:15:24 +0200 Message-ID: <87wnlya9sj.fsf@gnus.org> References: <86tuhvmtpl.fsf@runbox.com> <877deqec10.fsf@gnus.org> <83fste2u4i.fsf@gnu.org> <87ily94662.fsf@gnus.org> <83fstd1bth.fsf@gnu.org> <87czogslm4.fsf@gnus.org> <86ily2mjtq.fsf@runbox.com> <87r1cp89o4.fsf@gnus.org> <86fst5m48v.fsf@runbox.com> <87a6jd5891.fsf@gnus.org> <86mtmykxro.fsf@runbox.com> <87y26hz24c.fsf@gnus.org> <86bl3blcgm.fsf@runbox.com> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="9942"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) Cc: gazally@runbox.com, 51037@debbugs.gnu.org To: Michael Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Oct 27 15:45:11 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mfjEs-0002IG-6N for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 27 Oct 2021 15:45:10 +0200 Original-Received: from localhost ([::1]:37646 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mfjEq-0005Tq-92 for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 27 Oct 2021 09:45:08 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:59612) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mfimg-0003pg-VJ for bug-gnu-emacs@gnu.org; Wed, 27 Oct 2021 09:16:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:37145) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mfimg-0006BK-MT for bug-gnu-emacs@gnu.org; Wed, 27 Oct 2021 09:16:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1mfimg-0005RC-J1 for bug-gnu-emacs@gnu.org; Wed, 27 Oct 2021 09:16:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 27 Oct 2021 13:16:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 51037 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 51037-submit@debbugs.gnu.org id=B51037.163534053519343 (code B ref 51037); Wed, 27 Oct 2021 13:16:02 +0000 Original-Received: (at 51037) by debbugs.gnu.org; 27 Oct 2021 13:15:35 +0000 Original-Received: from localhost ([127.0.0.1]:48691 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mfimE-00051g-NV for submit@debbugs.gnu.org; Wed, 27 Oct 2021 09:15:34 -0400 Original-Received: from quimby.gnus.org ([95.216.78.240]:51488) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mfimD-0004w8-4N for 51037@debbugs.gnu.org; Wed, 27 Oct 2021 09:15:33 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=H8Ae3/O/C3P5EqrHIE3bSNfD3xUzPgeQ7zxGwB3+LNg=; b=gCTsMi/TXe/tkzKlOXUK65vxEE IaKBB56i8k4o5Aovrz3orqwMw1KAYwuA59bsUyK213Em5HJh2xneY9RRM8enntX7S7+ykwlBbO34d rfJTuJZfHJci90dgLLh/60K9glNbWQXJ6625ok2f5hxg2Qec3eNtd9lItC/nf1FBEXOY=; Original-Received: from [84.212.220.105] (helo=elva) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mfim4-00062u-O0; Wed, 27 Oct 2021 15:15:27 +0200 Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwBAMAAAClLOS0AAAABGdBTUEAALGPC/xhBQAAACBj SFJNAAB6JgAAgIQAAPoAAACA6AAAdTAAAOpgAAA6mAAAF3CculE8AAAAG1BMVEV7YWGAZWChdDdz T02DW0WUaTyLY0O/jS3////xjG5rAAAAAWJLR0QIht6VegAAAAd0SU1FB+UKGwwnNcKZZ4wAAAGo SURBVDjLdZRtbsMgDIZT7QI7wqRt2v/aYf9nygGWNQeoCVfo9WcbA0mlWiopPP6I4SXTVO3kz9fT 6U2fLxO4xWowz+8272BYfgaYngE2YCOgeKljlIGDASsVK5VfIIjqBdO21JVmGBOw1Qg1ybDN5pPm jNHXSNfOlkEASTLegRmKA/HwELL6nBxEyKGV1uFjIY/41G1A1ggUlxt759c7SXBIGYh0P4IDomsR 8KWtspbBBmruH50yCquAGsCNqL6WbXyPIB0QBiDvzIZQ/3iDCL0O1i3YBoDGLWL2PiRFglok2LSB COnCNRlaUGlnnlZGGJng1sVQgL5tq4oR7gARLnoqpfARzLKtUc8y3VpXTVekOpPi7WCarmYgzqKQ 1qkAE5Eu4VFG02HWNWE1RHzoYggHAFfJc+Ym4Ye3El/s+urAJSog4Si+N2mDNnCJ5gi7F+U2m4g1 cT+sdaRaII0I3NVgDr0+0qF4vYAyFBqXSOSTknkS7d/PIuTSEc73BR+B3Xk6H6/ihB8y/lFT5wBh latZZHHLELJILFvHrkT8XTPaxyWl+o2Bfy5i+pILZg5PAAAAJXRFWHRkYXRlOmNyZWF0ZQAyMDIx LTEwLTI3VDEyOjM5OjUzKzAwOjAwtrpcyQAAACV0RVh0ZGF0ZTptb2RpZnkAMjAyMS0xMC0yN1Qx MjozOTo1MyswMDowMMfn5HUAAAAASUVORK5CYII= X-Now-Playing: Aksak Maboul's _Figures (2)_: "Tout a une fin" In-Reply-To: <86bl3blcgm.fsf@runbox.com> (Michael's message of "Tue, 26 Oct 2021 14:10:01 -0700") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:218448 Archived-At: Michael writes: > I was thinking to augment the docstring for > `backtrace-line-lenght' to note that print-level & print-length > will be overiden to honor it. Sounds good. > The problem is that I can't know a priori how big I have to set > them in order to honor print-level & print-length. No, but I thought the issue was with the corner case where we're almost up against the limit already? To work around that, doubling the limit is fine in this context. > I think I can short-circuit this entirely by setting > `backtrace-line-length' to nil or zero before printing the backtrace > from ert. eval-level shouldn't enter into it I think; the concern was > that if code exceeded max-lisp-eval-depth, and the debugger was > triggered, *then* backtrace.el might have problems. Do you see a > reason to be concerned outside of that corner case? If that works without upping the limit, then that's fine. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no