From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: =?UTF-8?Q?K=C3=A9vin?= Le Gouguec Newsgroups: gmane.emacs.bugs Subject: bug#51556: 29.0.50; Poor contrast of Customize SVG icons with dark backgrounds Date: Mon, 01 Nov 2021 21:10:13 +0100 Message-ID: <87wnlreixm.fsf@gmail.com> References: <87v91b92v6.fsf@gmail.com> <83fssflmcg.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="39028"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) Cc: 51556@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Nov 01 22:19:51 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mheid-000A14-AC for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 01 Nov 2021 22:19:51 +0100 Original-Received: from localhost ([::1]:35540 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mheic-0004ec-8Y for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 01 Nov 2021 17:19:50 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:47846) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mhde3-0000mY-6d for bug-gnu-emacs@gnu.org; Mon, 01 Nov 2021 16:11:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:52908) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mhde2-0006zY-UI for bug-gnu-emacs@gnu.org; Mon, 01 Nov 2021 16:11:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1mhde2-0007Ji-Q1 for bug-gnu-emacs@gnu.org; Mon, 01 Nov 2021 16:11:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: =?UTF-8?Q?K=C3=A9vin?= Le Gouguec Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 01 Nov 2021 20:11:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 51556 X-GNU-PR-Package: emacs Original-Received: via spool by 51556-submit@debbugs.gnu.org id=B51556.163579742528061 (code B ref 51556); Mon, 01 Nov 2021 20:11:02 +0000 Original-Received: (at 51556) by debbugs.gnu.org; 1 Nov 2021 20:10:25 +0000 Original-Received: from localhost ([127.0.0.1]:36219 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mhddR-0007IW-Gx for submit@debbugs.gnu.org; Mon, 01 Nov 2021 16:10:25 -0400 Original-Received: from mail-wr1-f43.google.com ([209.85.221.43]:40646) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mhddM-0007ID-Tl for 51556@debbugs.gnu.org; Mon, 01 Nov 2021 16:10:24 -0400 Original-Received: by mail-wr1-f43.google.com with SMTP id r8so16934256wra.7 for <51556@debbugs.gnu.org>; Mon, 01 Nov 2021 13:10:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version:content-transfer-encoding; bh=wSqSG+KFSZ/8zRkEdK/xhTprTuaaE7roaSPyceCxrhQ=; b=Nvgj4cChuWz9plZ8XskNkScVqRLDp8t+ggiU2OwDtCAAjXyNSLhExnw/UQZP0qitHN Zac+N5IYNE6DG9ASdrBSni4JvqNUBFiqISvhX76/pInh81FGidmXlgd/xpnk6e4b1Mib HE4zjSqos6d3wFIZOa7xvBz9nATi0Z8Rhe1U8QlUlAIKu1cPG+lU/fLChtlk7exSwa8W 2d1I9FzMYABa8dU7Cy5Qk7kR0+Qecvb8ur1sn6GhO6Q23IEu/EWleFKd9axx4kR2QSlR qIjwjFP8OL04ULxjq9Wpb+GG6PjfCaygDXR7swynAzp3XhD2QLZA4ZGGnezTZHzyE5lG 6Uhg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version:content-transfer-encoding; bh=wSqSG+KFSZ/8zRkEdK/xhTprTuaaE7roaSPyceCxrhQ=; b=A32BrvCA1wbaX46q6Y8KMM6StjaQxXZETB05AQ71p5rDFKYzEmIOkKSbaT20cnwMX+ +Itg02EK1ufymx9OmDNhRT0+8R54ipbX27eMVgFrDdaEXe7vQ974Z65TnkDqwJNdhwWQ qZP4ENDEyUHORwX1gkLUBhdex/6jkhM/ApfLXtdXIWCdja9Xkaho6z1wZSRiIbXNiSdF bVVGhRDut5qbdKMKFr6BZetAoYZjDNRJAfI96hUutkrPmSRN1NhviJ8MWvvYMGs7GK1t YfQ3jFepuuvsf/VEanSEXpmprTRvUr925g1HNALocS3Uysaj2VObiax7qAhfphboXLx1 ZmAg== X-Gm-Message-State: AOAM533hOcJhIIOQeDZlc/IIq0NsKmGObdcdxGdzU6mH0U7SyjEzLQgJ 9CBH3/KJ2VkLDo8QUe9fGMkrwy6E9QU= X-Google-Smtp-Source: ABdhPJyv2MhH6Z+N/OtGfpPI4lc7PxMHJwZRDvsKeDCnslneuU5jR/qGyWBr1Q6z/krh06pZjikTjg== X-Received: by 2002:a05:600c:1c1a:: with SMTP id j26mr1348383wms.28.1635797414581; Mon, 01 Nov 2021 13:10:14 -0700 (PDT) Original-Received: from amdahl30 ([2a01:e0a:253:fe0:2ef0:5dff:fed2:7b49]) by smtp.gmail.com with ESMTPSA id u10sm18715404wrs.5.2021.11.01.13.10.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 01 Nov 2021 13:10:14 -0700 (PDT) In-Reply-To: <83fssflmcg.fsf@gnu.org> (Eli Zaretskii's message of "Mon, 01 Nov 2021 21:14:39 +0200") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:218792 Archived-At: Eli Zaretskii writes: >> From: K=C3=A9vin Le Gouguec >> Date: Mon, 01 Nov 2021 18:56:13 +0100 >>=20 >> On darker themes (e.g. modus-vivendi), the Customize SVG icons >> (etc/images/right.svg and etc/images/down.svg) are not very visible, due >> to the poor contrast between their fill color (#2e3436) and dark >> backgrounds[1]. > > That's for the themes to resolve, isn't it? They could supply their > own icons, because only they know which colors will go well with the > theme's colors. That's sort of what I suggest? In the rest of my message, I propose allowing widgets to apply faces to their icons (:on-glyph and :off-glyph), so that themes can customize these faces. This should work for all SVG images that do not define a fill color. Or is there a way for themes to define sets of icons? "(elisp) Custom Themes" describes custom-theme-set-variables and custom-theme-set-faces, but I couldn't find anything related to icons. Or are you suggesting adding the ability for themes to include sets of icons? That seems a bit heavy-handed to me; I don't think a lot of theme authors will want to bother with SVG editing. For the purposes of this bug, merely letting themes customize the icon color (through faces) ought to be enough? I'm not sure which path forward you prefer (if any). Sorry for being slow.