From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.bugs Subject: bug#47291: bug#51404: Support system dark mode on Windows 10 Date: Thu, 11 Nov 2021 06:36:09 +0100 Message-ID: <87wnlf8d9y.fsf@gnus.org> References: <834k93zxyo.fsf@gnu.org> <838ryfyawv.fsf@gnu.org> <83r1c5tyar.fsf@gnu.org> <83a6iqpzrv.fsf@gnu.org> <83k0huo1iy.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="36880"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) Cc: Vince Salvino , 51404@debbugs.gnu.org, 47291@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Nov 11 06:37:21 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1ml2m1-0009OW-3b for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 11 Nov 2021 06:37:21 +0100 Original-Received: from localhost ([::1]:53042 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ml2lz-00089E-Mr for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 11 Nov 2021 00:37:19 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:45242) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ml2lj-00088X-4C for bug-gnu-emacs@gnu.org; Thu, 11 Nov 2021 00:37:03 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:56564) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1ml2lh-0000pR-UB for bug-gnu-emacs@gnu.org; Thu, 11 Nov 2021 00:37:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1ml2lh-0004OF-NS for bug-gnu-emacs@gnu.org; Thu, 11 Nov 2021 00:37:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 11 Nov 2021 05:37:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 47291 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 47291-submit@debbugs.gnu.org id=B47291.163660898316800 (code B ref 47291); Thu, 11 Nov 2021 05:37:01 +0000 Original-Received: (at 47291) by debbugs.gnu.org; 11 Nov 2021 05:36:23 +0000 Original-Received: from localhost ([127.0.0.1]:39875 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ml2l5-0004Mr-HN for submit@debbugs.gnu.org; Thu, 11 Nov 2021 00:36:23 -0500 Original-Received: from quimby.gnus.org ([95.216.78.240]:50206) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ml2l2-0004MY-NG; Thu, 11 Nov 2021 00:36:21 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=mzjntn0LwIWCNzk4cYH++LOQharC2AAiBkT2W6+tp1Q=; b=u5fp25xI3tKkJYi73d3rPITLoQ iRWtHX3oFTWw89jHamnfZcbR3SfW24UGWaOt4sjIujP7J1mAzPdikNZeaLNLZinaHZ1lbVkAumSUM RONkkXvTuOCOmjAa9lbVn5EDTtVCWXJ/Lf+TSw1qHZeDPj26PQww5oH9OJN7Wn+dky1Q=; Original-Received: from [84.212.220.105] (helo=xo) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1ml2kt-0002j9-NN; Thu, 11 Nov 2021 06:36:14 +0100 X-Now-Playing: King Crimson's _The Complete 1969 Recordings (26): BBC Sessions_: "Trees" In-Reply-To: <83k0huo1iy.fsf@gnu.org> (Eli Zaretskii's message of "Sat, 30 Oct 2021 20:39:17 +0300") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:219595 Archived-At: Eli Zaretskii writes: > I'm not sure I understand why 'light' necessarily means the old > behavior: we didn't set any theme before this change, we just used the > Windows default. So maybe there should be 4 values: > > nil: never follow the system theme (use Windows default) > t: always follow the system theme > light: force light theme (currently the same as nil) > dark: force dark theme. For a similar bug report, see bug#47291. And we really should support this on GNU/Linux, too, so having three different methods to support this seems sub-optimal. dynamic-setting.el seems like the most likely place to centralise all this, I think? I've had a look at what happens when you change the theme in Gnome, and dynamic-setting-handle-config-changed-event gets called with an (config-changed-event theme-name ":1") event. (But not what the event name is -- anybody know how to get at that?) -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no