From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.bugs Subject: bug#47291: bug#51404: Support system dark mode on Windows 10 Date: Thu, 11 Nov 2021 13:15:03 +0100 Message-ID: <87wnle6g8o.fsf@gnus.org> References: <834k93zxyo.fsf@gnu.org> <838ryfyawv.fsf@gnu.org> <83r1c5tyar.fsf@gnu.org> <83a6iqpzrv.fsf@gnu.org> <83k0huo1iy.fsf@gnu.org> <87wnlf8d9y.fsf@gnus.org> <83wnlf166j.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="16896"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) Cc: salvino@coderedcorp.com, 51404@debbugs.gnu.org, 47291@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Nov 11 13:19:10 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1ml92r-0004C6-QJ for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 11 Nov 2021 13:19:09 +0100 Original-Received: from localhost ([::1]:41924 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ml92q-0002oj-Pv for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 11 Nov 2021 07:19:08 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:41680) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ml8zr-0005bm-7L for bug-gnu-emacs@gnu.org; Thu, 11 Nov 2021 07:16:04 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:57031) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1ml8zq-0004Rr-9H for bug-gnu-emacs@gnu.org; Thu, 11 Nov 2021 07:16:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1ml8zq-0007ll-1d for bug-gnu-emacs@gnu.org; Thu, 11 Nov 2021 07:16:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 11 Nov 2021 12:16:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 47291 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 47291-submit@debbugs.gnu.org id=B47291.163663293229807 (code B ref 47291); Thu, 11 Nov 2021 12:16:01 +0000 Original-Received: (at 47291) by debbugs.gnu.org; 11 Nov 2021 12:15:32 +0000 Original-Received: from localhost ([127.0.0.1]:40342 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ml8zL-0007kd-70 for submit@debbugs.gnu.org; Thu, 11 Nov 2021 07:15:31 -0500 Original-Received: from quimby.gnus.org ([95.216.78.240]:53624) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ml8z3-0007jw-ID; Thu, 11 Nov 2021 07:15:29 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=GP54OdRhE5PVChyqcqHU57Gn/RE/mHzenueTptACiqk=; b=oIX1s7mLR03+ZXsZL5JhzfPlRj W8UKQwH/Bxek6BHId76cGvTs9MG8HQuTanbTqaFunrSCTyYLm1iiKBGCwgwF8FyTxNWW+WbK3KN8P FpadLexHISXNBkdEWhyUT3sWmcCufuNwWxMZ9/S+b4S1ihMUAsTyR2ePceHiFxSlFtZM=; Original-Received: from [84.212.220.105] (helo=xo) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1ml8yu-0005Xq-7E; Thu, 11 Nov 2021 13:15:07 +0100 Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwBAMAAAClLOS0AAAABGdBTUEAALGPC/xhBQAAACBj SFJNAAB6JgAAgIQAAPoAAACA6AAAdTAAAOpgAAA6mAAAF3CculE8AAAAGFBMVEWDe3BYU0yll4K9 oXnauo3gvo7gwZT///+NHmO0AAAAAWJLR0QHFmGI6wAAAAd0SU1FB+ULCwwJAYVT5DoAAAG3SURB VDjLdZNNbqQwEIXd0WQPMxdApJV1NEazjgabA6SrvI4S7PsfYV65yuBoOg+1G/zh+sddxsFBF9fr Mo5uVGB6mEWTvDiOPqjWZfWLX+yhA00ciO+CWErJ94Cw9A2476MHEe6aFZKVBCDAyBCWgr/EEXc3 M4VbpRCecjbAQZ4D4YrIAuF+GrBXQyo7fqVwc67msZoOH0DRDpYsPzG16o6uhRE5fMgJDYoJoKSS iaRYCmJAEsFegDY1JTY0XckR9uVSEGEYLMIt58Qpa1TNBJmrCD+1iCfQm5Bh9DwRa+aBu7LX5xps /toP2U+v0+Oru/4HYlj9n7/TY64Z9uDlYXIf8/S87j5sEsZqCYbg5zeAp3fnniP62wDvbnqar9f9 uiy18c0U0W/v/fzjw/38tZuPoYKIRqF1exfVoPWz9qacKZ6AD2G37ImogRhqYdE6VJq2OtTD2SCZ AjFHp3O1XyzxA+h+THXumPpwq9c21tJPBTUcOioLk3Q7ANcia7Ig5wk5j0+A61TVuRq00dBWTu0C zFAd86ZbAzYEGKkOBJsdU52LdqLbly+Vws3K/kUba8/vaBjHf0usLVcfdy2oAAAAJXRFWHRkYXRl OmNyZWF0ZQAyMDIxLTExLTExVDEyOjA5OjAwKzAwOjAwgbmcCQAAACV0RVh0ZGF0ZTptb2RpZnkA MjAyMS0xMS0xMVQxMjowOTowMCswMDowMPDkJLUAAAAASUVORK5CYII= X-Now-Playing: Hype Williams's _Junt-Deez Ruins You See_: "Infinity" In-Reply-To: <83wnlf166j.fsf@gnu.org> (Eli Zaretskii's message of "Thu, 11 Nov 2021 09:51:16 +0200") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:219632 Archived-At: Eli Zaretskii writes: > I'm not sure unification is possible here, because the functionality > is quite different, AFAICT. At least for the functionality in this > bug report, we cannot apply the system theme to an existing frame, we > can only apply it at frame creation time. So having a handler for > such changes will be able to affect only the frames created after the > change. Or at least that is my understanding; the code definitely > applies the dark/light theme as part of creating a frame. Gtk Emacs doesn't respond to dark mode either -- so we have the opportunity to decide how to handle these things across the board. Perhaps in Gtk Emacs, dynamic-setting-handle-config-changed-event should also just set something that will make the next frame creation use different colours? > Also, having a dynamic thing that tracks changes in these settings > would on Windows mean listening and processing a special window-system > message, which seems to be WM_THEMECHANGED or maybe WM_SETTINGCHANGE. > But that's not what the code installed in this bug report does. > > So the functionality seems similar, but the details differ. But perhaps Windows should be listening to those events, too? -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no