From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Matthias Meulien Newsgroups: gmane.emacs.bugs Subject: bug#51809: 29.0.50; [PATCH] Support for outline default state in Diff buffers Date: Sun, 26 Dec 2021 21:55:30 +0100 Message-ID: <87wnjrkrwd.fsf@gmail.com> References: <87lf1sw6ji.fsf@gmail.com> <86h7cgdk4v.fsf@mail.linkov.net> <87ee7kvshn.fsf@gmail.com> <87a6i7x5iq.fsf@gmail.com> <86k0hbam7r.fsf@mail.linkov.net> <878rxrmy7q.fsf@gmail.com> <86y256uc0v.fsf@mail.linkov.net> <87r1ajknsr.fsf@gmail.com> <86ilvu6w6k.fsf@mail.linkov.net> <871r2hc51a.fsf@gmail.com> <87r19zs662.fsf@gmail.com> <871r1zm7ji.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="31578"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) Cc: 51809@debbugs.gnu.org To: Juri Linkov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Dec 26 21:56:23 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1n1aZ5-00082f-2H for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 26 Dec 2021 21:56:23 +0100 Original-Received: from localhost ([::1]:54500 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1n1aZ3-0004Kq-Vh for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 26 Dec 2021 15:56:22 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:37778) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1n1aYk-0004Jr-Lz for bug-gnu-emacs@gnu.org; Sun, 26 Dec 2021 15:56:04 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:58385) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1n1aYk-00036h-1C for bug-gnu-emacs@gnu.org; Sun, 26 Dec 2021 15:56:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1n1aYk-0000Fu-0s for bug-gnu-emacs@gnu.org; Sun, 26 Dec 2021 15:56:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Matthias Meulien Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 26 Dec 2021 20:56:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 51809 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 51809-submit@debbugs.gnu.org id=B51809.1640552139937 (code B ref 51809); Sun, 26 Dec 2021 20:56:01 +0000 Original-Received: (at 51809) by debbugs.gnu.org; 26 Dec 2021 20:55:39 +0000 Original-Received: from localhost ([127.0.0.1]:41697 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n1aYM-0000F2-U5 for submit@debbugs.gnu.org; Sun, 26 Dec 2021 15:55:39 -0500 Original-Received: from mail-wr1-f41.google.com ([209.85.221.41]:34316) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n1aYL-0000Ed-7n for 51809@debbugs.gnu.org; Sun, 26 Dec 2021 15:55:37 -0500 Original-Received: by mail-wr1-f41.google.com with SMTP id s1so28833308wrg.1 for <51809@debbugs.gnu.org>; Sun, 26 Dec 2021 12:55:37 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=uyPAa1ThAg+97ewM6vtuowBMaz4klm8UEufT4FiH/gY=; b=OJULhCac+gra/QKkOPYlkhApt0qIo21vsBXEF6U4mOSaPc64goBQ9yDLX2xm1nqlTl BPlQV5K06ATbGYS6OP2zHv/CEJoAxp/Awu8Ukrbo+EE893iNXnlLpNwqFxr2pfFQQnln SZAz9yIdIlkCQ1RH4YbBHvBhzU6WUg+Q68E+R7br0oUBFXzeQVmlhm+/BTrOGbId6QJg WnxKgnMGrYiDx+zd5Cxd2dtBTmp1N2ZIXrXXUPdEj+KjuB5pJ3O5jQOE7LMjqGib0vMF TSESCq2cn2TuAqBUZ1SSw5+vND73E5PcQEe7m/vjL8nUq7AEyMaFYsGq/CsBeCyzAB42 bkWw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=uyPAa1ThAg+97ewM6vtuowBMaz4klm8UEufT4FiH/gY=; b=zOJ6BgUPnNckrVL59c5HPTDetbevNhba8FRwSIzEMTxozhzuovSSIpg9dhQZ4mWAnt lLQGfu6rtG43SFf+UXJEs7LpOrb8E2QqZqj9bA74vdc7SikAfu4ECVlYHySn5YUEQQMZ WH4ocqH1dyxJVfv9xtn5JpIMDmQD5g11+4CVUhdQmBoxc2EbbwoQxWzQEeW06YgTVMVe G+kh5lgbQUPbvDjvPCtGhCKvzv9se8Z7icuIpnp1A0KuoedUEysbwGK9qetSDFBzaQMp 8vJi67K3YstOXBSZoKS00T9pmByoeh3dtnQHHsb2ezPZrLi2wevLSpF6tQ5ctOAxCF6y PsGg== X-Gm-Message-State: AOAM531PdOxW/Ic12c+jkhdDAbLg6mYGR+BtYefaxZVcU593oHwBNnpA jVkqDfy80pVOhCjg2Bih1CB1iFOm5aE= X-Google-Smtp-Source: ABdhPJwR2klHc/PfQvzAHj7Y2fVJTw9AA3i1jQy785tkH/tI2QDhZAn/Gz1O67p6hqqfIR+3eVfUVQ== X-Received: by 2002:a5d:61cf:: with SMTP id q15mr10363426wrv.623.1640552131362; Sun, 26 Dec 2021 12:55:31 -0800 (PST) Original-Received: from carbon.localdomain ([2a01:e0a:245:c850:98f5:429a:aa8e:95bb]) by smtp.gmail.com with ESMTPSA id g18sm12355479wmq.5.2021.12.26.12.55.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 26 Dec 2021 12:55:30 -0800 (PST) In-Reply-To: <871r1zm7ji.fsf@gmail.com> (Matthias Meulien's message of "Sun, 26 Dec 2021 21:32:17 +0100") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:223166 Archived-At: Matthias Meulien writes: > I am now back to the origin of this bug report (toggling visibility of > some diff hunks depending on long lines, chunks size, or file names) and > I see there's a major drawback with the outline mode default visibility > state approach: When outline minor mode is set through diff-mode-hook, > the buffer is emtpy and applying the default state visibility is a > no-op; It's a side-effect of the buffer content being generated > asynchronously... I fixed it using an advice to `vc-diff-finish', but wondering whether there's a clean way to achieve the same... For posterity, here is a sample configuration for *vc-diff* buffers to hide hunks with long lines, long hunks or matching some regexp. (add-hook 'diff-mode-hook #'(lambda () (setq diff-font-lock-prettify t outline-default-state 1 outline-default-state-subtree-visibility '(subtree-is-long subtree-has-long-lines (match-regexp . "NEWS\\|test"))) (outline-minor-mode))) (defadvice vc-diff-finish (after ensure-outline-apply-default-state activate) (when outline-minor-mode (outline-apply-default-state)))