From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Andreas Schwab Newsgroups: gmane.emacs.bugs Subject: bug#53227: master: Wrong error message with M-: (funcall). Date: Fri, 14 Jan 2022 10:55:40 +0100 Message-ID: <87wnj263qb.fsf@igel.home> References: <874k683smu.fsf@gmail.com> <87mtk0ugjn.fsf@gnus.org> <87pmov52gx.fsf@igel.home> <87fspr4pga.fsf@igel.home> <87pmov2un5.fsf@igel.home> <87lezj2nds.fsf@igel.home> <87h7a72mta.fsf@igel.home> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="23870"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.91 (gnu/linux) Cc: 53227@debbugs.gnu.org, acm@muc.de, larsi@gnus.org, rpluim@gmail.com To: Stefan Monnier Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Jan 14 10:56:11 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1n8JJb-00062C-6X for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 14 Jan 2022 10:56:11 +0100 Original-Received: from localhost ([::1]:44018 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1n8JJa-0005dB-8s for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 14 Jan 2022 04:56:10 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:54164) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1n8JJS-0005XR-8t for bug-gnu-emacs@gnu.org; Fri, 14 Jan 2022 04:56:03 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:42770) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1n8JJR-0001ZY-VV for bug-gnu-emacs@gnu.org; Fri, 14 Jan 2022 04:56:01 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1n8JJR-0003xh-Ua for bug-gnu-emacs@gnu.org; Fri, 14 Jan 2022 04:56:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Andreas Schwab Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 14 Jan 2022 09:56:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 53227 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 53227-submit@debbugs.gnu.org id=B53227.164215414815205 (code B ref 53227); Fri, 14 Jan 2022 09:56:01 +0000 Original-Received: (at 53227) by debbugs.gnu.org; 14 Jan 2022 09:55:48 +0000 Original-Received: from localhost ([127.0.0.1]:35673 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n8JJE-0003xB-29 for submit@debbugs.gnu.org; Fri, 14 Jan 2022 04:55:48 -0500 Original-Received: from mail-out.m-online.net ([212.18.0.10]:59329) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n8JJA-0003wy-Iw for 53227@debbugs.gnu.org; Fri, 14 Jan 2022 04:55:46 -0500 Original-Received: from frontend01.mail.m-online.net (unknown [192.168.8.182]) by mail-out.m-online.net (Postfix) with ESMTP id 4JZxWL41PZz1s9RW; Fri, 14 Jan 2022 10:55:42 +0100 (CET) Original-Received: from localhost (dynscan1.mnet-online.de [192.168.6.70]) by mail.m-online.net (Postfix) with ESMTP id 4JZxWL1Ftcz1qqkJ; Fri, 14 Jan 2022 10:55:42 +0100 (CET) X-Virus-Scanned: amavisd-new at mnet-online.de Original-Received: from mail.mnet-online.de ([192.168.8.182]) by localhost (dynscan1.mail.m-online.net [192.168.6.70]) (amavisd-new, port 10024) with ESMTP id A1gesf0KoVGD; Fri, 14 Jan 2022 10:55:41 +0100 (CET) X-Auth-Info: 4JFVZywX1IFSKvUdxVaMvKi4yI6a3fb8nS5HMadOPp2ns0mnhlJjaThwTjnO2plv Original-Received: from igel.home (ppp-46-244-178-192.dynamic.mnet-online.de [46.244.178.192]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.mnet-online.de (Postfix) with ESMTPSA; Fri, 14 Jan 2022 10:55:41 +0100 (CET) Original-Received: by igel.home (Postfix, from userid 1000) id 9543E2C323E; Fri, 14 Jan 2022 10:55:40 +0100 (CET) X-Yow: .. Now I think I just reached the state of HYPERTENSION that comes JUST BEFORE you see the TOTAL at the SAFEWAY CHECKOUT COUNTER! In-Reply-To: (Stefan Monnier's message of "Thu, 13 Jan 2022 19:19:50 -0500") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:224192 Archived-At: On Jan 13 2022, Stefan Monnier wrote: >>> (`(funcall . ,_) form) ;bug#53227 >>> >>> is then present to make sure the first change doesn't worsen the >>> rest of the resulting macroexpanded code. >> >> I don't understand. How much better than (funcall) can it get? > > I'm not talking about the quality of the code output by > `macroexp--expand-all` but about the quality of the code *of* > `macroexp--expand-all`. You mean this? @@ -534,16 +534,14 @@ byte code for macroexp--expand-all: 431 stack-ref 3 432 call 2 433 return -434:28 stack-ref 2 -435 stack-ref 5 -436 stack-ref 3 -437 call 2 -438 return -439:29 stack-ref 1 -440 stack-ref 4 -441 stack-ref 2 -442 call 2 -443 return -444:30 stack-ref 2 -445 car-safe -446 return +434:28 stack-ref 4 +435 car-safe +436 return +437:29 stack-ref 1 +438 stack-ref 4 +439 stack-ref 2 +440 call 2 +441 return +442:30 stack-ref 2 +443 car-safe +444 return Hardly worth optimizing for a case that never occurs, IMHO. -- Andreas Schwab, schwab@linux-m68k.org GPG Key fingerprint = 7578 EB47 D4E5 4D69 2510 2552 DF73 E780 A9DA AEC1 "And now for something completely different."