bug#19341: Change Log mode filling of multi-line file lists

bug#19341: Change Log mode filling of multi-line file lists

[Glenn Morris]

Package: emacs
Version: 24.4
Severity: minor

I can't find the reference for why I think this, so maybe I'm just
wrong, but I always thought that multi-line file lists should be written
in ChangeLogs as:

   * file1, file2, file3, file4, file5, file6, file7, file8, file9:
   * file10, file11:

But Change Log mode fills such lines as:

    * file1, file2, file3, file4, file5, file6, file7, file8, file9,
    file10, file11:

Please could it use the former format.

TIA.

bug#19341: Change Log mode filling of multi-line file lists

[Eli Zaretskii]

> From: Glenn Morris <rgm@gnu.org>
> Date: Wed, 10 Dec 2014 16:07:58 -0500
> 
> I can't find the reference for why I think this, so maybe I'm just
> wrong, but I always thought that multi-line file lists should be written
> in ChangeLogs as:
> 
>    * file1, file2, file3, file4, file5, file6, file7, file8, file9:
>    * file10, file11:
> 
> But Change Log mode fills such lines as:
> 
>     * file1, file2, file3, file4, file5, file6, file7, file8, file9,
>     file10, file11:
> 
> Please could it use the former format.

It does neither.  It does this instead:

	* file1:

	* file2:

	* file3:

bug#19341: Change Log mode filling of multi-line file lists

[Glenn Morris]

Eli Zaretskii wrote:
>> But Change Log mode fills such lines as:
>> 
>>     * file1, file2, file3, file4, file5, file6, file7, file8, file9,
>>     file10, file11:
>> 
>> Please could it use the former format.
>
> It does neither.  It does this instead:
>
> 	* file1:
>
> 	* file2:
>
> 	* file3:

Really?

You type:

     * file1, file2, file3, ...

and auto-fill gives you the format you quote? That seems very odd to me,
and not what I see. But that's not really relevant AFAICS, since it's
not the format I asked for.

bug#19341: Change Log mode filling of multi-line file lists

[Eli Zaretskii]

> From: Glenn Morris <rgm@gnu.org>
> Cc: 19341@debbugs.gnu.org
> Date: Wed, 10 Dec 2014 22:41:43 -0500
> 
> Eli Zaretskii wrote:
> >> But Change Log mode fills such lines as:
> >> 
> >>     * file1, file2, file3, file4, file5, file6, file7, file8, file9,
> >>     file10, file11:
> >> 
> >> Please could it use the former format.
> >
> > It does neither.  It does this instead:
> >
> > 	* file1:
> >
> > 	* file2:
> >
> > 	* file3:
> 
> Really?
> 
> You type:
> 
>      * file1, file2, file3, ...
> 
> and auto-fill gives you the format you quote?

Well, if you just type manually a bunch of file names, how is Emacs to
know they are file names?  You can format it any way you like, it's
just text as far as Emacs is concerned.

The format I show above is produced by "C-x 4 a" and friends, when you
type that command in several buffers one after the other.

> But that's not really relevant AFAICS, since it's not the format I
> asked for.

How do you expect Emacs to distinguish between a list of files and
arbitrary text, in your scenario?  You only want it to do that
for files, right?

bug#19341: Change Log mode filling of multi-line file lists

[Glenn Morris]

Eli Zaretskii wrote:

> How do you expect Emacs to distinguish between a list of files and
> arbitrary text, in your scenario?  You only want it to do that
> for files, right?

Files are what come after "TAB * ". Font-lock manages to figure it out.

bug#19341: Change Log mode filling of multi-line file lists

[Eli Zaretskii]

> From: Glenn Morris <rgm@gnu.org>
> Cc: 19341@debbugs.gnu.org
> Date: Thu, 11 Dec 2014 11:56:08 -0500
> 
> Eli Zaretskii wrote:
> 
> > How do you expect Emacs to distinguish between a list of files and
> > arbitrary text, in your scenario?  You only want it to do that
> > for files, right?
> 
> Files are what come after "TAB * ". Font-lock manages to figure it out.

Your example was this:

   * file1, file2, file3, file4, file5, file6, file7, file8, file9:
   * file10, file11:

In this example, file1 and file10 follow "TAB * ", but all the rest do
not.

bug#19341: Change Log mode filling of multi-line file lists

[Glenn Morris]

OK, well, pretend I explained what the likely characters in a file name
are (the ones which ChangeLog mode already knows about, since it
font-locks them).

In summary, I think it's possible and you don't. In the unlikely event
someone ever works on this, they can make up their own mind.

bug#19341: Change Log mode filling of multi-line file lists

[Lars Ingebrigtsen]

Glenn Morris <rgm@gnu.org> writes:

> I can't find the reference for why I think this, so maybe I'm just
> wrong, but I always thought that multi-line file lists should be written
> in ChangeLogs as:
>
>    * file1, file2, file3, file4, file5, file6, file7, file8, file9:
>    * file10, file11:
>
> But Change Log mode fills such lines as:
>
>     * file1, file2, file3, file4, file5, file6, file7, file8, file9,
>     file10, file11:
>
> Please could it use the former format.

Makes sense to me, so I've now fixed this in Emacs 29.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

bug#19341: Change Log mode filling of multi-line file lists

[Glenn Morris]

Lars Ingebrigtsen wrote:

> Makes sense to me, so I've now fixed this in Emacs 29.

Thanks, but I don't see where. (I find it very helpful to have the
relevant git hash, or indeed the whole commit, in bug closure messages.)

bug#19341: Change Log mode filling of multi-line file lists

[Robert Pluim]

>>>>> On Tue, 25 Jan 2022 12:56:34 -0500, Glenn Morris <rgm@gnu.org> said:

    GM> Lars Ingebrigtsen wrote:
    >> Makes sense to me, so I've now fixed this in Emacs 29.

    GM> Thanks, but I don't see where. (I find it very helpful to have the
    GM> relevant git hash, or indeed the whole commit, in bug closure messages.)

fb16a6c124

found via 'git log --grep 19341'

Robert
-- 

bug#19341: Change Log mode filling of multi-line file lists

[Lars Ingebrigtsen]

Glenn Morris <rgm@gnu.org> writes:

> Thanks, but I don't see where. (I find it very helpful to have the
> relevant git hash, or indeed the whole commit, in bug closure messages.)

Forgot to push as usual.  It would indeed be nice to have the commits in
the bug tracker, but it's too much work.

(Somebody could set up a Git commit hook that posts diffs that refer to
patches to be bug tracker, though.)

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no