From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eric Abrahamsen Newsgroups: gmane.emacs.bugs Subject: bug#53989: 29.0.50; Gnus searches broken Date: Fri, 18 Feb 2022 08:01:03 -0800 Message-ID: <87wnhsmaf4.fsf@ericabrahamsen.net> References: <874k52i0ef.fsf@web.de> <87v8xijcuo.fsf@ericabrahamsen.net> <875ypicac2.fsf@web.de> <871r06c9ed.fsf@web.de> <874k51hzey.fsf@ericabrahamsen.net> <874k51qd1k.fsf@web.de> <87ee45gi6j.fsf@ericabrahamsen.net> <87v8xhowz1.fsf@web.de> <871r05ghfj.fsf@ericabrahamsen.net> <87pmnpowif.fsf@web.de> <87h791ow4f.fsf@web.de> <87pmnpf1wq.fsf@ericabrahamsen.net> <87wnhw9759.fsf@web.de> <878rucg5cu.fsf@ericabrahamsen.net> <87v8xg7oce.fsf@web.de> <8735kjd89w.fsf@ericabrahamsen.net> <87k0dtq60w.fsf@web.de> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="40830"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) Cc: 53989@debbugs.gnu.org To: Michael Heerdegen Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Feb 18 17:02:36 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nL5iM-000ALU-NS for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 18 Feb 2022 17:02:34 +0100 Original-Received: from localhost ([::1]:39630 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nL5iL-0003my-8I for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 18 Feb 2022 11:02:33 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:33158) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nL5hq-0003mn-6d for bug-gnu-emacs@gnu.org; Fri, 18 Feb 2022 11:02:02 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:34114) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nL5hp-000129-Su for bug-gnu-emacs@gnu.org; Fri, 18 Feb 2022 11:02:01 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1nL5hp-00053G-MQ for bug-gnu-emacs@gnu.org; Fri, 18 Feb 2022 11:02:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eric Abrahamsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 18 Feb 2022 16:02:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 53989 X-GNU-PR-Package: emacs Original-Received: via spool by 53989-submit@debbugs.gnu.org id=B53989.164520007319358 (code B ref 53989); Fri, 18 Feb 2022 16:02:01 +0000 Original-Received: (at 53989) by debbugs.gnu.org; 18 Feb 2022 16:01:13 +0000 Original-Received: from localhost ([127.0.0.1]:56244 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nL5h2-00052A-TV for submit@debbugs.gnu.org; Fri, 18 Feb 2022 11:01:13 -0500 Original-Received: from mail.ericabrahamsen.net ([52.70.2.18]:52560) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nL5h0-00051t-M6 for 53989@debbugs.gnu.org; Fri, 18 Feb 2022 11:01:11 -0500 Original-Received: from localhost (c-71-197-232-41.hsd1.wa.comcast.net [71.197.232.41]) (Authenticated sender: eric@ericabrahamsen.net) by mail.ericabrahamsen.net (Postfix) with ESMTPSA id D9CA7FA08F; Fri, 18 Feb 2022 16:01:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ericabrahamsen.net; s=mail; t=1645200065; bh=0ynQYJqgNG4Rl1R4pLzvZ3RV9GNaE4fmsYrimPgFneE=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=EXjFBvBeUbIjpcdxdufeJnzSa55XxwFaiUtXYoR5/ICKYUZfgMX6KVZx3E0B0dR+K WVzRdQv1TREDvri/VEJdKv6fQyGxwi4EO36mbGW5M3F1ncaSSZAICO3JrupeehEpXC CkkgtbFWBTkb5GAukxI7JLtXfIL6qBQ1uW51mYB0= In-Reply-To: <87k0dtq60w.fsf@web.de> (Michael Heerdegen's message of "Fri, 18 Feb 2022 03:10:07 +0100") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:227155 Archived-At: On 02/18/22 03:10 AM, Michael Heerdegen wrote: > Eric Abrahamsen writes: > >> Okay, it turns out that also lets us drop most of the regexp silliness >> from the parsing stuff. Would you mind trying the attached patch and >> confirm that it doesn't break anything? I'll try to make this the last >> time I mess with search results parsing... > > Works so far for me. > > | +(cl-defmethod gnus-search-indexed-extract :around > | + ((_engine gnus-search-indexed)) > | + (let ((ret (cl-call-next-method))) > > Why do you need an :around method here - why don't you just add that to > the primary method? Hmm... I think I was originally trying to do more in this method -- prefix removal and all that. You're right this isn't necessary. > | + ;; We run `expand-file-name' here in order to collapse multiple > | + ;; consecutive directory separators. > | + (cl-callf expand-file-name (car ret)) > | + ret)) > > If I were you I would add to the comment that mairix may return such > multi-separator file names - else it's not clear why that collapsing is > necessary at that point. I think I'd rather leave it like this. We don't know if the behavior might appear under other circumstances, and in the end the real problem is multiple separators, not mairix.