From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.bugs Subject: bug#29972: 25.3; dired-hide-details-mode does not persist in desktop session Date: Sun, 17 Apr 2022 20:22:39 +0200 Message-ID: <87wnfn7eog.fsf@gnus.org> References: Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="30467"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) Cc: 29972@debbugs.gnu.org To: Yuen Ho Wong Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Apr 17 20:56:02 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1ngA42-0007lK-7f for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 17 Apr 2022 20:56:02 +0200 Original-Received: from localhost ([::1]:58748 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ngA40-0008KG-Ud for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 17 Apr 2022 14:56:00 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:55952) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ng9Z4-0006gF-BF for bug-gnu-emacs@gnu.org; Sun, 17 Apr 2022 14:24:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:43247) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1ng9Z4-0000iV-05 for bug-gnu-emacs@gnu.org; Sun, 17 Apr 2022 14:24:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1ng9Z3-0001tN-QI for bug-gnu-emacs@gnu.org; Sun, 17 Apr 2022 14:24:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 17 Apr 2022 18:24:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 29972 X-GNU-PR-Package: emacs Original-Received: via spool by 29972-submit@debbugs.gnu.org id=B29972.16502197837194 (code B ref 29972); Sun, 17 Apr 2022 18:24:01 +0000 Original-Received: (at 29972) by debbugs.gnu.org; 17 Apr 2022 18:23:03 +0000 Original-Received: from localhost ([127.0.0.1]:37141 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ng9Y6-0001rt-NG for submit@debbugs.gnu.org; Sun, 17 Apr 2022 14:23:03 -0400 Original-Received: from quimby.gnus.org ([95.216.78.240]:45334) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ng9Y4-0001rC-V3 for 29972@debbugs.gnu.org; Sun, 17 Apr 2022 14:23:01 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=+XgFKAMM48djkrJpbHmlIc5eqKpIX+O+n/i17vJF494=; b=iJD1CbCMynliFkxvFKAbUlzlXr HrluY+Y04IfDGZKT1LQQrLEc/BICZXSpc7j0JwBLlRUFNVPkGlwvjHNTHHuj/sFgIJgW4ojJU4+0w XZbUar6t/BV50kipemS9W+G0f/bGGH4lvTTWXBzjzvRgfKuSrvMZJPNVk6Gvd8uocbPQ=; Original-Received: from [84.212.220.105] (helo=xo) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1ng9Xl-0000EA-4u; Sun, 17 Apr 2022 20:22:48 +0200 In-Reply-To: (Yuen Ho Wong's message of "Thu, 04 Jan 2018 01:11:13 +0000") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:230099 Archived-At: Yuen Ho Wong writes: > How to reproduce: > 1. Turn on `desktop-save-mode` > 2. dired some directory > 3. Press `(` to turn on `dired-hide-details-mode` > 4. C-x C-c, when asked to save desktop, choose yes > 5. Launch emacs again, desktop restored the dired buffer but not > `dired-hide-details-mode` > > What went wrong: > `dired-hide-details-mode`'s definition does not declare a lighter or a > keymap, thus it is not added to `minor-mode-alist` by > `define-minor-mode`. So when `desktop` tries to get the buffer's info to > save to `.emacs.desktop` via `desktop-buffer-info`, > `dired-hide-details-mode` does not exist, and thus not saved to the > session file. > > Fix: > Just declare an empty lighter. I've attached a patch for this. I've fixed this in a differently way in Emacs 29 -- I'm using the local-minor-modes variable instead, which does not depend on lighters and keymaps. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no