unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Lars Ingebrigtsen <larsi@gnus.org>
To: Po Lu <luangruo@yahoo.com>
Cc: Colin Baxter <m43cap@yandex.com>,
	46990@debbugs.gnu.org, "Jan D." <jan.h.d@swipnet.se>
Subject: bug#46990: 28.0.50; popup menu not navigable via arrow keys on lucid build
Date: Mon, 20 Jun 2022 17:38:55 +0200	[thread overview]
Message-ID: <87wndb1h0w.fsf@gnus.org> (raw)
In-Reply-To: <87bkunmqrl.fsf@yahoo.com> (Po Lu's message of "Mon, 20 Jun 2022 21:02:54 +0800")

Po Lu <luangruo@yahoo.com> writes:

> Ah.  Then it's this:
>
> /* For debug, if installation-directory is non-nil this is not an installed
>    Emacs.   In that case we do not grab the keyboard to make it easier to
>    debug. */
> #define GRAB_KEYBOARD  (EQ (Vinstallation_directory, Qnil))
>
> and it's not a bug.

It's always nice when behaviour like this has a logical explanation.  😀

But I'm not sure whether we actually want this.  The commit message is
somewhat vague -- what's the debugging this simplifies?  Is it still
relevant?  I've added Jan to the CCs; perhaps he remembers the reasoning
for the 20 year old change:

diff --git a/lwlib/ChangeLog b/lwlib/ChangeLog
index 28626ddc25..3ead711d79 100644
--- a/lwlib/ChangeLog
+++ b/lwlib/ChangeLog
@@ -1,3 +1,8 @@
+2002-04-28  Jan D.  <jan.h.d@swipnet.se>
+
+	* xlwmenu.c: Do not grab keyboard if installation-directory is
+	non-nil (not installed Emacs).  To simplify debugging.
+


-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no





  reply	other threads:[~2022-06-20 15:38 UTC|newest]

Thread overview: 50+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-03-07 16:57 bug#46990: 28.0.50; popup menu not navigable via arrow keys on lucid build Colin Baxter
2021-03-08  8:26 ` martin rudalics
2021-03-08 10:05   ` Colin Baxter
2021-03-08 10:56 ` Basil L. Contovounesios
2021-03-08 14:29   ` Colin Baxter
2021-03-08 20:36     ` Glenn Morris
2021-03-10 18:59       ` Colin Baxter
2021-03-10 19:12         ` Eli Zaretskii
2021-03-10 18:41     ` Eli Zaretskii
2021-03-10 19:39       ` Colin Baxter
2021-03-10 20:03         ` Eli Zaretskii
2021-03-10 20:30           ` Colin Baxter
2021-03-10 20:49             ` Eli Zaretskii
2021-03-10 23:34           ` Gregory Heytings
2021-03-11  5:07             ` Eli Zaretskii
2021-03-11 12:56             ` Colin Baxter
2021-03-11 13:23               ` Colin Baxter
2021-03-11 14:02                 ` Eli Zaretskii
2021-03-11 14:25                   ` Gregory Heytings
2021-03-11 14:50                     ` Eli Zaretskii
2022-06-20  8:27               ` Lars Ingebrigtsen
2022-06-20  9:51                 ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-06-20  9:53                   ` Lars Ingebrigtsen
2022-06-20 10:05                     ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-06-20 10:08                       ` Lars Ingebrigtsen
2022-06-20 10:17                         ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-06-20 10:40                           ` Lars Ingebrigtsen
2022-06-20 13:10                             ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-06-20 15:39                               ` Lars Ingebrigtsen
2022-06-22  8:29                                 ` Colin Baxter
2022-06-20 10:08 ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-06-20 10:28   ` Lars Ingebrigtsen
2022-06-20 11:02     ` Colin Baxter
2022-06-20 11:07       ` Lars Ingebrigtsen
2022-06-20 12:14         ` Visuwesh
2022-06-20 12:29           ` Colin Baxter
2022-06-20 13:02       ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-06-20 13:16         ` Visuwesh
2022-06-20 13:22           ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-06-20 13:26             ` Visuwesh
2022-06-20 13:02       ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-06-20 15:38         ` Lars Ingebrigtsen [this message]
2022-06-20 15:54           ` Eli Zaretskii
2022-06-21 10:16             ` Lars Ingebrigtsen
2022-06-21 12:30               ` Manuel Giraud
2022-06-21 12:36                 ` Eli Zaretskii
2022-06-21 13:58                   ` Manuel Giraud
2022-06-21 12:36                 ` Lars Ingebrigtsen
2022-06-21  1:22           ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-06-20 13:01     ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87wndb1h0w.fsf@gnus.org \
    --to=larsi@gnus.org \
    --cc=46990@debbugs.gnu.org \
    --cc=jan.h.d@swipnet.se \
    --cc=luangruo@yahoo.com \
    --cc=m43cap@yandex.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).