From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Michael Heerdegen Newsgroups: gmane.emacs.bugs Subject: bug#56110: 27+; switching from line-mode to char-mode Date: Tue, 21 Jun 2022 13:47:27 +0200 Message-ID: <87wndaw84w.fsf@web.de> References: <875ykvs9gq.fsf@electra.home.arpa> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="27556"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) Cc: 56110@debbugs.gnu.org, Stefan Monnier To: "C. Michailidis" Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue Jun 21 13:49:11 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1o3cNb-0006wd-G3 for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 21 Jun 2022 13:49:11 +0200 Original-Received: from localhost ([::1]:53702 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1o3cNa-0003rz-08 for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 21 Jun 2022 07:49:10 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:39858) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1o3cMj-0002dB-Kb for bug-gnu-emacs@gnu.org; Tue, 21 Jun 2022 07:48:22 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:37207) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1o3cMU-0002U4-27 for bug-gnu-emacs@gnu.org; Tue, 21 Jun 2022 07:48:15 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1o3cMT-0002HG-Vx for bug-gnu-emacs@gnu.org; Tue, 21 Jun 2022 07:48:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Michael Heerdegen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 21 Jun 2022 11:48:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 56110 X-GNU-PR-Package: emacs Original-Received: via spool by 56110-submit@debbugs.gnu.org id=B56110.16558120618629 (code B ref 56110); Tue, 21 Jun 2022 11:48:01 +0000 Original-Received: (at 56110) by debbugs.gnu.org; 21 Jun 2022 11:47:41 +0000 Original-Received: from localhost ([127.0.0.1]:59337 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1o3cM9-0002F6-2a for submit@debbugs.gnu.org; Tue, 21 Jun 2022 07:47:41 -0400 Original-Received: from mout.web.de ([212.227.17.11]:43271) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1o3cM6-0002AW-UI for 56110@debbugs.gnu.org; Tue, 21 Jun 2022 07:47:39 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=web.de; s=dbaedf251592; t=1655812049; bh=QKiRQGI+TOJ8iT8VwsNd9W6o9SzTLET+9SzKQjRyhjw=; h=X-UI-Sender-Class:From:To:Cc:Subject:References:Date:In-Reply-To; b=gkfQPJ0B+n3mOEvRzJyUbPD7x8hoakn3/t/r/WuTAy1qEnErhQ/Tx9tT0SWq5DWZU czeDMY0UDUlEJ+4rXTNkEm6ssv4XjaCRC90Ybsiz9bA1fEZ0uyJuEmkB4+v5DZUHnX Ya6JfOCi2/9PAci77skqDpnYERc9AomTvsYW5Mq4= X-UI-Sender-Class: c548c8c5-30a9-4db5-a2e7-cb6cb037b8f9 Original-Received: from drachen.dragon ([84.60.174.246]) by smtp.web.de (mrweb105 [213.165.67.124]) with ESMTPSA (Nemesis) id 1MLRYf-1oLYZu1WS3-00IKAx; Tue, 21 Jun 2022 13:47:29 +0200 In-Reply-To: <875ykvs9gq.fsf@electra.home.arpa> (C. Michailidis's message of "Mon, 20 Jun 2022 10:20:05 -0400") X-Provags-ID: V03:K1:p8HlqS6SSUPZlrjR6qoiGW97GH79GFuGQjyucEQH/t6fl9xu026 K/u6dnwLhF13DT+s6UUetrFk+nq59Z05TY41SlN1nBAVfsaWSE1g3xdh11dwIVkIzYsXVdy SmaMg/XY1SrmT0bJZKQ8AjEaacgoYPimKaeiGRaBQSUeY+VTtPb5td+M2/ixOXz7WfP2eqy uKdYm+5F1ZrAlBb7prZOg== X-UI-Out-Filterresults: notjunk:1;V03:K0:oLYNASD7x94=:H5jILnO5gE7jnSQkzq1qZH 8oBFAMkhHA+L8nzFJ1KdDAAJzzTdMgWRWST/0Z3hWmBKDxWOkuqJlgiIwSTgeV3Ww5rAkcRnP aQel7ndXMdm2p2V+zJEbVGsX1ygYC1qeoQAMPK1ZZcF1McFZQFNaWG1s9taZbu878h74w0Al5 8Ef8brc4yMWs/U+q7CeQj9cZyt0l52gs3aRDherfFT18U/m1+dAVLD9so1QHYL0pABjcuu5Oq K3EmFVHiWE8WUieeoDLA9KPIVSm3lGsiCEGNQCIVW0y2Yh61GYXTIMODivR4gruA1xCXYgdns SHqtFo0O0JxusdBTvoYN8kGEK7jxnKEoyrgmvHK54Jf7rl6rFoAfcw6CZCGAkBnQ7CHZKMfcY 7Boenh/GjH41RyS8ZtEaN/GcfIZtrfEfmI2JOg2GmDIC69t2hUIG5mgE7l8wQJOQioJz+ZAE1 jt+0Yg6xFDngAebU0GihNOPXYvRgsIUyMlAFUWWdy/UZSEZJ7szGCMJjMJjgNOV5dCrJfSIbm gSWFCtyP5kM7iYgw6uMYQq/NctrA06v10d2I4HW3Y8X2Sw5l6B+2Mgbdg0hv6A98TSuMS16Wy yS8mpz07U86vwOS5bPig+kJWNUCfoiBov4ZzeW/FRC+TZgDNd1cCjPJXf1cTNUjALD/epA2I2 /Uv4tG3fhiSY35fcihYD1DE46b/tLpZmn+CHwy5t0PNZKNRN+1YqHi/S0/l5ts4vYJgT6twvZ KQ7ZVsZivTPUcaO7tuQjefzRxbmTsU8mLZ/E4TtQDNfCVMLxPQQbleCaTmRK8Crrn8EEdgc4 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:234949 Archived-At: --=-=-= Content-Type: text/plain "C. Michailidis" writes: > I recently updated a few machines and noticed that term.el in Emacs > version 27+ forcibly submits my pasted commands to the shell sub-process > when switching to char-mode (from line-mode). In prior versions of Emacs > term.el didn't do this; I could further modify the command in char-mode > even if it was pasted from line-mode and submit it myself by pressing > enter. Thanks for the report. This issue is a side effect of this change: 5653b76d0b * lisp/term.el: Fix minor compilation issues with cl-lib and lexbind Stefan Monnier 2019-02-24 When I revert the part that changes `term-char-mode': --=-=-= Content-Type: text/x-diff Content-Disposition: inline; filename=0001-WIP-Fix-56110.patch Content-Transfer-Encoding: quoted-printable =46rom 3ebb78f622453623a406d4413cbee421ae57ad84 Mon Sep 17 00:00:00 2001 From: Michael Heerdegen Date: Tue, 21 Jun 2022 13:41:51 +0200 Subject: [PATCH] WIP: Fix 56110 =2D-- lisp/term.el | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/lisp/term.el b/lisp/term.el index 94bf13e973..eec78707e7 100644 =2D-- a/lisp/term.el +++ b/lisp/term.el @@ -1463,14 +1463,16 @@ term-char-mode (add-hook 'post-command-hook #'term-goto-process-mark-maybe nil t) ;; Send existing partial line to inferior (without newline). - (let ((pmark (process-mark (get-buffer-process (current-buffer))))) + (let ((pmark (process-mark (get-buffer-process (current-buffer)))) + (save-input-sender term-input-sender)) (when (> (point) pmark) (unwind-protect (progn - (add-function :override term-input-sender #'term-send-string) + (setq term-input-sender + (symbol-function 'term-send-string)) (end-of-line) (term-send-input)) - (remove-function term-input-sender #'term-send-string)))) + (setq term-input-sender save-input-sender)))) (term-update-mode-line))) (defun term-line-mode () =2D- 2.30.2 --=-=-= Content-Type: text/plain the original behavior is restored. Stefan, how would a fix look like that fits your intention? TIA, Michael. --=-=-=--