From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Dima Kogan Newsgroups: gmane.emacs.bugs Subject: bug#56635: 29.0.50; [PATCH] hide-show in python-mode supports ONLY function and class blocks Date: Sun, 31 Jul 2022 12:04:48 -0700 Message-ID: <87wnbt3vnq.fsf@secretsauce.net> References: <87v8ruysep.fsf@secretsauce.net> <87zgh01cqm.fsf@gnus.org> <87sfmr5zi9.fsf@secretsauce.net> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="16774"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: mu4e 1.8.6; emacs 29.0.50 Cc: Lars Ingebrigtsen , 56635@debbugs.gnu.org To: kobarity Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Jul 31 21:55:26 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oIF21-00046X-TT for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 31 Jul 2022 21:55:24 +0200 Original-Received: from localhost ([::1]:60478 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oIF20-0001Xj-Ag for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 31 Jul 2022 15:55:20 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:35740) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oIF1j-0001XW-VZ for bug-gnu-emacs@gnu.org; Sun, 31 Jul 2022 15:55:05 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:48895) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oIF1h-0002dP-TH for bug-gnu-emacs@gnu.org; Sun, 31 Jul 2022 15:55:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1oIF1h-0003aJ-Mx for bug-gnu-emacs@gnu.org; Sun, 31 Jul 2022 15:55:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Dima Kogan Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 31 Jul 2022 19:55:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 56635 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 56635-submit@debbugs.gnu.org id=B56635.165929728813752 (code B ref 56635); Sun, 31 Jul 2022 19:55:01 +0000 Original-Received: (at 56635) by debbugs.gnu.org; 31 Jul 2022 19:54:48 +0000 Original-Received: from localhost ([127.0.0.1]:38644 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oIF1T-0003Zk-St for submit@debbugs.gnu.org; Sun, 31 Jul 2022 15:54:48 -0400 Original-Received: from out3-smtp.messagingengine.com ([66.111.4.27]:52665) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oIF1R-0003ZT-GO for 56635@debbugs.gnu.org; Sun, 31 Jul 2022 15:54:46 -0400 Original-Received: from compute2.internal (compute2.nyi.internal [10.202.2.46]) by mailout.nyi.internal (Postfix) with ESMTP id 5488F5C00B4; Sun, 31 Jul 2022 15:54:39 -0400 (EDT) Original-Received: from mailfrontend2 ([10.202.2.163]) by compute2.internal (MEProxy); Sun, 31 Jul 2022 15:54:39 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=secretsauce.net; h=cc:cc:content-type:date:date:from:from:in-reply-to :in-reply-to:message-id:mime-version:references:reply-to:sender :subject:subject:to:to; s=fm2; t=1659297279; x=1659383679; bh=fs epG65gmEqEKFOCL1SUSSvpZdT5Yyg1yVuqg0XeXn0=; b=fJ2HUL75kBA+pzmlKx fsw/HLWolzi+XkylO+Ol/1SV4huXvMjBbH87p1SbVL7X8mhOEndzmGiTm34gKI3Q 6wCP5qcD4xFe7RZJztUx+FV09O6piAE2UfnRC+wgWcxY5R6HanUqES8crmLkWEFM 04hl5lCuku1kOSvrZsr1jxSw6A1b1qFHp2KXrUp159lWHOiKzMVNEOgsox4hpjTG jWE97dk29DBZEAX/rKgqOVtTonVrGDeMtHzQYZD74bVNkxlHYUkHbIXk0oSNKwG/ Sti/TpxRo8Qp1JOJVYc8J2Lg8MChxsFd1QduonR2DydD1S0/SfmSReaEO4oLjVOF wYHQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:date:date:feedback-id :feedback-id:from:from:in-reply-to:in-reply-to:message-id :mime-version:references:reply-to:sender:subject:subject:to:to :x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm3; t=1659297279; x=1659383679; bh=fsepG65gmEqEKFOCL1SUSSvpZdT5 Yyg1yVuqg0XeXn0=; b=EoKtWYlSkz8LPiZ9Dnj3VSflIkQy40nKrrpskUEdLu8S ZdcGBtqkO9S8usX4OBN08IRATduEwp9I/QCvi5nyMMdDwMJeKaj/sMX8priSMTed BJxWqpfrwsRMLL3WbU5PjyivFo5NhVPvXDrQD0mmq5d8QvfUj+BzrRjfjxszakQ2 PjcrvxZBGToq2Kizoinlyz543j/deNEMnkBtrNNGLWo1yN4/WEuuMLvBRPpUk9Tn hyRyxBzXiAxcAGJizYFfdhnozUQjmIx5OrtTs65tg6eDXpX6DxGto3qQpkAvCAUJ n4+v5s5q/IJQ7bZ6h1Q9+Z4fg7fZYkI/DhKW3ymeNg== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvfedrvddvuddgudegjecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enucfjughrpehffgfhvfevufffjgfkgggtsehttdertddtredtnecuhfhrohhmpeffihhm rgcumfhoghgrnhcuoeguihhmrgesshgvtghrvghtshgruhgtvgdrnhgvtheqnecuggftrf grthhtvghrnhepgfeifeehgedvkeekvdevvdelvdegleevtedvueejvdejveduveeuleev leevudetnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomh epughimhgrsehsvggtrhgvthhsrghutggvrdhnvght X-ME-Proxy: Feedback-ID: i3e8042a0:Fastmail Original-Received: by mail.messagingengine.com (Postfix) with ESMTPA; Sun, 31 Jul 2022 15:54:38 -0400 (EDT) In-reply-to: X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:238360 Archived-At: Hi. Thanks for looking at this. I do agree that the best thing to do is to use functions instead of pure regexes here. Can we hook that into hs-special-modes-alist instead of doing something specific in python-mode? I'm imagining extending the meaning of the fields in hs-special-modes-alist, where we'd do something different, depending on if some element is a string or not. Maybe that would make it easier to extend the hideshow support for other languages?