From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Visuwesh Newsgroups: gmane.emacs.bugs Subject: bug#57796: 29.0.50; textsec-link-suspicious-p is unaware of eww-url-transformers Date: Wed, 14 Sep 2022 19:18:51 +0530 Message-ID: <87wna6kqws.fsf@gmail.com> References: <87zgf21jz2.fsf@gmail.com> <87tu5a1iu0.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="40622"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) To: 57796@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Sep 14 16:40:23 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oYTYt-000AQl-3U for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 14 Sep 2022 16:40:23 +0200 Original-Received: from localhost ([::1]:45942 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oYTYr-0006sy-VN for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 14 Sep 2022 10:40:21 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:59946) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oYTYZ-0006oo-8P for bug-gnu-emacs@gnu.org; Wed, 14 Sep 2022 10:40:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:38800) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oYTYY-00066y-VU for bug-gnu-emacs@gnu.org; Wed, 14 Sep 2022 10:40:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1oYTYX-00043N-Qb for bug-gnu-emacs@gnu.org; Wed, 14 Sep 2022 10:40:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Visuwesh Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 14 Sep 2022 14:40:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 57796 X-GNU-PR-Package: emacs Original-Received: via spool by 57796-submit@debbugs.gnu.org id=B57796.166316636715528 (code B ref 57796); Wed, 14 Sep 2022 14:40:01 +0000 Original-Received: (at 57796) by debbugs.gnu.org; 14 Sep 2022 14:39:27 +0000 Original-Received: from localhost ([127.0.0.1]:55732 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oYTXy-00042O-Q5 for submit@debbugs.gnu.org; Wed, 14 Sep 2022 10:39:27 -0400 Original-Received: from mail-pj1-f68.google.com ([209.85.216.68]:51790) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oYTXw-00042B-E3 for 57796@debbugs.gnu.org; Wed, 14 Sep 2022 10:39:25 -0400 Original-Received: by mail-pj1-f68.google.com with SMTP id ge9so3271556pjb.1 for <57796@debbugs.gnu.org>; Wed, 14 Sep 2022 07:39:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:user-agent:references :message-id:date:in-reply-to:subject:to:from:from:to:cc:subject:date; bh=gwT4vbNnwAkbak2DThTYjXpoJZTHTmvNfelYV4Lo2FA=; b=Z6j/xM2rY8pTOwuAGznjIzI9hpmMJgm7IKKoG/okDBfRN00exvdzNqBJvLFNknl2Wn mPMQDzB6DZUi6GIDaPMMjVLtOJ4rn2pW6cwo14BjOgK3LOmvPxQkEjjMJF2iz76f+v7w u3dwvej1toL6coJRB1YcHP1+Aj2D60q++td7LVQiCucn0yOvx2PwZtRDfeYOd70Dxl7M 8qamFZA17USM1J6076XrAvLtj//wRKJFUb/qnpeLdQVd2ByNXlugr7n9rYeR7fkzgp6g S8sEX16BmWikkmwN87rUbNQvMuvZMuyT98d91i/sezRnp1JKYYw8UAxHkCLc6PCtcKTg oZdg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:user-agent:references :message-id:date:in-reply-to:subject:to:from:x-gm-message-state:from :to:cc:subject:date; bh=gwT4vbNnwAkbak2DThTYjXpoJZTHTmvNfelYV4Lo2FA=; b=h0T85eiVmjvMN8e6o+WrSOI0WsASpPq1+Q7vmIj3ZWjuo7qFHPDbF4X+9T54WgBEqQ FGm/K72UPrrCZKXWg2mptc902rzfe2mapaGL+0lqhdI2UXBBStY/4o57U1T1vdela7Pl hPdnLCaryXathd2iZMYn7Av0Y7llNg4TFZee/56WY4b4IwRI7bFY1aqsNVnA7//Sut0d a52iNGatya1+TqK7kDvURPlUc6T86kLiRNXEAlyj5WXiWeljv3vJyfuNLfVrOylqWtm7 xpQkR8gRnFvjM3WCladqjNmTz5qNl7YdE1CKK9STDe2Z2w78U8xWh64VyP568xWeCqlE vmZw== X-Gm-Message-State: ACrzQf2htKnJxP78FsVRU7gxsSwbrheBTNJ3nnfmXDqXT27cXoovJrx7 slUVoaNnKpMQtby3qLUCGPeiwV3xYNI= X-Google-Smtp-Source: AMsMyM72HR+kShEozZ4I5ZWYAD0OW2U0saALVaK0pBz1JJgb+gimES1E8b2Y/qa1BeHJD99oSzZixA== X-Received: by 2002:a17:90a:c782:b0:202:c73e:5488 with SMTP id gn2-20020a17090ac78200b00202c73e5488mr5138986pjb.202.1663166357796; Wed, 14 Sep 2022 07:39:17 -0700 (PDT) Original-Received: from localhost ([118.185.152.162]) by smtp.gmail.com with ESMTPSA id y6-20020a655a06000000b0043942f73570sm3672389pgs.74.2022.09.14.07.39.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 14 Sep 2022 07:39:17 -0700 (PDT) In-Reply-To: <87tu5a1iu0.fsf@gmail.com> (Visuwesh's message of "Wed, 14 Sep 2022 13:35:59 +0530") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:242472 Archived-At: [=E0=AE=AA=E0=AF=81=E0=AE=A4=E0=AE=A9=E0=AF=8D =E0=AE=9A=E0=AF=86=E0=AE=AA= =E0=AF=8D=E0=AE=9F=E0=AE=AE=E0=AF=8D=E0=AE=AA=E0=AE=B0=E0=AF=8D 14, 2022] V= isuwesh wrote: > Upon digging this issue further, I see the problem is with shr-tag-a, > not textsec-link-suspicious-p. Sorry for the misleading bug title---I'm > not sure what the right way to rename the title is. Looks like eww uses a custom tag function for . I tried the following patch but I cannot figure out how to turn `href' into a full URL. diff --git a/lisp/net/eww.el b/lisp/net/eww.el index 6ed0719eca..de4a06dc47 100644 --- a/lisp/net/eww.el +++ b/lisp/net/eww.el @@ -781,9 +781,13 @@ eww-tag-link =20 (defun eww-tag-a (dom) (eww-handle-link dom) - (let ((start (point))) + (let ((start (point)) + (href (dom-attr dom 'href))) + (when href + (setq href (eww--transform-url (shr-expand-url href))) + (dom-set-attribute dom 'href href)) (shr-tag-a dom) - (if (dom-attr dom 'href) + (if href (put-text-property start (point) 'keymap (if (mm-images-in-region-p start (point))