From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Robert Pluim Newsgroups: gmane.emacs.bugs Subject: bug#51384: 28.0.60; substitute-command-keys finds global binding for undo instead of in specified keymap Date: Thu, 15 Sep 2022 11:04:28 +0200 Message-ID: <87wna5j9er.fsf@gmail.com> References: <877de1s9yl.fsf@gmail.com> <87o87d9zpv.fsf@igel.home> <87y26hqtgt.fsf@gmail.com> <8635nxcow3.fsf@mail.linkov.net> <87czn1nwdr.fsf@gmail.com> <871qsd4xnj.fsf@gnus.org> <877d25krwg.fsf@gmail.com> <871qsdkoeb.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="1044"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Lars Ingebrigtsen , 51384@debbugs.gnu.org, Juri Linkov To: Andreas Schwab Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Sep 15 11:56:29 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oYlbg-000Adf-BQ for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 15 Sep 2022 11:56:28 +0200 Original-Received: from localhost ([::1]:50854 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oYlbe-0002A6-Gy for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 15 Sep 2022 05:56:26 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:35150) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oYknu-0003zY-SL for bug-gnu-emacs@gnu.org; Thu, 15 Sep 2022 05:05:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:40153) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oYknu-0000sn-IF for bug-gnu-emacs@gnu.org; Thu, 15 Sep 2022 05:05:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1oYknu-0004Xd-Dh for bug-gnu-emacs@gnu.org; Thu, 15 Sep 2022 05:05:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Robert Pluim Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 15 Sep 2022 09:05:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 51384 X-GNU-PR-Package: emacs Original-Received: via spool by 51384-submit@debbugs.gnu.org id=B51384.166323267817415 (code B ref 51384); Thu, 15 Sep 2022 09:05:02 +0000 Original-Received: (at 51384) by debbugs.gnu.org; 15 Sep 2022 09:04:38 +0000 Original-Received: from localhost ([127.0.0.1]:57083 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oYknV-0004Wp-Uy for submit@debbugs.gnu.org; Thu, 15 Sep 2022 05:04:38 -0400 Original-Received: from mail-wm1-f49.google.com ([209.85.128.49]:51115) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oYknU-0004Wb-89 for 51384@debbugs.gnu.org; Thu, 15 Sep 2022 05:04:37 -0400 Original-Received: by mail-wm1-f49.google.com with SMTP id ay36so3845847wmb.0 for <51384@debbugs.gnu.org>; Thu, 15 Sep 2022 02:04:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:references :in-reply-to:subject:cc:to:from:from:to:cc:subject:date; bh=5BaDXAKZ275KpAuaNMZ38y/fKKX6g7a49ka/kBChGRw=; b=Z8UtCQ0ra/mL8Y0IUMJd9lefFEZlEvUFUxnSXPYLI4Lctje0txdH7jLUg9CJ7lHjQK kcoK0bIeJZu+itaVcNX8W7zzoSGaFyTvNVOG8CzOjKXSQVzImPZl++bRvrqA7GCAMeDq 01kKbhHyfVQSDZ4eW3Ktyu/LuFZBBHCzSfi60uhcgx616QGLtC9ObV6bmOXeI6TfjwBy AQTVmR77el9eOF7LIqdUdJYyUs1wiopu7MGOVfp15hP8UEYeYkVQFZyZrpiNRMtWVt/d 8ThhpZCIvav9/h39enxusZgv6WTbjiuOaDBRUebvgiJuZFdTL4+6YemTWHalFVE0dTlq P63g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:references :in-reply-to:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date; bh=5BaDXAKZ275KpAuaNMZ38y/fKKX6g7a49ka/kBChGRw=; b=mfw+TPb+WvH8aPrtrAa6jmUksjUDMmgGlpFAMcnZ68O+1oaOJMMQ+2HMOcYQn91u7P 55FcyoQoB9PzxBrUSqbDgkGpsCZogVS49zGWdLGzSgjMgi8T5y6W0HdSliQdnzoNU/f4 lLFFaPTlYdbp//OUL7NQNp2pEmiw5xzuRC/5yvR9km2duxvGun4YfF96+nO2QkohYgov E0tDEiDWkz18EWHn9f4HZ2YybEYwpneSVdRvkUHIVXSKGz9TBr2lsmZ3Y1i70KJamQ3s aynWRDPJaXi0qjsj6OU+iruU28CNQISLBYEqfx47MnHdH3UTc/hHHo872ZsLzt3gQo57 BUvg== X-Gm-Message-State: ACgBeo3jPdelqYjvaBJ7/cl7n+mpqzkfH4zn2mN51IlkaqMO5q6pvZam GSc+2Ag3IpO4m6VijZykPb+5o5ENkd8= X-Google-Smtp-Source: AA6agR6pqBVFSUN0cMWygjbOIqUxw3WqZ/c69P+TjVSN4NfhrFsb6U1KQZ1ghPf1NLRC3/FbwMdGng== X-Received: by 2002:a05:600c:ace:b0:3b4:621f:93f4 with SMTP id c14-20020a05600c0ace00b003b4621f93f4mr5794137wmr.8.1663232669808; Thu, 15 Sep 2022 02:04:29 -0700 (PDT) Original-Received: from rltb ([2a01:e0a:3f3:fb50:16a0:9848:d23c:7dcb]) by smtp.gmail.com with ESMTPSA id e28-20020adf9bdc000000b00228c375d81bsm1963087wrc.2.2022.09.15.02.04.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 15 Sep 2022 02:04:29 -0700 (PDT) In-Reply-To: (Andreas Schwab's message of "Thu, 15 Sep 2022 11:00:09 +0200") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:242577 Archived-At: >>>>> On Thu, 15 Sep 2022 11:00:09 +0200, Andreas Schwab said: Andreas> On Sep 15 2022, Robert Pluim wrote: >>>>>>> On Thu, 15 Sep 2022 09:39:43 +0200, Robert Pluim said: >>=20 Robert> The patch has shrunk in the meantime, somebody simplified the c= ode ;-) >>=20 >> Although, apart from the patch missing a paren, it doesn=CA=BCt work, >> because I=CA=BCve forgotten how Lisp lists work :-) >>=20 >> diff --git a/lisp/help.el b/lisp/help.el >> index 15ab3192ad..90476e4a4f 100644 >> --- a/lisp/help.el >> +++ b/lisp/help.el >> @@ -1204,7 +1204,11 @@ substitute-command-keys >> (delete-char 2) >> (let* ((fun (intern (buffer-substring (point) (1- end-point)))) >> (key (with-current-buffer orig-buf >> - (where-is-internal fun keymap t)))) >> + (where-is-internal fun >> + (if keymap >> + (list keymap) >> + keymap) Andreas> aka (and keymap (list keymap)) Indeed. Either too much C or not enough coffee this morning. Robert --=20