From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Protesilaos Stavrou Newsgroups: gmane.emacs.bugs Subject: bug#57639: [PATCH] Add new command 'toggle-theme' Date: Wed, 21 Sep 2022 16:05:54 +0300 Message-ID: <87wn9wq3m5.fsf@protesilaos.com> References: <875yhzmz25.fsf@posteo.net> <877d269kgv.fsf@gnus.org> <87bkriyqci.fsf@posteo.net> <874jxa6kyj.fsf@gnus.org> <87o7vdg97w.fsf@posteo.net> <831qs926np.fsf@gnu.org> <871qs9fzz5.fsf@posteo.net> <83h715yxz2.fsf@gnu.org> <87h715dnut.fsf@posteo.net> <87edw955ls.fsf@gnus.org> <8735coewsk.fsf@posteo.net> <871qs7ztgq.fsf@gnus.org> <87o7vbg56k.fsf@posteo.net> <874jx3ye41.fsf@gnus.org> <87bkrbfz8l.fsf@posteo.net> <871qs5lpo2.fsf@posteo.net> <87mtatagzv.fsf@gnus.org> <87edw5n2zm.fsf@posteo.net> <87o7v97zy2.fsf@gnus.org> <87bkr9newj.fsf@posteo.net> <871qs57yai.fsf@gnus.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="16903"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Notmuch/0.37 (https://notmuchmail.org) Emacs/29.0.50 (x86_64-pc-linux-gnu) Cc: Eli Zaretskii , 57639@debbugs.gnu.org To: Lars Ingebrigtsen , Philip Kaludercic Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Sep 21 15:41:07 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oazyN-0004GT-Fv for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 21 Sep 2022 15:41:07 +0200 Original-Received: from localhost ([::1]:39052 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oazyM-0008Bn-3x for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 21 Sep 2022 09:41:06 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:48006) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oazRO-00067M-Bk for bug-gnu-emacs@gnu.org; Wed, 21 Sep 2022 09:07:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:33841) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oazRO-0001Lc-3V for bug-gnu-emacs@gnu.org; Wed, 21 Sep 2022 09:07:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1oazRN-00078s-S2 for bug-gnu-emacs@gnu.org; Wed, 21 Sep 2022 09:07:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Protesilaos Stavrou Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 21 Sep 2022 13:07:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 57639 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 57639-submit@debbugs.gnu.org id=B57639.166376556927397 (code B ref 57639); Wed, 21 Sep 2022 13:07:01 +0000 Original-Received: (at 57639) by debbugs.gnu.org; 21 Sep 2022 13:06:09 +0000 Original-Received: from localhost ([127.0.0.1]:32919 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oazQW-00077o-Uk for submit@debbugs.gnu.org; Wed, 21 Sep 2022 09:06:09 -0400 Original-Received: from relay10.mail.gandi.net ([217.70.178.230]:41425) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oazQT-00077B-5I for 57639@debbugs.gnu.org; Wed, 21 Sep 2022 09:06:07 -0400 Original-Received: (Authenticated sender: public@protesilaos.com) by mail.gandi.net (Postfix) with ESMTPSA id 2F5FA240010; Wed, 21 Sep 2022 13:05:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=protesilaos.com; s=gm1; t=1663765559; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=vY8qzAbT41J3hGdH347pb8EDOtEdfbT0D9pql658olI=; b=E7cjFFtZ7FLYa9cnv3raJ+vgZJqUCt2gk0TgmLpvRxDjjlnJpVY/3WzafLMtdVkfYhkzwf b9zQC3uLHefxEgT8aFpGesTx+6TuBjiPQVsB1YLa+OVw7Zq1D05pA6AfIhAk1BWD9rej5m SydWYb+UhCPJ2XYrDDy/xt20AyL0OkHbKym09Vo8gmgTT7thf9XJNCh2dkLR+UmPZW2E7C 5sU3wgP7qujbVYpsCWwmlmeEaSngIpDKh5lcT4uK5jPeYQR/Ni6Vf0GqcwUDckgy7NYakc JgI7wnxGajI5t5O4dUO9ST1aAxyL/OCaB+VbH+2K1qAq8yH+KWyWqQGIxaCe3g== In-Reply-To: <871qs57yai.fsf@gnus.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:243342 Archived-At: > From: Lars Ingebrigtsen > Date: Wed, 21 Sep 2022 13:38:13 +0200 > > Philip Kaludercic writes: > >> Ok, that sounds good. Here is the updated patch: > > [...] > >> This is actually done a few times by the modus themes and at least once >> by `leuven-dark' (see `leuven-dark-scale-font', tough I don't see why, >> and if the autoloads aren't being generated to begin with the cookie is >> pointless anyway). >> >> Should this be addressed before the patch is pushed? > > Hm... are these themes also distributed via ELPA or something? But in > any case, I don't see why you'd have: > > ;;;###autoload > (defun leuven-dark-scale-font (control default-height) > > If you've activated the theme, you've loaded the file, so autoloading a > function like that doesn't seem helpful in any case. > > So I think that sounds like it's just a mistake, and the ;;;###autoload > should be removed. And the same with the commands autoloaded in modus > themes? But perhaps there's a reason; I've added Prot to the CCs. > Perhaps he can clarify why those autoloads are in modus*.el. Those autoloads are for the version of the themes distributed via GNU ELPA. I am happy to make adaptations though. -- Protesilaos Stavrou https://protesilaos.com