From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Visuwesh Newsgroups: gmane.emacs.bugs Subject: bug#58070: [PATCH] Add tamil99 input method Date: Tue, 27 Sep 2022 07:59:39 +0530 Message-ID: <87wn9psg6k.fsf@gmail.com> References: <20220925100020.13229-1-arunisaac@systemreboot.net> <20220925100244.13482-1-arunisaac@systemreboot.net> <87h70vsmyd.fsf@gmail.com> <87ill9ony7.fsf@systemreboot.net> <87ill98u3m.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="34702"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) Cc: 58070@debbugs.gnu.org To: Arun Isaac Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue Sep 27 04:30:12 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1od0MO-0008qR-F9 for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 27 Sep 2022 04:30:12 +0200 Original-Received: from localhost ([::1]:44522 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1od0MM-0006lv-TM for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 26 Sep 2022 22:30:10 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:57480) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1od0ME-0006lm-VK for bug-gnu-emacs@gnu.org; Mon, 26 Sep 2022 22:30:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:53010) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1od0ME-0003fi-My for bug-gnu-emacs@gnu.org; Mon, 26 Sep 2022 22:30:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1od0ME-000162-Dw for bug-gnu-emacs@gnu.org; Mon, 26 Sep 2022 22:30:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Visuwesh Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 27 Sep 2022 02:30:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 58070 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 58070-submit@debbugs.gnu.org id=B58070.16642457944180 (code B ref 58070); Tue, 27 Sep 2022 02:30:02 +0000 Original-Received: (at 58070) by debbugs.gnu.org; 27 Sep 2022 02:29:54 +0000 Original-Received: from localhost ([127.0.0.1]:52088 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1od0M5-00015L-Kq for submit@debbugs.gnu.org; Mon, 26 Sep 2022 22:29:53 -0400 Original-Received: from mail-pj1-f67.google.com ([209.85.216.67]:43917) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1od0M0-000151-9O for 58070@debbugs.gnu.org; Mon, 26 Sep 2022 22:29:52 -0400 Original-Received: by mail-pj1-f67.google.com with SMTP id g1-20020a17090a708100b00203c1c66ae3so8773719pjk.2 for <58070@debbugs.gnu.org>; Mon, 26 Sep 2022 19:29:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:user-agent:message-id:date :references:in-reply-to:subject:cc:to:from:from:to:cc:subject:date; bh=5eZe2rm4Yplnp+TUreAZBI3iu5IvMkHTzoQelavpAnc=; b=neWwwlDqaxxAr6QTUF0x6Ac4gFjtrF3+i3kzTEGxamtEodSDycAiJix762itSYSuaQ mSnubnOThvQhIkqUdnjwaBKA/7OEtJBNZL9NbbkhQ9HzcwVktR2KV0OUZC8xCr8OA9YX N0iuHX5/zXrKDrwq7fYaNU3gvNBVsSZfLpuPQbKS28Tc40sObNnWWkqQNNDnVJR95wJ7 nHyup0KpsPe25sSWILYtM6qaEAd4wdiscAM58jtf7MLZBg8NPFy4iCn3ppnc6IC+0trK OwcYVmJz1t3q3SwO23ICkjrtVFWBC5qXW7B9mC1S7eIuQAo241Bp0Bl8DXGHHXBAcoIW l7dA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:user-agent:message-id:date :references:in-reply-to:subject:cc:to:from:x-gm-message-state:from :to:cc:subject:date; bh=5eZe2rm4Yplnp+TUreAZBI3iu5IvMkHTzoQelavpAnc=; b=jRNPbW4uOnIw/nSZ7nWOToz19doKusbDT90cprUy6DjcNYyh7GmGOMbCFKQhRatHdl 4PCyM4zgw4qwUsCa9LSUQkcU1v1+RO+3s0r+vrXdYhRBSE+9Pd++BABB3onCf/nrXsrF f6EF6mdxORPvj5ukCWWZmJY0PGt7lb/1ChD9Ikub+gikQ7ZSyWOWO0ky7Ewgzl6Yn/km WmQmnpzuFGYokg3tHHsJcvmdDWN4O4IcrLXGKQdtlmv5OWlWV4TlsbEGUJrncTSlnsTL bqeNdkSfiV7n/u5fni18fOHc1yHExyJshGBVwhNN+5a6SdGaHZq8OySdpgV6g82wV7si s7bA== X-Gm-Message-State: ACrzQf2BPmEI2v1VvYyOgB3oqnLdxs10xfPH4uQDUXNCOQmwKJCot9Uj 2aFqwp+tl0MV8NeCvXDyuTQ= X-Google-Smtp-Source: AMsMyM7ZP4a1H9GW4cf1pi2wcbqabH4R/jYF2coVXPtKragKIf4OKVhZooon2AJL3HDrneVi0a/iYA== X-Received: by 2002:a17:90b:3c8a:b0:200:b874:804 with SMTP id pv10-20020a17090b3c8a00b00200b8740804mr1944909pjb.151.1664245782525; Mon, 26 Sep 2022 19:29:42 -0700 (PDT) Original-Received: from localhost ([118.185.152.162]) by smtp.gmail.com with ESMTPSA id s5-20020a170902ea0500b0017829a3df46sm131664plg.204.2022.09.26.19.29.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 26 Sep 2022 19:29:41 -0700 (PDT) In-Reply-To: <87ill98u3m.fsf@gmail.com> (Visuwesh's message of "Tue, 27 Sep 2022 07:19:17 +0530") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:243686 Archived-At: [=E0=AE=9A=E0=AF=86=E0=AE=B5=E0=AF=8D=E0=AE=B5=E0=AE=BE=E0=AE=AF=E0=AF=8D = =E0=AE=9A=E0=AF=86=E0=AE=AA=E0=AF=8D=E0=AE=9F=E0=AE=AE=E0=AF=8D=E0=AE=AA=E0= =AE=B0=E0=AF=8D 27, 2022] Visuwesh wrote: >> I tried out your implementation, and am having difficulty getting it >> working correctly. This is likely because I have an Ergodox keyboard >> with a non-standard keyboard layout. I have told quail about this >> keyboard layout by setting the quail-keyboard-layout variable. But, your >> implementation assumes a qwerty layout. It should instead call >> quail-keyboard-translate or quail-keyseq-translate to translate >> keystrokes. > > Hmm, this is weird. I thought Quail did the translation job for me > which is why I boldly assumed the qwerty layout and coded it that way. > I will try to change Xorg's keyboard layout and test it. Thanks for > testing! [ Looks like Quail does not hold your hand in the UPDATE-TRANSLATION-FUNCTION. Reading `quail-update-translation' again, I see the block about keysequence translation now. ] >> [...] merely instruct quail to do the necessary translation by >> passing a non-nil kbd-translate argument to quail-define-package. >=20=20 > Here, I'm confused. I pass a non-nil KBD-TRANSLATE argument as well... Thanks for the hint on quail-keyseq-translate, I fixed it with the following patch diff --git a/tamil99.el b/tamil99.el index 3461ccd..7262d30 100644 --- a/tamil99.el +++ b/tamil99.el @@ -105,7 +105,7 @@ consonant pair or hard-soft consonant pair was handled.= ") ;; pulli regardless of the character before point. (cond ((eq flag t) - (let ((key quail-current-key)) + (let ((key (quail-keyseq-translate quail-current-key))) (cond ((and (equal key "W") (and (eq (char-before (point)) ?=E0=AF=8D)