unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Stephen Berman <stephen.berman@gmx.net>
To: Eli Zaretskii <eliz@gnu.org>
Cc: 58283@debbugs.gnu.org, pankaj@codeisgreat.org
Subject: bug#58283: 29.0.50; calendar-goto-day-of-year => wrong-type-argument numberp
Date: Tue, 04 Oct 2022 12:07:54 +0200	[thread overview]
Message-ID: <87wn9fsxz9.fsf@rub.de> (raw)
In-Reply-To: <834jwjx641.fsf@gnu.org> (Eli Zaretskii's message of "Tue, 04 Oct 2022 12:58:38 +0300")

On Tue, 04 Oct 2022 12:58:38 +0300 Eli Zaretskii <eliz@gnu.org> wrote:

>> Cc: 58283@debbugs.gnu.org
>> From: Stephen Berman <stephen.berman@gmx.net>
>> Date: Tue, 04 Oct 2022 10:54:55 +0200
>>
>> On Tue, 04 Oct 2022 09:36:49 +0530 Pankaj Jangid <pankaj@codeisgreat.org> wrote:
>>
>> > Steps:
>> >
>> > 1. emacs -Q
>> > 2. M-x calendar RET g D RET RET
>> >
>> > =>
>> >
>> > Debugger entered--Lisp error: (wrong-type-argument numberp nil)
>> >   abs(nil)
>> >   #f(compiled-function (x) #<bytecode 0x1f4df5e08d503a2b>)(nil)
>> >   calendar-read-sexp("Day number (+/- 1-%d)" #f(compiled-function (x)
>> > #<bytecode 0x1f4df5e08d503a2b>) nil 365)
>> >   byte-code("\300\301\302\303
>> > \304\18\262\1#\211\211\305W\203\30\0\306\1!S\262\1\211\307\246\305U\205.\0\211\310\246\305U?\206.\0\211\311\246\305U\262\1\2037..."
>> > [calendar-read-sexp "Year (>0)" #f(compiled-function (x) #<bytecode
>> > -0x1433d194a6bf3cb2>) calendar-current-date 2 0 abs 4 100 400 366 365 "Day
>> > number (+/- 1-%d)" make-closure #f(compiled-function (x) #<bytecode
>> > 0x79fd4d90378a2b>) nil] 7)
>> >   call-interactively(calendar-goto-day-of-year nil nil)
>> >   command-execute(calendar-goto-day-of-year)
>>
>> The value of the `default' argument in the calendar-read-sexp call here
>> has to be a number instead of nil.
>> But what number?  1, 365, (random 365), ...?
>
> I decided that today's day number is a good default.

Seems reasonable (though displaying that default value in the prompt
("Day number (+/- 1-365) (default 277): ") may make innocent users of
the command wonder about it; though maybe that's not so bad...).

> Please see if the latest master solves this, and thanks.

Works for me.

Steve Berman





  reply	other threads:[~2022-10-04 10:07 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-10-04  4:06 bug#58283: 29.0.50; calendar-goto-day-of-year => wrong-type-argument numberp Pankaj Jangid
2022-10-04  8:54 ` Stephen Berman
2022-10-04  9:58   ` Eli Zaretskii
2022-10-04 10:07     ` Stephen Berman [this message]
2022-10-04 12:14       ` Eli Zaretskii
2022-10-05  4:16     ` Pankaj Jangid
2022-10-05  6:09       ` Eli Zaretskii

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87wn9fsxz9.fsf@rub.de \
    --to=stephen.berman@gmx.net \
    --cc=58283@debbugs.gnu.org \
    --cc=eliz@gnu.org \
    --cc=pankaj@codeisgreat.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).