From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Michael Albinus Newsgroups: gmane.emacs.bugs Subject: bug#58446: 28.2; file-attribute-device-number returns a cons cell instead of an integer Date: Fri, 14 Oct 2022 19:28:10 +0200 Message-ID: <87wn92xql1.fsf@gmx.de> References: <87lepmusw5.fsf@posteo.net> <87pmexcn1h.fsf@gnus.org> <87edvd5bun.fsf@gmx.de> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="35494"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) Cc: Thierry Volpiatto , Lars Ingebrigtsen , 58446@debbugs.gnu.org To: Stefan Monnier Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Oct 14 19:29:27 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1ojOUw-00092t-PZ for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 14 Oct 2022 19:29:26 +0200 Original-Received: from localhost ([::1]:59278 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ojOUv-00016E-9y for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 14 Oct 2022 13:29:25 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:55022) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ojOUa-000163-9x for bug-gnu-emacs@gnu.org; Fri, 14 Oct 2022 13:29:05 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:39441) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1ojOUY-0006l4-GF for bug-gnu-emacs@gnu.org; Fri, 14 Oct 2022 13:29:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1ojOUY-0001zg-Be for bug-gnu-emacs@gnu.org; Fri, 14 Oct 2022 13:29:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Michael Albinus Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 14 Oct 2022 17:29:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 58446 X-GNU-PR-Package: emacs Original-Received: via spool by 58446-submit@debbugs.gnu.org id=B58446.16657685047603 (code B ref 58446); Fri, 14 Oct 2022 17:29:02 +0000 Original-Received: (at 58446) by debbugs.gnu.org; 14 Oct 2022 17:28:24 +0000 Original-Received: from localhost ([127.0.0.1]:38519 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ojOTw-0001yY-62 for submit@debbugs.gnu.org; Fri, 14 Oct 2022 13:28:24 -0400 Original-Received: from mout.gmx.net ([212.227.17.21]:39065) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ojOTt-0001yL-Lo for 58446@debbugs.gnu.org; Fri, 14 Oct 2022 13:28:22 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1665768492; bh=nGgG3SI628v0Kb71HaxnL4CYrNcFysUyeE+BmFWAR28=; h=X-UI-Sender-Class:From:To:Cc:Subject:In-Reply-To:References:Date; b=X99JuV/sQp/F6uJQfUxoHBpPmd7rKao43ioQXi7VZvO5hMdx9HoX7tW9Ls3UEceBs tTnFv79NrlzPXYf3RecHhnYUQUpDo/Dp2+RKSiPQEmiy4WMLjvJ6U49GrO2VXScKgV 15pEkuYnqvqnEovWXN9kEWLoNgo7ny2kn2yqg0RQ= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Original-Received: from gandalf.gmx.de ([213.220.151.229]) by mail.gmx.net (mrgmx105 [212.227.17.168]) with ESMTPSA (Nemesis) id 1MsHru-1ozGhV41ak-00tmqm; Fri, 14 Oct 2022 19:28:12 +0200 In-Reply-To: (Stefan Monnier's message of "Fri, 14 Oct 2022 13:04:31 -0400") X-Provags-ID: V03:K1:EtvympWu/01WBcJAy9TaA8fjb+xYxCLuQLmQ56ruNQXlyl2qmmi RFNbFK4z+es/1d7IFw/0DJrp6BqjBZP6jLRTqA/RsLR3sh8zF1SDUpEvG9HJK8ZMfwVbevo MgdGMy1ETA0hCTYRM91xgnlE2V0CH5KVs3IlOD++/7sqoqxV6cTeJwxafN6nlttAH0MeFPs 8ppPLA/OtCsfSAxtBgcrw== X-UI-Out-Filterresults: notjunk:1;V03:K0:fhVXl5WPncA=:PlxL3daZrSW1Bgqaxq42wP HME6s3xcMfObOv7kkQjLFYF7boAF70Amf9ADZ/iRO+VeUZrCeU3zGlL6Yam/U1G3OJ492UKUj BvjYyMYF6SzAQkHAQcQ42ys6/obTiJv0TMDTIZcwP3QFatNUmUW2Z6bvzdHudJ29QrH11gzKP NH+e57Qi4HZ+mgKFX/akZl/YpnjGdt0MKUJ4FrN2BwQN6AIC93SfR/anW/Ccw3J93Aj2OhQ56 opyXWZhNpP+ZAnpwQjvQginGfGr/u6lxqExzjrhqcgsuIi5fTdB+AefuTgiYMUFIF0xcBpPHi hSXUAiF2nZDAFt75+KfVgnKRoehJTGbKbg7t+TAESU11tbWBYuvIXBZoJRA5XbsUmrzKJMHHr lGZKCGflEFvOl7LBFVUZItaXfiybpwWUSJB0kpJUI9SskGl8SD+IIniE2eaqcNzBrGTkadHJ4 fcjTtQCHPKaj6BIULXB0kB8EEncYVLJAYuS/h+s+3832x2TcfDwS5Z2LQhv+8moTv4ic8Kei0 d4kIRdF6AnrMcUXTn7QalMOZ9z5R++ujJY3QQVV/YDJUIJca5UrT4G/pGtijFxtTiWA8enmt9 wp6Ef1fvq8pjygUgNo77Ud0hFAUeSHBkNlmKrhdaB8wb7E/8tqiKjCgIlDuSECWU6OeNBbScR ENF3zirmFGZdI5xtvM1yYhhuN1AdLuHQE9X4m13bzcGXjsJC3KT41liqnH7rmSHdLTqNfchGQ lqCfEy+q7aN5eZcwNT7PU5hzpYIA4lyZjz9UEcdKA5vzqfGa+ZLonM1dAOyMtnuUf1f1GXCt X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:245468 Archived-At: Stefan Monnier writes: Hi Stefan, >> (defsubst file-attribute-file-number (attributes) >> "The inode and device numbers in ATTRIBUTES returned by `file-attributes'. >> It can be used to determine whether two files are identical." >> (nthcdr 10 attributes)) >> >> WDYT? > > Sounds good, except: > > - The name `file-attribute-file-number` doesn't sound right > because it doesn't return a number. The name is a reminiscence of the existing variable buffer-file-number, which serves exactly the same purpose. > - I wouldn't use `defsubst` (so it can more easily be modified in the > future, e.g. in case we add more fields to the attributes or use some > other representation for attributes). All other accessor functions for file-attributes are defsubsts. > - I would document it more abstractly, mentioning inode and device > number only as *examples* of things it might contain. There is no intention to use it for anything else. It shall return (nthcdr 10 attributes) like all the other file-attributes accessor functions return for the respective slots. > Stefan Best regards, Michael.