From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Augusto Stoffel Newsgroups: gmane.emacs.bugs Subject: bug#58447: [PATCH] In project-find-file, add absolute file name to history Date: Thu, 27 Oct 2022 16:26:05 +0200 Message-ID: <87wn8libr6.fsf@gmail.com> References: <8735budxiz.fsf@gmail.com> <83a662dvgo.fsf@gnu.org> <871qqvj6qb.fsf@gmail.com> <42bb91a0-60ff-2e51-dcdc-c1e1f80e31ec@yandex.ru> <837d0lmmpi.fsf@gnu.org> <1cce089a-546e-7f13-0907-3d36452aef10@yandex.ru> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="2208"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: Eli Zaretskii , 58447@debbugs.gnu.org To: Dmitry Gutov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Oct 27 16:28:38 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oo3s4-0000T1-MA for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 27 Oct 2022 16:28:36 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oo3qe-0006UV-82; Thu, 27 Oct 2022 10:27:08 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oo3qd-00069z-Bg for bug-gnu-emacs@gnu.org; Thu, 27 Oct 2022 10:27:07 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oo3qY-0001c5-2J for bug-gnu-emacs@gnu.org; Thu, 27 Oct 2022 10:27:05 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1oo3qX-0004sl-T4 for bug-gnu-emacs@gnu.org; Thu, 27 Oct 2022 10:27:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Augusto Stoffel Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 27 Oct 2022 14:27:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 58447 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 58447-submit@debbugs.gnu.org id=B58447.166688077518676 (code B ref 58447); Thu, 27 Oct 2022 14:27:01 +0000 Original-Received: (at 58447) by debbugs.gnu.org; 27 Oct 2022 14:26:15 +0000 Original-Received: from localhost ([127.0.0.1]:58861 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oo3pn-0004rA-8D for submit@debbugs.gnu.org; Thu, 27 Oct 2022 10:26:15 -0400 Original-Received: from mail-ed1-f49.google.com ([209.85.208.49]:41797) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oo3pl-0004qy-QK for 58447@debbugs.gnu.org; Thu, 27 Oct 2022 10:26:14 -0400 Original-Received: by mail-ed1-f49.google.com with SMTP id z97so3033367ede.8 for <58447@debbugs.gnu.org>; Thu, 27 Oct 2022 07:26:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=ewOFBbw5aIxmk/wpEWNnB4ylC97F2uq5zylTYNia1Tk=; b=V7IHoc1XBaVoQSjltAImqQ8kzJcZgTY5j4o/rghYMDEFvGEtoY6WQgTRmqCPbRRAUp V4tm8F9t5okqUuw3Yd1/6BQmKe7ObBa7MeK2KcOn3kvlY5jIuzW/VQNPiP5YqdakBUBt 8Ib1okMl1IgIOt79QX1BLnWgh1mEjN+xMkrbfdcrDHAldG4utl5tZOHLWm8pr7hhH5Kc XBuNedJigHfdGcxm9xDSmQ7S/l+EaqdjNDABhj3Y7MSWsUsW/aiQQsuv5pEx8EpURq3A mKCi4g9gKRgE2ESLLZwnFPmqBAZmIJWVgGSfzlC9IoaX/N6s89/0Y4/37kcA7b09fHbS 9w3Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=ewOFBbw5aIxmk/wpEWNnB4ylC97F2uq5zylTYNia1Tk=; b=PktVv3GzJNOQvMociicn9Y/VdBnmSMu63M2LVvF8a8XnyJXRJy1Xpx1kFR+HzmiRNm GdiughVZ53PRwF1OCDlw/iYlTd/fn8cG3PZR1joKo0krLP18ZwIx/MNh/10MIfLJq+JU JfiZAsVzdjXf+vGxhxoI4XCPXL6TvDAjQjwdKcyAVGFhW5YaEEtcPcE3cPyPGKTD4NC5 WbpuBJ3ddehanwaDV0msJISOewGuY6mN6kMEdV6GA25KOpE4uFPAqTrb5YxVrmXUF+Os gglDFzj78pYelc+GF9BQaEoSZlrnAwA/4nxY16qRLjrQCkaOHI6bYF6JCsICJ73cR5zT wJ8Q== X-Gm-Message-State: ACrzQf3ql0aVvaC+Txwk+aWyt3TXyniYJ+et8fDis9LpwGmd/EH+2oFU wTxJWP3IIfNhPjJKgtGcCq4acXWyH2o= X-Google-Smtp-Source: AMsMyM7kvAGW65H8UgegUC0wmTU5ICmUIy++AziGa+/PP/Y1l2Q4/506Vgztood+jfrOH58sdTd7zA== X-Received: by 2002:a05:6402:114a:b0:454:85e4:2295 with SMTP id g10-20020a056402114a00b0045485e42295mr47023240edw.348.1666880767509; Thu, 27 Oct 2022 07:26:07 -0700 (PDT) Original-Received: from ars3 ([2a02:8109:8ac0:56d0::89aa]) by smtp.gmail.com with ESMTPSA id bk5-20020a170906b0c500b0073022b796a7sm861242ejb.93.2022.10.27.07.26.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 27 Oct 2022 07:26:06 -0700 (PDT) In-Reply-To: <1cce089a-546e-7f13-0907-3d36452aef10@yandex.ru> (Dmitry Gutov's message of "Thu, 27 Oct 2022 17:21:24 +0300") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: "bug-gnu-emacs" Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:246307 Archived-At: On Thu, 27 Oct 2022 at 17:21, Dmitry Gutov wrote: > On 27.10.2022 16:15, Eli Zaretskii wrote: >>> Date: Thu, 27 Oct 2022 11:44:09 +0300 >>> Cc:58447@debbugs.gnu.org >>> From: Dmitry Gutov >>> >>> On 26.10.2022 12:04, Augusto Stoffel wrote: >>>> I'm copying Dmitry. >>> Hi! >>> >>>> On Tue, 11 Oct 2022 at 22:13, Eli Zaretskii wrote: >>>> >>>>>> From: Augusto Stoffel >>>>>> Date: Tue, 11 Oct 2022 20:29:24 +0200 >>>>>> >>>>>> `project-find-file' and related commands share their history with more >>>>>> general commands like `find-file', so they should add the absolute file >>>>>> name to history. Currently, file names relative to the project root are >>>>>> added. The attached patch fixes this. >>>>> Shouldn't project.el have its separate history of file names, >>>> I'm not sure that's useful, but then the history items should be >>>> absolute file names anyway. >>>> >>>>> perhaps even a project-specific history? >>>> This might make sense. >>> I like both of these ideas, except I'm not sure how to implement the >>> project-specific part better. >>> >>> I suppose we won't be passing the history var to completing-read anymore? >> I thought about a project-specific history variable. > > ...one global variable per project? One thing to consider here is compatibility with savehist-mode and the like. I guess the only simple way to achieve this is with one global variable per project. And then there would be the issue of when to garbage-collect the saved save pertaining to old projects.