From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Sean Whitton Newsgroups: gmane.emacs.bugs Subject: bug#58383: 29.0.50; Make it easier to invert vc-prepare-patches-separately Date: Fri, 11 Nov 2022 13:53:53 -0700 Message-ID: <87wn81us9q.fsf@melete.silentflame.com> References: <87mta6b3yu.fsf@melete.silentflame.com> <87edvh2m3o.fsf@posteo.net> <87v8nq4b62.fsf@melete.silentflame.com> <87cz9xgpd9.fsf@posteo.net> <87sfityxe8.fsf@melete.silentflame.com> <87sfisedkk.fsf@posteo.net> <87educytij.fsf@melete.silentflame.com> <87iljo9g1h.fsf@posteo.net> <875yfnzw14.fsf@melete.silentflame.com> <87v8nm5zzp.fsf@posteo.net> <87pmduwdzs.fsf@melete.silentflame.com> <87bkpexaqh.fsf@posteo.net> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="28710"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: 58383@debbugs.gnu.org To: Philip Kaludercic Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Nov 11 21:55:14 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1otb3O-00079p-Kc for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 11 Nov 2022 21:55:12 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1otb3J-0006T4-2J; Fri, 11 Nov 2022 15:55:05 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1otb3H-0006Sw-D6 for bug-gnu-emacs@gnu.org; Fri, 11 Nov 2022 15:55:03 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1otb3H-0004HA-05 for bug-gnu-emacs@gnu.org; Fri, 11 Nov 2022 15:55:03 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1otb3G-0001jn-Ip for bug-gnu-emacs@gnu.org; Fri, 11 Nov 2022 15:55:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Sean Whitton Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 11 Nov 2022 20:55:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 58383 X-GNU-PR-Package: emacs Original-Received: via spool by 58383-submit@debbugs.gnu.org id=B58383.16682000446613 (code B ref 58383); Fri, 11 Nov 2022 20:55:02 +0000 Original-Received: (at 58383) by debbugs.gnu.org; 11 Nov 2022 20:54:04 +0000 Original-Received: from localhost ([127.0.0.1]:46838 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1otb2K-0001ia-CX for submit@debbugs.gnu.org; Fri, 11 Nov 2022 15:54:04 -0500 Original-Received: from out5-smtp.messagingengine.com ([66.111.4.29]:39857) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1otb2H-0001i2-Ea for 58383@debbugs.gnu.org; Fri, 11 Nov 2022 15:54:02 -0500 Original-Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailout.nyi.internal (Postfix) with ESMTP id 5BC995C0075; Fri, 11 Nov 2022 15:53:55 -0500 (EST) Original-Received: from mailfrontend2 ([10.202.2.163]) by compute4.internal (MEProxy); Fri, 11 Nov 2022 15:53:55 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=spwhitton.name; h=cc:cc:content-type:date:date:from:from:in-reply-to :in-reply-to:message-id:mime-version:references:reply-to:sender :subject:subject:to:to; s=fm3; t=1668200035; x=1668286435; bh=Um zL3KpzKykfVqhO1EnA4V4N6JZXalGnWecuLu9YoSU=; b=zqCw+mRBmc83kkTTEj 7QaIane8NFN1z9svQ/zn1MA1z6uVebeb3TkDdimYrq/R1NbYMbkz0033tZ6iZ7dz RJayy2b36gPK/yMB9nPIaNsbXhX3ZbOsA3/LxzyO7BixohXBprPugqFBoYjV6Ptr jArr1RN5MWgvXg2CWJDRmoyzynKQhAEp4ROyEkwjaGFrXRqCEhroy2w+fW+aLzNC XhVtOcnA85OWOehktbYUPMrYbMbExBkGePEHRXGt51smRwDva8AqcoMoMef0NeyL C730Gt5uDQEhFTICEmEMxblfJ2EVMyQaSFEFYmwbUrDf6g3laIf0Yro4yOYuH3xY vngA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:date:date:feedback-id :feedback-id:from:from:in-reply-to:in-reply-to:message-id :mime-version:references:reply-to:sender:subject:subject:to:to :x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm1; t=1668200035; x=1668286435; bh=UmzL3KpzKykfVqhO1EnA4V4N6JZX alGnWecuLu9YoSU=; b=YtZj0Mqn6uDNrJ7yjluy7Q5FM1/UrFgI+roi0hOqhOCg OZDhyQHt27Oy1iLZ9MUaMpJWVnGgCK+uC6SYWE5J44ykYk4VEOh+sLTzgrfGo0fF dJ7i4nkCzaF9kPxW+FtxZk++rtphAw35RLimL6JKAlJ1hSkuFxlMlCKsQ4ppqDMm +AiKGcdZ2oEA2zQcLIoWwKotXoA9PImzwbE3hgMSgAB+wUx99ZDrQ/RHUohqOcYw xiyioYLaoYegcuZnTVVKAkPve2hRL6BqgPoPOa/pC6fQT2HaTrx5gbmtjEljqIi9 I3t3fkb20RPZaEK26cvWEXixo8lr10OtOCjM/u5aNg== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvgedrfeeigddugeefucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvvefujghffffkfgggtgesthdttddttdertdenucfhrhhomhepufgvrghn ucghhhhithhtohhnuceoshhpfihhihhtthhonhesshhpfihhihhtthhonhdrnhgrmhgvqe enucggtffrrghtthgvrhhnpedtffdvffeuleeuvdetkedvveehgfehvdegvefghfevudek geegleevgeejkeetkeenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrih hlfhhrohhmpehsphifhhhithhtohhnsehsphifhhhithhtohhnrdhnrghmvg X-ME-Proxy: Feedback-ID: i23c04076:Fastmail Original-Received: by mail.messagingengine.com (Postfix) with ESMTPA; Fri, 11 Nov 2022 15:53:54 -0500 (EST) Original-Received: by melete.silentflame.com (Postfix, from userid 1000) id 825A87E704D; Fri, 11 Nov 2022 13:53:53 -0700 (MST) In-Reply-To: <87bkpexaqh.fsf@posteo.net> (Philip Kaludercic's message of "Fri, 11 Nov 2022 06:32:06 +0000") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:247619 Archived-At: Hello, On Fri 11 Nov 2022 at 06:32AM GMT, Philip Kaludercic wrote: > Sean Whitton writes: > >>>> Typically you wouldn't want to format patches across a merge, so I would >>>> suggest raising an error. >>> >>> And this is something I don't think can be /expressed/ using vc, because >>> while I can collect a number of revisions using `previous-revision', >>> there is no general way to verify if a commit is a merge commit. >> >> Can we do that part on a VCS-by-VCS basis? Default to just calling >> previous-revision and hoping for the best, but giving vc-git.el a chance >> to raise an error. > > I guess that would be possible, though it will probably require a new > VC method :/ The new `prepare-patch' takes a revision, so it doesn't > make sense to pass it a number and have it return multiple patches. > > Perhaps it will be easier/cleaner to just accept that avoiding merge > revisions is the users responsibility. Sounds reasonable -- it can always be enhanced later in a way that's backwards-compatible. > But just to have mentioned it: Do you know that you can mark revisions > in log-view and then vc-prepare-patches will use these as the default > input when prompting for revisions? Yeah, but marking in those buffers is way more awkward than marking in, e.g., dired, and I usually know how many commits I want to send without looking at the log. -- Sean Whitton