From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Michael Heerdegen Newsgroups: gmane.emacs.bugs Subject: bug#59328: 29.0.50; `seq-keep' implementation only valid for lists Date: Thu, 17 Nov 2022 03:17:46 +0100 Message-ID: <87wn7ujpdh.fsf@web.de> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="31392"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Lars Ingebrigtsen , Jonas Bernoulli To: 59328@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Nov 17 03:19:20 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1ovUUq-000833-8C for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 17 Nov 2022 03:19:20 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ovUUb-000588-1j; Wed, 16 Nov 2022 21:19:05 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ovUUZ-00056a-5H for bug-gnu-emacs@gnu.org; Wed, 16 Nov 2022 21:19:03 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1ovUUY-00067a-RB for bug-gnu-emacs@gnu.org; Wed, 16 Nov 2022 21:19:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1ovUUY-0005k1-GJ for bug-gnu-emacs@gnu.org; Wed, 16 Nov 2022 21:19:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Michael Heerdegen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 17 Nov 2022 02:19:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 59328 X-GNU-PR-Package: emacs X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Original-Received: via spool by submit@debbugs.gnu.org id=B.166865148521997 (code B ref -1); Thu, 17 Nov 2022 02:19:02 +0000 Original-Received: (at submit) by debbugs.gnu.org; 17 Nov 2022 02:18:05 +0000 Original-Received: from localhost ([127.0.0.1]:58638 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ovUTc-0005ij-NX for submit@debbugs.gnu.org; Wed, 16 Nov 2022 21:18:04 -0500 Original-Received: from lists.gnu.org ([209.51.188.17]:44338) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ovUTb-0005ic-HK for submit@debbugs.gnu.org; Wed, 16 Nov 2022 21:18:03 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ovUTb-00053C-D7 for bug-gnu-emacs@gnu.org; Wed, 16 Nov 2022 21:18:03 -0500 Original-Received: from mout.web.de ([217.72.192.78]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ovUTZ-0005zY-BI for bug-gnu-emacs@gnu.org; Wed, 16 Nov 2022 21:18:03 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=web.de; s=s29768273; t=1668651467; bh=5fRdlI37yC5j8+WqtaemOrzo5lNjbKxoAxZyuULkLd0=; h=X-UI-Sender-Class:From:To:Cc:Subject:Date; b=Rm2M1ZJcUDXypfR36CEQ9V4C5umKiyKeAiy/DLmfffFrQi1xIlrA/khafrQaNdYfM 615sYJs6OFNA9Q1sRkk9lOXzKnzAWC/tDMwiwCDVjoR08gnF/HdZ3CnH705eykR2ID 9QJI1O4wXrRfmoAYEM32ZqSIJRcYQ1eEO2dBEBtgR1ctdarRWMWt+QPrVxqRFNVxeN TMix2Iqad5GjFhRBtpYwnFfqqNlog5PkauGfvOVM+12KlB72DZ+LY4c5d7KOCLmGT0 vDylG5Ei77PSSxKHzzA1fc2uorSbEh5Li5WL3Rd3drtePIsaklV44YBeKey2seiZi/ EeGyZm/kvXneg== X-UI-Sender-Class: 814a7b36-bfc1-4dae-8640-3722d8ec6cd6 Original-Received: from drachen.dragon ([88.66.71.129]) by smtp.web.de (mrweb106 [213.165.67.124]) with ESMTPSA (Nemesis) id 1MMGyK-1odPtF1ce6-00JTgO; Thu, 17 Nov 2022 03:17:47 +0100 X-Provags-ID: V03:K1:kIGBWBBgGAF4KTqEgcIflPPQzuOYPxQ5sIKZ5g1GLX2wzqIKv7u GcGVrE9jk9O7j/tIdpXBdHlXeyGSW/KcEY1hgSFku2k+cQCTY6jk478/XauWRvq3jjM5JX+ M1F4+fzCHuNlRyNqQXfuILLlqsOblrBN/4KAflYtwTsw4Cr/Fdkd/SYVxnnk1DOdJ8lQOsN MvTu4KUeK/5F/+BniFB9g== UI-OutboundReport: notjunk:1;M01:P0:tgLRvF7w9rE=;NWV0CtSC6r+m2iXc3itKLhi4DLc oARmRQjSCoeEGvHs+bdafDwaAMu7/DN55mGpMcD9ZIBi78Jb34TcXQ0LJcVg7+D4AC0whE0mK lgNdPYHH8bS3kBjOZ+Dcp9d+oJWfhilCchZiDrM+vtwB6Er1hIkvNyNigfb2s1vcPrnaYuww/ XfBrkD8WeqczZCY5OvN4iSD9ixuoJhLBtCLaX40Vm4ARHOiTXu5X4SbVEhbgaNPOXPuiJwsn2 bk30oKePSvW+UKmHa0d3RFLMyov+IV5mCSjdOc7bpc4OPHLGx/QNg/i0uAO6TJk+b049fMQv+ Oo+eaYMvwU9s2odGiDMl++SJjB1Qzmqw10ejalkQHqpRgyu50XXF1a2mv2LpWz22q8eulTX1w yDw/NvLpqsz0zjyogMQCM+egm7G42TGhqMXSrCQPH50uGv2qemuj2qVoHu3xp8GFFd9/VJcax 9lZofYImRVzfFv0+ikpE4sedsdzHhwV8Nvj+tph/Et+1kuVdF+BpJ8krWJT7JQfro9X492SDy orkrs9yZiSvUTy80otbkE5XyWMXQtkF4IGdlMCAPdKxetmJITuBb7sQgKq6KZulxraCUpvxEX 7Vd1nVJoLTq0Pa1kHB6VmnDAtK7zgP9mQof6ja79M0AI9SsCbWMVWfc5AJjdC0Val3ecs687A 0R8SPMJBUqx8gNZl4k14xsWc/u3Gktul0Olek4h/zFqpEkbHONbFAHRyWSK8mkvBbhBBvIen4 C1/L003ytXWFadEW5tyEmbHZ6t7nDtjNIcb7dsshtWv4bWe5j90RG+GmEGZy3UMev3A0211a Received-SPF: pass client-ip=217.72.192.78; envelope-from=michael_heerdegen@web.de; helo=mout.web.de X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:248071 Archived-At: Hello, [FWIW I tried to reopen 58278 but it seemed to...complicated for me] The current implementation of the (non-generic!) function `seq-keep': #+begin_src emacs-lisp (defun seq-keep (function sequence) (delq nil (seq-map function sequence))) ;; ^^^^ #+end_src obviously only works when `seq-map' returns a list. This is the case for the default implementation of the generic function `seq-map' but not necessarily for other implementations of `seq-map'. We need to filter out the `nil' elements with a way appropriate for any sequence type supported by "seq.el" (i.e. with a generic function defined in this lib), e.g. #+begin_src emacs-lisp (defun seq-keep (function sequence) (seq-filter #'identity (seq-map function sequence))) #+end_src BTW, is the name a good one? Why "keep"? It returns a sequence of potentially all completely different elements. And is the function that useful and a good abstraction at all (I don't have thought about it too long...)? TIA, Michael.