From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Danny Freeman via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#59338: 29.0.50; Commit 1a2d603bb3 breaks Eglot on Windows Date: Fri, 18 Nov 2022 08:39:13 -0500 Message-ID: <87wn7swf4e.fsf@dfreeman.email> References: <86bkp5y16y.fsf@gnu.org> <83r0y1cxyb.fsf@gnu.org> <87o7t5wlby.fsf@gmail.com> <87bkp5xl6f.fsf@dfreeman.email> <87fsehw4ze.fsf@gmail.com> <83cz9kd99x.fsf@gnu.org> Reply-To: Danny Freeman Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="19815"; mail-complaints-to="usenet@ciao.gmane.io" Cc: arash@gnu.org, arstoffel@gmail.com, 59338@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Nov 18 14:46:41 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1ow1hY-0004wh-KO for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 18 Nov 2022 14:46:40 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ow1h0-00016S-60; Fri, 18 Nov 2022 08:46:06 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ow1gw-00014r-Je for bug-gnu-emacs@gnu.org; Fri, 18 Nov 2022 08:46:02 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1ow1gv-0003bC-VI for bug-gnu-emacs@gnu.org; Fri, 18 Nov 2022 08:46:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1ow1gv-00066z-Rg for bug-gnu-emacs@gnu.org; Fri, 18 Nov 2022 08:46:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Danny Freeman Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 18 Nov 2022 13:46:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 59338 X-GNU-PR-Package: emacs X-Debbugs-Original-Cc: arash@gnu.org, Augusto Stoffel , bug-gnu-emacs@gnu.org, 59338@debbugs.gnu.org Original-Received: via spool by submit@debbugs.gnu.org id=B.166877913223443 (code B ref -1); Fri, 18 Nov 2022 13:46:01 +0000 Original-Received: (at submit) by debbugs.gnu.org; 18 Nov 2022 13:45:32 +0000 Original-Received: from localhost ([127.0.0.1]:35807 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ow1gS-000662-9n for submit@debbugs.gnu.org; Fri, 18 Nov 2022 08:45:32 -0500 Original-Received: from lists.gnu.org ([209.51.188.17]:38240) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ow1gR-00065u-1g for submit@debbugs.gnu.org; Fri, 18 Nov 2022 08:45:31 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ow1gQ-0000yU-PZ for bug-gnu-emacs@gnu.org; Fri, 18 Nov 2022 08:45:30 -0500 Original-Received: from out0.migadu.com ([94.23.1.103]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ow1gO-0003VS-8T; Fri, 18 Nov 2022 08:45:30 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=dfreeman.email; s=key1; t=1668779124; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=Pls7XHyQ2wQYBxNRvg/qnOBiBftTwq8gIErLegp6ogk=; b=BJarRwS1cHa+M6WCV7vcCH9xIsogkuaavc/J3tiQ3EwkwwOCEUD69yjiK6D4L8Az9TXb3p 3iqLhzIOTWQZ6DxFGepvBp0VN09+mhE7YkV3+YZmuS5e67pmUturqGm8bGzGgw8Ej00u3H yJfxG7V3dgkLGPaeOH/kareaMvctXEQ= X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. In-reply-to: <83cz9kd99x.fsf@gnu.org> X-Migadu-Flow: FLOW_OUT Received-SPF: pass client-ip=94.23.1.103; envelope-from=danny@dfreeman.email; helo=out0.migadu.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:248237 Archived-At: Eli Zaretskii writes: > > Not sure I understand why this matters in the context of this > discussion. We need to make eglot--path-to-uri produce valid file:// > URL on MS-Windows and on Posix systems, right? Then why does it > matter how URI schema are defined? What am I missing? The current eglot--path-to-uri implementation should produce a valid file:// url unless what it receives is already a URL. So it could receive something like: /home/user/project/whatever.c d:/what/home/is/on/windows/whatever.c Both of which should be transformed into file:// URLs OR what it receives may already be a URL like zipfile:home/user/project.zip::/path/in/zip.c If it receives a URL, we want to pass it along, and not transform it into a file:// URL. If it is a full windows path, we DO want to turn that into a file url. So how do we detect that is is a windows path, and not a URL already? That's what I was trying to get at in the other message you replied to. Just checking the user's current OS is not enough, because this function could also receive a URL on Windows. -- Danny Freeman