From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Po Lu via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#59407: [PATCH] Add Colors to proced Date: Sun, 20 Nov 2022 20:33:59 +0800 Message-ID: <87wn7p7qko.fsf@yahoo.com> References: Reply-To: Po Lu Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="30598"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: 59407@debbugs.gnu.org To: Laurence Warne Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Nov 20 13:35:20 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1owjXc-0007kc-4Z for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 20 Nov 2022 13:35:20 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1owjXL-0007Ap-Nf; Sun, 20 Nov 2022 07:35:03 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1owjXK-0007Ag-J6 for bug-gnu-emacs@gnu.org; Sun, 20 Nov 2022 07:35:02 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1owjXK-0008KQ-31 for bug-gnu-emacs@gnu.org; Sun, 20 Nov 2022 07:35:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1owjXJ-00038l-Mr for bug-gnu-emacs@gnu.org; Sun, 20 Nov 2022 07:35:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Po Lu Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 20 Nov 2022 12:35:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 59407 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 59407-submit@debbugs.gnu.org id=B59407.166894766112014 (code B ref 59407); Sun, 20 Nov 2022 12:35:01 +0000 Original-Received: (at 59407) by debbugs.gnu.org; 20 Nov 2022 12:34:21 +0000 Original-Received: from localhost ([127.0.0.1]:42598 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1owjWf-00037i-5V for submit@debbugs.gnu.org; Sun, 20 Nov 2022 07:34:21 -0500 Original-Received: from sonic304-21.consmr.mail.ne1.yahoo.com ([66.163.191.147]:36763) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1owjWc-00037U-AR for 59407@debbugs.gnu.org; Sun, 20 Nov 2022 07:34:19 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1668947651; bh=Av0lZpiEbjgcLDY+uQZ9KBZLK+shtfjzyiN4s5nrSRA=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From:Subject:Reply-To; b=fpINY3grynPSi+V3Vcw2uK5khW5OuoN/aUCWYfHB+0SvRkrZ6bE2/u8BnBv4b1YD7brYk8sCgiYPnt+YU5qYgX3IfHz1OMQNRmw6XNuyImRFjhT4x9liQSvd0Zt96gA2GdVHXZeyVxECyPyXLkxv17vt2zKyEPSq/O+LCKe31t/E5dyuK5eZvRMmGEbeS0DyHIROwmG8SsZE+gAl0FMxlA44xUpDfqRK7aISBxJXaB8BZjOQtiq5FxvwUEjjTpLh3YopNkpqwle4Fop3YUkunYBuhfMWcg7kD+VdKEhsYQhpFMP86l4jzXhrjZ7k1nfjnFV1cWWbIJhjryW2rwztTw== X-SONIC-DKIM-SIGN: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1668947651; bh=CuCDjS9/WOddhWlEiGlKeSbZ+oaEZ2gAjvAjrfyBbYS=; h=X-Sonic-MF:From:To:Subject:Date:From:Subject; b=oubDv/rOoo3hUYoj+Q87hMCm918FzKIWe+3NqpYWJmR3x3kQpLH5hwOEbcn1UNwIj85XHjLX3B6bhuItQFiQhuG6DqGa6qiHm5IMza2Z8JfIay9Oz3q5OKZFPA1wsCzoaUb8zOUpB8J1JRCYFkXhd6JTHIZUtHC7E8ie9rEB2tU8pISzdYyPSg+ALBoAwDiHUMzMV3K2cprrVS4t2dkt2zvQrS2K/7FupoTeUJc3yHQBOdjbyEgT/21+Z6ya7OnRTVLkqYLX5uLOv7do0PPVYu3rW+b7VXzZE88puzH2jNaP2bQjjfqr8tbOOMt6C58bw+PHE/G+Av389vlEtH571A== X-YMail-OSG: 0VKAwKQVM1m_fJHcp7yZP3YHya2XzQ9buny15rYAxryz9zV_49HeVVKDJtovjPr UphhTxPAjSylU2t.UjMA5fmZhN8a7VN49I3dVGOLLZV.ymxE.TAUMuuV0_jExxP0DzH0VHXXFsXi mMd8VdmNHtAFKQvmoQ7xkZGeNFfzyYCzDPa6UZ3cBj7PIgUL408Sj.qrw0pDuWR4gGKBEncmyBnO xW3D8WQ0MvviXn6_i0BcDFLerCDgO8fHh_lTzXkuy1j9LLb9ewgqBYfn0Pyp0PVrbluteoK8wfDt ZUyPmy0WHosP6HIiT9AWgdSIHSAxJvylE8FZweUKuy1kNi8HJFjidzO5PK07Oi7J3a7hubdxbu69 l9PkBcqAC5LCGcJ.TgBv1Cfs4gKKBIdiLMxg80IK6Y4yy1EzfexBPtwR_9XMp9.l4bkdH03l3Jyq qD3mStCqf_EgDb4RWtprY7E5yyCgJCXkjMXWUztrIa_Gs8uR4sUTND_sUCJgOB4V5W9.PewFRBOQ NTj9.DTm5FqCHh4LqvBIn_9VJC1zTe_2quM1IWkbHAcPezAK9k7jfLhQIFd0IX7YTN6w_KKQPlXk KDG7zRrM4ys90j6zC38UFfngEZHlEqwzW8WPahO1g12OAv6GxTs7eVSFq5UEFxWG2aY3tKMDwPoQ u1wkr0TbWw.W8IiUa2fRV852PuOlR0zxD3JPW6g99wc0_FijxMwKLi3s.t0msWEJlKxX2ffRStO4 N04q1OMigs8ztcoWMgr48BpljzqOIFV50dKqaVxQZa7d1CrcGOetcrRu.S_r2WNcd__sIgCiahuX devYlyP4RDzuwwJ.tT8hMAE0BUPNOUnEut0ZAfPxlN X-Sonic-MF: Original-Received: from sonic.gate.mail.ne1.yahoo.com by sonic304.consmr.mail.ne1.yahoo.com with HTTP; Sun, 20 Nov 2022 12:34:11 +0000 Original-Received: by hermes--production-sg3-6c8895b545-zc8w5 (Yahoo Inc. Hermes SMTP Server) with ESMTPA ID b7ea0d3457bf8a29cdd7cff7021ebeec; Sun, 20 Nov 2022 12:34:06 +0000 (UTC) In-Reply-To: (Laurence Warne's message of "Sun, 20 Nov 2022 10:26:35 +0000") X-Mailer: WebService/1.1.20863 mail.backend.jedi.jws.acl:role.jedi.acl.token.atz.jws.hermes.yahoo X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:248419 Archived-At: Laurence Warne writes: > Hi, attached is a patch I've recently been working to do with > colorizing proced buffers, similar to htop. > > In particular, the current Emacs process id is highlighted purple in > both the process id and parent process id columns, session group > leaders have their process ids underlined, larger memory sizes for rss > and vsize are highlighted in darker shades of orange, and the first > word in the args property (the executable) is highlighted in blue - > I've attached a couple of screenshots. Thanks, but what exactly is the purpose of this change? The more colors that need to be allocated, the slower Emacs becomes over a wide-area network. In addition, every time a new color is used, xfont_draw needs to be called again, generating more network traffic. Emacs has already become quite slow over a network connection (though this should have become significantly better in Emacs 29.) Adding "eye candy" where it is not really necessary will only be a step backwards. > (require 'proced) > (setq-default proced-auto-update-flag t) > (setq-default proced-auto-update-interval 1) > (setq proced-enable-color-flag t) I guess if it is off by default, then I have no objections. But I respectfully ask everyone to keep in mind the network impact of changes they make to Emacs.