From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Michael Heerdegen Newsgroups: gmane.emacs.bugs Subject: bug#59328: 29.0.50; `seq-keep' implementation only valid for lists Date: Fri, 25 Nov 2022 10:47:31 +0100 Message-ID: <87wn7jfjrg.fsf@web.de> References: <87wn7ujpdh.fsf@web.de> <83edtz84wl.fsf@gnu.org> <87pmdctsf8.fsf@web.de> <83edtswi35.fsf@gnu.org> <87fse8tona.fsf@web.de> <83cz9cwg5z.fsf@gnu.org> <87bkowtmmr.fsf@web.de> <83a64gwfhv.fsf@gnu.org> <877czktlvr.fsf@web.de> <838rk0wak3.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="799"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: larsi@gnus.org, jonas@bernoul.li, 59328@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Nov 25 10:48:17 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oyVJf-000ASc-4x for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 25 Nov 2022 10:48:15 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oyVJV-0008A5-WC; Fri, 25 Nov 2022 04:48:06 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oyVJT-00089v-CI for bug-gnu-emacs@gnu.org; Fri, 25 Nov 2022 04:48:03 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oyVJT-0008Hy-47 for bug-gnu-emacs@gnu.org; Fri, 25 Nov 2022 04:48:03 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1oyVJS-0003i8-6k for bug-gnu-emacs@gnu.org; Fri, 25 Nov 2022 04:48:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Michael Heerdegen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 25 Nov 2022 09:48:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 59328 X-GNU-PR-Package: emacs Original-Received: via spool by 59328-submit@debbugs.gnu.org id=B59328.166936966214147 (code B ref 59328); Fri, 25 Nov 2022 09:48:02 +0000 Original-Received: (at 59328) by debbugs.gnu.org; 25 Nov 2022 09:47:42 +0000 Original-Received: from localhost ([127.0.0.1]:33544 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oyVJ7-0003g6-QN for submit@debbugs.gnu.org; Fri, 25 Nov 2022 04:47:42 -0500 Original-Received: from mout.web.de ([212.227.15.4]:35377) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oyVJ5-0003fq-Oc for 59328@debbugs.gnu.org; Fri, 25 Nov 2022 04:47:40 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=web.de; s=s29768273; t=1669369652; bh=miAtC+62jY5ayWQYBFmmxA4d6JdnlsyMr8sJaKUND60=; h=X-UI-Sender-Class:From:To:Cc:Subject:In-Reply-To:References:Date; b=kj4NlBEADJXqdkXeA1FHzUrdFcjod8N+8VTpa/61QjKHfra5L58KnwXcjVvRleeaK Ya4UKfZia7IffBQOV/p79HJ11rnN+2daM4qi2nQfs2VNeM447YR383FR6GuDZGL404 XPeWe6O72D+aGa/3x8mDmVs6pZ6Z6WoT6AHQDHU8JfG2bFyHgLshxNAyJqKyuj4l/c lZbg9oKMEAyJ9NjSeQpHgWq1NTdWJ21oms88nCL9nNmHVRRJAMbOedSJAocvbnUCbQ QwyrDeyhZTLdBCSmXH285GZ8P8BYs9D5Hvj33HXCKtE8jN4BUGO13vdNfgYHp813yQ gYbp5YUk7MJqg== X-UI-Sender-Class: 814a7b36-bfc1-4dae-8640-3722d8ec6cd6 Original-Received: from drachen.dragon ([92.76.229.140]) by smtp.web.de (mrweb005 [213.165.67.108]) with ESMTPSA (Nemesis) id 1MYLig-1pTyD823hC-00VMul; Fri, 25 Nov 2022 10:47:32 +0100 In-Reply-To: <838rk0wak3.fsf@gnu.org> (Eli Zaretskii's message of "Thu, 24 Nov 2022 19:02:04 +0200") X-Provags-ID: V03:K1:WLZmBXHVdzO10zfMlibjqeWz34QaJOR8bc/qY/PvJ1LhDGlLsq0 ULpdpkkRCaINXe8P8xPtWIZOfsJx7BpKijrvJZrU0uSgFOODwXPu6GIjxr5O/jDfEnuZzax rifrIMLcixS56F4SHiY76IQiTdFduqthpJ2gNRV4m25O6b/7ZLIOa8XilHbTds7z/xip4Z6 KxfUJyhZ1ysS3DxsOF24A== UI-OutboundReport: notjunk:1;M01:P0:PVYG0SpLuc8=;3zYSkV+KryqCw7+KTffgOJKfj6p f6NerJJZ+lMWSQqbPhqqGKweHrcjI/gPXwKsIokbHnrEEWu+c+TFUzj8pVv1HszDE1e5fgTM0 d0dI9fwrAq+c7iJNW0Z/BbVfhWCOLYiEUqqGRomwInLegGpqEMKCEhhSIOSPpNgGPn11fUIcY p11eWX78WvOBk3H5XFA0OikArjtGFpZ9B9jcE55boRnllYFategCCTAqwgvS1ypA2VupzA97E qnUWRbjUIKHgW/W1F4ASzUeRwQOXZ+mfYnfRGGYJTIoWw8iflhkiJ4wpdfbE/xywU2if4acR6 5GDZ6q/oXFm9YmjPXPqIJhEtazVviFyvVeV8WAKkPEa1/RarBZHdBrvfkNBr8SbCDJ4Ie0gkf DNfKfsk/kK4piV73jwUun8gPbUU7s9APGiJxc4vyY9fQXeYwxJ3Llz+FilBygbua4i2em/UBq iEXUn7vYYLSB+Dhe+jUrCZxvYR1WmUk22DkhHFDdwfQ2x7W0cwga2KN+FhgmNo04F4ZRS0DKV XfGZYKrVfceumqzvfdUteUzqJY14+v8zkx913qRlTlYADtQnnAL0DACR9Ppj8I7GXH4kq8j/G XpaNkxQntSHKO42LOH9PfizUFnK6XWhWdRCnpzkG1QzkpQGrL89wh+QXvc0Flj3DuX0nsZ0A8 vWqb4oO3ll6Ca5gMWRa5xO1cg1hzVv9U2Yxo2hZMYy/UGaQ3G5x8buBIAflGufLkzkrqJL5o9 7tWQTrC/nf7coAZLbH9FP5Jp1kMsh3KOfDiN+NND/Z+dkeKP1TLp5Et58hV/NxLGkM5QRW8x X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:248986 Archived-At: Eli Zaretskii writes: > Can tests for this be written in a way that they are only run if the > relevant packages are available on the user's system? If so, I'd > prefer to have that than no tests at all. I don't know. Alternatively we could implement `seq-map' for an ad-hoc defined sequence type and test using that type, e.g. this expression: #+begin_src emacs-lisp (progn (defvar gensym) (let ((gensym (make-symbol "foo"))) (eval `(cl-defmethod seq-map (function (thing (head ,gensym))) (append (list (car thing) (cadr thing)) (seq-map function (cddr thing)))) t) (equal (list gensym nil 4 46) (seq-keep (lambda (x) (and (integerp x) (* 2 x))) (list gensym nil 2 'x gensym 23))))) #+end_src returns t with my patch installed and nil else and works without relying on something external. I'm not sure if defining methods (for seq-map in this case) that are globally visible is allowed in tests, so I implemented the example above in a way that the change of the generic function is not visible from the outside (thus the "secret" gensym). Would something like that be acceptable? Sorry for my ignorance, I didn't write much tests before. TIA, Michael.