From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Protesilaos Stavrou Newsgroups: gmane.emacs.bugs Subject: bug#60580: 29.0.60; crash in xdisp.c with modus theme and display-fill-column-indicator Date: Fri, 06 Jan 2023 06:01:05 +0200 Message-ID: <87wn60pb0e.fsf@protesilaos.com> References: <83h6x4wy8c.fsf@gnu.org> <83fscowxy3.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="27267"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 60580@debbugs.gnu.org To: Eli Zaretskii , yandros@gmail.com Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Jan 06 05:02:21 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pDdvx-0006wt-Lc for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 06 Jan 2023 05:02:21 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pDdvf-00053B-Kt; Thu, 05 Jan 2023 23:02:03 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pDdve-000530-Hd for bug-gnu-emacs@gnu.org; Thu, 05 Jan 2023 23:02:02 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pDdve-00076X-9d for bug-gnu-emacs@gnu.org; Thu, 05 Jan 2023 23:02:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pDdvd-0006NR-TH for bug-gnu-emacs@gnu.org; Thu, 05 Jan 2023 23:02:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Protesilaos Stavrou Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 06 Jan 2023 04:02:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 60580 X-GNU-PR-Package: emacs Original-Received: via spool by 60580-submit@debbugs.gnu.org id=B60580.167297767824454 (code B ref 60580); Fri, 06 Jan 2023 04:02:01 +0000 Original-Received: (at 60580) by debbugs.gnu.org; 6 Jan 2023 04:01:18 +0000 Original-Received: from localhost ([127.0.0.1]:53465 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pDduw-0006ML-37 for submit@debbugs.gnu.org; Thu, 05 Jan 2023 23:01:18 -0500 Original-Received: from relay1-d.mail.gandi.net ([217.70.183.193]:33145) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pDdut-0006M8-Ne for 60580@debbugs.gnu.org; Thu, 05 Jan 2023 23:01:16 -0500 Original-Received: (Authenticated sender: public@protesilaos.com) by mail.gandi.net (Postfix) with ESMTPSA id C1676240008; Fri, 6 Jan 2023 04:01:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=protesilaos.com; s=gm1; t=1672977669; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=Ak2YodorDoaEHYEQ+dLH2c9wQen+9ERMGC/6ZmJTA5w=; b=ltD0+nV9Z87whzPmSVKAKiy53+iyY/WJAdfotWPyBu8BnVMd79UPTNNvr4BRnZHehTw0A/ LN5OzpvuCYgWpqvrhVtg7fRUo+zS8ey9l2xlxd0kvOKpwreWINYXzllKQp68SB/wGElaFl S1FimQrDniCAnM9bGd94uzB+sC9o5wQpwhnU8hjCFI9JNUCrcug8tAHU5jQva+ADpL/L+O D1NOBp7XB5fp0NCX/S74sXtivLV9NTP9YpXEA2P3LxTZbYEDcguVupsAbg8yvqVhbYtqB2 UybOpBqAGTUaquXLoIQf/ImcYS3O8f0q0OALOUvN/OjML6GUjDDFrBGgEvk+9A== In-Reply-To: <83fscowxy3.fsf@gnu.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:252651 Archived-At: > From: Eli Zaretskii > Date: Thu, 5 Jan 2023 22:03:48 +0200 > >> Cc: 60580@debbugs.gnu.org >> Date: Thu, 05 Jan 2023 21:57:39 +0200 >> From: Eli Zaretskii >> >> > From: chad >> > Date: Thu, 5 Jan 2023 14:19:48 -0500 >> > >> > From emacs -q, evaluate: >> > >> > (custom-set-variables '(custom-enabled-themes '(modus-vivendi))) >> > (global-display-fill-column-indicator-mode 1) >> > >> > Emacs will fail the eassert in append_stretch_glyph at >> > xdisp.c:30993. >> >> Doesn't happen here. What is your default face's font with that theme? > > I guess the culprit is this bit: > > ;;;;; display-fill-column-indicator-mode > `(fill-column-indicator ((,class :height 1 :background ,bg-region :foreground ,bg-region))) > > I have no idea what is ":height 1" about, but I think it's wrong and > should be replaced with some reasonable value. The ":height 1" has been there for many versions and never caused a problem of this sort. If this is the cause, I will change it right away. The reason it is like this is to make the indicator a contiguous line that is not affected by variations in font heights and/or a high 'line-spacing' value. Otherwise the indicator can appear as a dashed line. -- Protesilaos Stavrou https://protesilaos.com