From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Po Lu via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#61387: 30.0.50; Support webkit2gtk-4.1 Date: Fri, 10 Feb 2023 10:56:01 +0800 Message-ID: <87wn4q2pq6.fsf@yahoo.com> References: <83zg9nkkym.fsf@gnu.org> <83sffelubg.fsf@gnu.org> Reply-To: Po Lu Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="35617"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: Eli Zaretskii , 61387@debbugs.gnu.org To: Ulrich =?UTF-8?Q?M=C3=BCller?= Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Feb 10 03:59:36 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pQJdQ-00097T-7p for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 10 Feb 2023 03:59:36 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pQJd3-0003QT-9c; Thu, 09 Feb 2023 21:59:13 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pQJd0-0003Pt-Lh for bug-gnu-emacs@gnu.org; Thu, 09 Feb 2023 21:59:11 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pQJcs-0008Hv-8s for bug-gnu-emacs@gnu.org; Thu, 09 Feb 2023 21:59:09 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pQJcr-0000bI-RR for bug-gnu-emacs@gnu.org; Thu, 09 Feb 2023 21:59:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Po Lu Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 10 Feb 2023 02:59:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 61387 X-GNU-PR-Package: emacs Original-Received: via spool by 61387-submit@debbugs.gnu.org id=B61387.16759978982252 (code B ref 61387); Fri, 10 Feb 2023 02:59:01 +0000 Original-Received: (at 61387) by debbugs.gnu.org; 10 Feb 2023 02:58:18 +0000 Original-Received: from localhost ([127.0.0.1]:34017 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pQJcA-0000aE-DH for submit@debbugs.gnu.org; Thu, 09 Feb 2023 21:58:18 -0500 Original-Received: from sonic317-2.consmr.mail.ne1.yahoo.com ([66.163.184.229]:40521) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pQJc8-0000Zy-6Y for 61387@debbugs.gnu.org; Thu, 09 Feb 2023 21:58:16 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1675997890; bh=qMyJOQvT1IOh0cfIMRP/E4zq8jdExi5KU1EbkQJho1Q=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From:Subject:Reply-To; b=pm10Bss5zVHtrQ4wVUrv/iBA9SjBkFv5C9CXHTiQ5yoMRz3O8BAhX4m9zTrz6V6oGMZn0wrjWJkro2VmA3xgNWf6a6SVPCovWGX9FfVCNCalLnrT2wg/hTMqt0PL6cRTkyGbom7TbxO90xlxx95u8AwBy/dqdS3Uw/4tYZ3+z4AygOYy4ar51RTkTv9JPlQmUJSx+pHxD7bwyWxoBm+xEX0PojGa937p2xc1ZojbKNT3uFLNoEXob+BridfvTnSv8wEn/7s+3xEHg+r36W3GCNYhbmSXUh5dF9MalQMQcvPgnhzaBO0Zd+FvaS80fDlJCUoMc9JgLVxka3eQrneQ7g== X-SONIC-DKIM-SIGN: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1675997890; bh=0TInpogmzg3/jol+d7r9uo9PsPdIcwL+CZBGiI58QBt=; h=X-Sonic-MF:From:To:Subject:Date:From:Subject; b=jrQUttgU/w/jVAuondoHVgdZV9fmz3LKiL2aMhb+qat1KFB4stK+IRKVbK9Qe65O8fpTp3uaGsxqbwD/niBd66wdLO+VlL8g/4A/IsyL2//jkc5zxaLOw5PPYqRTrEjsQeK6QLRDuvgfi/cJVj/W8uIX8ia1mw1ePpUF1z1/WAct+Xgqwbu9sc46utPtCnI5BEcGzt3NL8HalzTWAvWFqY0BelZtKSYuAy6Y5RbqQBaKsU4qZFxt0aFb92KOGH0Y4jlWQvg6LU6qQxEiHCZmXgx4HmTnDrRjAo55LrVGSO+TXbc76BNC9kCOB/z0jLDjFakW7/tp7LLO7sW/QQX8Ng== X-YMail-OSG: bslKdqkVM1mZ7vXqhDa98RdivJZXmevXOTfSeeffPceD4W1wZVNGodPn32Hvr9e 58gG1pgOpE.8dV.jPQZyJgmWvgxOR7GvzKnAgmQcbLvWiecMnMXRLDtLMA8rNO2Sb0C7ge24yEcA 1OgAayYy.13kstfmrVj.GdwvRmbbLbax0xOrCJz5UDd_V7hwRjM.6a6DR1cOf8XwhuW_YutMU_c2 MRcjY3mht9FxK_3fQ2q110XolXEXe_hpylNOl1iMM5WzxAKFfNeEk.qSMBpJfdRlTm.bD2n6p70n uEOYrEQVLzQYY.RBO4CefYdMK0fQoXh6oANi_pWD9bHgGyKQLHW5Q5jnkLi0egythykaAQ4XeCKN ICnowmuPuznfZpwBgA1LvThO2mkzOj40D7wK6qvRW0m1D6WUDtwr0CEWln4xh_r.sWShQpzLgxx9 oo3XfQ_laGOd2ELTxM3GSyXwMUMCJlRk2MZfFEAe2O6YDob6.UrU5Z71ueT21jHFmbxlX.bSw7hT KKZCIQjETTpBx462XBO9qWQKfeskzQsyGQmigyuS9TkwUA8rL.YpF1SpjQpmPAt.sSLtvzPE7czY 3H3WYwEnNWMDMkDASiI59eyq2WKovmFPM.ty18bALbGP8c7mhOWb06U52G0MueJGYyZ7_2VNMgiF uzwsGvnADNtcGm.vSyL1u_Ne8zpnKj8YF2yWbCzJzMIyY65G_zwi7M2h8gF2_R_GdHsXXQKtPko4 MWvBvtYsjySvKd8Zirtt8l85x7LJ3Ikmswxp82F4YqNcc204r_y8wdKbRMGzq770Z3n5UGzdZBZB LPcUQMSEs9YQcQ77VnRwMhndLCFQ5HGWbR6GuzRR8J X-Sonic-MF: Original-Received: from sonic.gate.mail.ne1.yahoo.com by sonic317.consmr.mail.ne1.yahoo.com with HTTP; Fri, 10 Feb 2023 02:58:10 +0000 Original-Received: by hermes--production-sg3-9fc5746c8-2jxhw (Yahoo Inc. Hermes SMTP Server) with ESMTPA ID fd540164e4cdac3f309c0c31f48682f6; Fri, 10 Feb 2023 02:56:07 +0000 (UTC) In-Reply-To: ("Ulrich =?UTF-8?Q?M=C3=BCller?="'s message of "Thu, 09 Feb 2023 16:54:53 +0100") X-Mailer: WebService/1.1.21161 mail.backend.jedi.jws.acl:role.jedi.acl.token.atz.jws.hermes.yahoo X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:255266 Archived-At: Ulrich M=C3=BCller writes: >>>>>> On Thu, 09 Feb 2023, Eli Zaretskii wrote: > >> But if Gentoo is transitioning to this new version of webkit, wouldn't >> it make sense for Emacs 29 to support that, rather than require users >> to have a version of webkit that is considered outdated by Gentoo? > > We would have backported the patch to the Gentoo package for Emacs 29. > Including it upstream is of course preferable. > >>> Should I update the patch to allow 3 values "4.0", "4.1", and "auto", >>> with "auto" being the default? > >> Yes, please. > >>> And in the default case, should it check for 4.0 or 4.1 first? > >> I think 4.1 first, don't you agree? > > Yes. Please find the updated patch below. It applies cleanly to both > master and emacs-29. > > >>>From 9ac6e3711426eddacd095380b8e7f64a405706b2 Mon Sep 17 00:00:00 2001 > From: =3D?UTF-8?q?Ulrich=3D20M=3DC3=3DBCller?=3D > Date: Thu, 9 Feb 2023 10:58:48 +0100 > Subject: [PATCH] Support webkit2gtk version 4.1 > > * configure.ac: Add --with-webkit2gtk=3DVALUE configuration option, > where VALUE can be 4.0, 4.1, or auto (default). > --- > configure.ac | 26 ++++++++++++++++++++++++-- > 1 file changed, 24 insertions(+), 2 deletions(-) > > diff --git a/configure.ac b/configure.ac > index fc17dbd8318..d951fa84701 100644 > --- a/configure.ac > +++ b/configure.ac > @@ -521,6 +521,19 @@ otherwise for the first of 'inotify', 'kqueue' or 'g= file' that is usable.]) > OPTION_DEFAULT_OFF([xwidgets], > [enable use of xwidgets in Emacs buffers (requires gtk3 or macOS Cocoa= )]) >=20=20 > +AC_ARG_WITH([webkit2gtk],[AS_HELP_STRING([--with-webkit2gtk=3DVALUE], > + [version of webkit2gtk API to use (VALUE one of: 4.0, 4.1, auto; > +default auto)])], > + [ case "${withval}" in > + 4.0|4.1|auto) val=3D$withval ;; > + *) AC_MSG_ERROR(['--with-webkit2gtk=3D$withval' is invalid; > +this option's value should be '4.0', '4.1', or 'auto'.]) > + ;; > + esac > + with_webkit2gtk=3D$val > + ], > + [with_webkit2gtk=3Dauto]) > + > OPTION_DEFAULT_OFF([be-app], > [enable use of Haiku's Application Kit as a window system]) >=20=20 > @@ -3583,8 +3596,17 @@ XWIDGETS_OBJ=3D > if test "$with_xwidgets" !=3D "no"; then > if test "$USE_GTK_TOOLKIT" =3D "GTK3" && test "$window_system" !=3D "n= one"; then > WEBKIT_REQUIRED=3D2.12 > - WEBKIT_MODULES=3D"webkit2gtk-4.0 >=3D $WEBKIT_REQUIRED" > - EMACS_CHECK_MODULES([WEBKIT], [$WEBKIT_MODULES]) > + if test "$with_webkit2gtk" =3D "auto"; then > + WEBKIT_MODULES=3D"webkit2gtk-4.1 >=3D $WEBKIT_REQUIRED" > + EMACS_CHECK_MODULES([WEBKIT], [$WEBKIT_MODULES]) > + if test "$HAVE_WEBKIT" =3D "no"; then > + WEBKIT_MODULES=3D"webkit2gtk-4.0 >=3D $WEBKIT_REQUIRED" > + EMACS_CHECK_MODULES([WEBKIT], [$WEBKIT_MODULES]) > + fi > + else > + WEBKIT_MODULES=3D"webkit2gtk-$with_webkit2gtk >=3D $WEBKIT_REQUIRE= D" > + EMACS_CHECK_MODULES([WEBKIT], [$WEBKIT_MODULES]) > + fi > HAVE_XWIDGETS=3D$HAVE_WEBKIT > XWIDGETS_OBJ=3D"xwidget.o" > if test "$HAVE_X_WINDOWS" =3D "yes" && test "${with_cairo}" =3D "no"= ; then Please make the configure script detect WebKitGTK 4.1 by default, and fall back to 4.0. Not many systems will have both installed at the same time, and it is best for Emacs to use the newer version. People who want to use the older version can specify the cflags on the command line to configure. There is no need for a ``--with-webkit2gtk'' option, which is not very consistent with every other library we support.