unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Robert Pluim <rpluim@gmail.com>
To: Protesilaos Stavrou <info@protesilaos.com>
Cc: Eli Zaretskii <eliz@gnu.org>, 61567@debbugs.gnu.org
Subject: bug#61567: 30.0.50; Define display-time-time-and-date-indicator face
Date: Fri, 17 Feb 2023 11:58:25 +0100	[thread overview]
Message-ID: <87wn4g1ru6.fsf@gmail.com> (raw)
In-Reply-To: <87lekwwp61.fsf@protesilaos.com> (Protesilaos Stavrou's message of "Fri, 17 Feb 2023 12:40:22 +0200")

>>>>> On Fri, 17 Feb 2023 12:40:22 +0200, Protesilaos Stavrou <info@protesilaos.com> said:

    >> From: Robert Pluim <rpluim@gmail.com>
    >> Date: Fri, 17 Feb 2023 11:31:08 +0100
    >> 
    >>>>>>> On Fri, 17 Feb 2023 08:37:32 +0200, Eli Zaretskii <eliz@gnu.org> said:
    Eli> ** New face 'display-time-time-and-date-indicator'.
    Eli> This is used for displaying the time and date components of
    Eli> 'display-time-mode'.
    >> 
    Eli> should be enough.
    >> 
    >> >> +(defface display-time-time-and-date-indicator nil
    >> >> +  "Face of the `display-time-format'."
    Eli> ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
    Eli> "Face for `display-time-format'."
    >> 
    >> Thatʼs a very repetitive name. How about just
    >> `display-time-indicator-face' (although I have a vague memory of there
    >> being a guideline to not end faces in -face)

    Protesilaos> Indeed, the name is awkard.  I also remember that use of "-face" is
    Protesilaos> discouraged, but could not find the resource for it.

I canʼt find anything in the elisp manual. But I do note that all the
font-lock faces end in '-face'

    Protesilaos> My initial idea was to use "display-time-face", which would also be
    Protesilaos> symmetric with "display-time-mail-face".  Note though that the latter is
    Protesilaos> defined as a 'defcustom', so I wasn't sure what the right approach is.

`defface' defined faces are customizable, so I donʼt think it matters.

Robert
-- 





  reply	other threads:[~2023-02-17 10:58 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-02-17  6:07 bug#61567: 30.0.50; Define display-time-time-and-date-indicator face Protesilaos Stavrou
2023-02-17  6:37 ` Eli Zaretskii
2023-02-17 10:16   ` Protesilaos Stavrou
2023-02-17 10:31   ` Robert Pluim
2023-02-17 10:40     ` Protesilaos Stavrou
2023-02-17 10:58       ` Robert Pluim [this message]
2023-02-17 11:33         ` Protesilaos Stavrou
2023-02-17 12:30           ` Robert Pluim
2023-02-17 12:35           ` Eli Zaretskii
2023-02-17 12:43             ` Robert Pluim
2023-02-18  7:36               ` Protesilaos Stavrou
2023-02-17 12:02         ` Basil Contovounesios via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-02-17 15:47           ` Drew Adams

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87wn4g1ru6.fsf@gmail.com \
    --to=rpluim@gmail.com \
    --cc=61567@debbugs.gnu.org \
    --cc=eliz@gnu.org \
    --cc=info@protesilaos.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).