From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Robert Pluim Newsgroups: gmane.emacs.bugs Subject: bug#63236: 29.0.90; loaddefs-generate not 100% backwards compatible Date: Wed, 03 May 2023 15:47:21 +0200 Message-ID: <87wn1pjzme.fsf@gmail.com> References: <87cz3ill2x.fsf@gmail.com> <871qjxlseb.fsf@gmail.com> <83bkj1mzj2.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="7804"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 63236@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed May 03 15:48:23 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1puCqE-0001nE-Vx for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 03 May 2023 15:48:23 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1puCpx-0007m7-FL; Wed, 03 May 2023 09:48:05 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1puCpv-0007kr-TI for bug-gnu-emacs@gnu.org; Wed, 03 May 2023 09:48:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1puCpu-0005rp-EC for bug-gnu-emacs@gnu.org; Wed, 03 May 2023 09:48:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1puCpu-0004Mx-Ak for bug-gnu-emacs@gnu.org; Wed, 03 May 2023 09:48:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Robert Pluim Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 03 May 2023 13:48:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 63236 X-GNU-PR-Package: emacs Original-Received: via spool by 63236-submit@debbugs.gnu.org id=B63236.168312165116607 (code B ref 63236); Wed, 03 May 2023 13:48:02 +0000 Original-Received: (at 63236) by debbugs.gnu.org; 3 May 2023 13:47:31 +0000 Original-Received: from localhost ([127.0.0.1]:45986 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1puCpO-0004Jm-RZ for submit@debbugs.gnu.org; Wed, 03 May 2023 09:47:31 -0400 Original-Received: from mail-wm1-f46.google.com ([209.85.128.46]:62493) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1puCpN-0004JT-27 for 63236@debbugs.gnu.org; Wed, 03 May 2023 09:47:29 -0400 Original-Received: by mail-wm1-f46.google.com with SMTP id 5b1f17b1804b1-3f315712406so25410895e9.0 for <63236@debbugs.gnu.org>; Wed, 03 May 2023 06:47:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1683121643; x=1685713643; h=content-transfer-encoding:mime-version:message-id:date:references :in-reply-to:subject:cc:to:from:from:to:cc:subject:date:message-id :reply-to; bh=w2mJFhCq02OBqsmprabfD3EIf9uuwIsB9l02c8W30Ok=; b=XmvOglj2B3/KWogPnK+p3jYRXhNpiBgUBfCGMqgf9RJf2VFaCvj6WzeYVP05bdMEbm b3eFKPYGe1lNV6z/A/VEue2+aWwqIZKnCIMrmW/cfgBfgZgyolECXWAtoe79xSWq3lKk i3br65Y6ED+onv77qMxGsf2N/wr9n+jmAMaNdZBSoTlI5in9fSVmdl2E0Qqcm51ZGYfx 4J0H3bGcjtKZ3YlPEAJx7af4Kn1Z/x4TujcGVSCClrLD6OJ8TV0foCuNjUy7rupRPvZA YcICgpncTFKbgqnkYz71+4nenk+QQcbCYZinyVhZXNMX+0bZ8UKFa5Uq8qnu047g/0ZD XQZg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1683121643; x=1685713643; h=content-transfer-encoding:mime-version:message-id:date:references :in-reply-to:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=w2mJFhCq02OBqsmprabfD3EIf9uuwIsB9l02c8W30Ok=; b=cNFG2Oc2EFVWy2uB3Ve4h477IAruwhmcBGjRJ/m9t8/90yCfxg3UoSePC6BaUEbF71 8OdlTMx77/Ywa6KDUfXBaHHHLxFXQ6XOTrV++h7R4bwvLgCezpq4qtRKkboaicRZNJ5q Q2h17VxNJehh+rUffUX7Z5FCyC5weQZkWO2oKzAU9GVdXMq2sRtqOVnKWHJgvruolVCG IHQHys1Zpz7FKArrekyaRVC/tzN9WZub4weJntgK2sZkcchqO5fREkcftyEBUTnzKPxE uICh6eXu/sBoqT4AasPZbruTfcoZO0XL3ZgIn0JW/KkJBnYgnEa5vNEVFR8XWYeqrsMp fYfQ== X-Gm-Message-State: AC+VfDzrX65zZgZham2o9B2cFdEh50cEHtWMlUDKOn4wPFIlil2FYlrk mFOjAn5q0XtYuzAuw7O29zaoRlXEAMA= X-Google-Smtp-Source: ACHHUZ532EwSNke746/elUZIs2aBUNmjj8rfQrFBI9I6wvK5XBbMmaS99CpXOeGeV53v2dxaK3jzlA== X-Received: by 2002:a5d:5689:0:b0:304:7bbf:7c1e with SMTP id f9-20020a5d5689000000b003047bbf7c1emr144483wrv.4.1683121642522; Wed, 03 May 2023 06:47:22 -0700 (PDT) Original-Received: from rltb ([82.66.8.55]) by smtp.gmail.com with ESMTPSA id m8-20020a7bcb88000000b003f173956a82sm1987222wmi.21.2023.05.03.06.47.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 03 May 2023 06:47:21 -0700 (PDT) In-Reply-To: <83bkj1mzj2.fsf@gnu.org> (Eli Zaretskii's message of "Wed, 03 May 2023 14:21:05 +0300") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:260978 Archived-At: >>>>> On Wed, 03 May 2023 14:21:05 +0300, Eli Zaretskii said: >> From: Robert Pluim >> Date: Wed, 03 May 2023 10:40:28 +0200 >>=20 >> >>>>> On Tue, 02 May 2023 19:06:14 +0200, Robert Pluim said: >>=20 Robert> I attempted to upgrade my packages today using `list-packages',= which Robert> errored out when regenerating the autoloads for vlf-write.el: >>=20 Robert> Debugger entered--Lisp error: (search-failed "\n\f\n;;;") Robert> search-forward("\n\f\n;;;") Robert> loaddefs-generate("/home/rpluim/.emacs.d/elpa/vlf-20191126.2250= " "/home/rpluim/.emacs.d/elpa/vlf-20191126.2250/vlf-a..." nil "(add-to-list= 'load-path (or (and load-file-name (f...") Robert> package-generate-autoloads(vlf "/home/rpluim/.emacs.d/elpa/vlf-= 20191126.2250") >>=20 >> The minimal patch I can come up with is this, which seems safe enough >> but I=CA=BCd appreciate it if someone who knows the code could comme= nt Eli> Can you describe what was special in your use case, and explain why Eli> the original code didn't work in that case? It=CA=BCs not the use case that=CA=BCs special, it=CA=BCs the package I was= installing: The autoloads file shipped with vlf-20191126.2250 didn=CA=BCt have a line starting with ';;;' after the final entry in the file, which is what the code was looking for. Looking at the history, the autoloads generation was rewritten for emacs-29, so this looks like a minor regression. Robert --=20