unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Robert Pluim <rpluim@gmail.com>
To: Eli Zaretskii <eliz@gnu.org>
Cc: 63236@debbugs.gnu.org
Subject: bug#63236: 29.0.90; loaddefs-generate not 100% backwards compatible
Date: Wed, 03 May 2023 15:47:21 +0200	[thread overview]
Message-ID: <87wn1pjzme.fsf@gmail.com> (raw)
In-Reply-To: <83bkj1mzj2.fsf@gnu.org> (Eli Zaretskii's message of "Wed, 03 May 2023 14:21:05 +0300")

>>>>> On Wed, 03 May 2023 14:21:05 +0300, Eli Zaretskii <eliz@gnu.org> said:

    >> From: Robert Pluim <rpluim@gmail.com>
    >> Date: Wed, 03 May 2023 10:40:28 +0200
    >> 
    >> >>>>> On Tue, 02 May 2023 19:06:14 +0200, Robert Pluim <rpluim@gmail.com> said:
    >> 
    Robert> I attempted to upgrade my packages today using `list-packages', which
    Robert> errored out when regenerating the autoloads for vlf-write.el:
    >> 
    Robert> Debugger entered--Lisp error: (search-failed "\n\f\n;;;")
    Robert> search-forward("\n\f\n;;;")
    Robert> loaddefs-generate("/home/rpluim/.emacs.d/elpa/vlf-20191126.2250" "/home/rpluim/.emacs.d/elpa/vlf-20191126.2250/vlf-a..." nil "(add-to-list 'load-path (or (and load-file-name (f...")
    Robert> package-generate-autoloads(vlf "/home/rpluim/.emacs.d/elpa/vlf-20191126.2250")
    >> 
    >> The minimal patch I can come up with is this, which seems safe enough
    >> but Iʼd appreciate it if someone who knows the code could comment

    Eli> Can you describe what was special in your use case, and explain why
    Eli> the original code didn't work in that case?

Itʼs not the use case thatʼs special, itʼs the package I was installing:
The autoloads file shipped with vlf-20191126.2250 didnʼt have a line
starting with ';;;' after the final entry in the file, which is what
the code was looking for.

Looking at the history, the autoloads generation was rewritten for
emacs-29, so this looks like a minor regression.

Robert
-- 





  reply	other threads:[~2023-05-03 13:47 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-05-02 17:06 bug#63236: 29.0.90; loaddefs-generate not 100% backwards compatible Robert Pluim
2023-05-03  8:40 ` Robert Pluim
2023-05-03  8:48   ` Andreas Schwab
2023-05-03 11:21   ` Eli Zaretskii
2023-05-03 13:47     ` Robert Pluim [this message]
2023-05-03 15:02       ` Robert Pluim
2023-05-03 15:50       ` Eli Zaretskii
2023-05-04  8:45         ` Robert Pluim
2023-05-04 10:42           ` Eli Zaretskii
2023-05-04 14:04             ` Robert Pluim

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87wn1pjzme.fsf@gmail.com \
    --to=rpluim@gmail.com \
    --cc=63236@debbugs.gnu.org \
    --cc=eliz@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).