From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Philip Kaludercic Newsgroups: gmane.emacs.bugs Subject: bug#60418: [PATCH] Add :vc keyword to use-package Date: Sat, 06 May 2023 18:50:02 +0000 Message-ID: <87wn1lguqt.fsf@posteo.net> References: <87zgb6uk2r.fsf@hyperspace> <87wn2bzvcp.fsf@hyperspace> <835y9vbyfr.fsf@gnu.org> <87mt36uwl8.fsf@hyperspace> <83ttxd8k1z.fsf@gnu.org> <87v8hrn56l.fsf@hyperspace> <87cz3w2lvb.fsf@posteo.net> <87jzy3ku6u.fsf@hyperspace> <87bkje93ou.fsf@posteo.net> <87y1mhihhy.fsf@hyperspace> <87ildbet2d.fsf@hyperspace> <831qjyoqj5.fsf@gnu.org> <87h6suolt2.fsf@hyperspace> <83ttwun4q4.fsf@gnu.org> <87o7n0fr9e.fsf@hyperspace> <878re3cqro.fsf@posteo.net> <83ild7jq5c.fsf@gnu.org> <87v8h7ba55.fsf@posteo.net> <83zg6ji806.fsf@gnu.org> <87wn1mlmwx.fsf@posteo.net> <83v8h6hb2q.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="12185"; mail-complaints-to="usenet@ciao.gmane.io" Cc: soliditsallgood@mailbox.org, felician.nemeth@gmail.com, 60418@debbugs.gnu.org, stefankangas@gmail.com To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat May 06 20:51:17 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pvN01-0002y3-Ca for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 06 May 2023 20:51:17 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pvMzn-00073r-82; Sat, 06 May 2023 14:51:03 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pvMzm-00073H-FD for bug-gnu-emacs@gnu.org; Sat, 06 May 2023 14:51:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pvMzm-0004DN-6N for bug-gnu-emacs@gnu.org; Sat, 06 May 2023 14:51:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pvMzl-0004D0-TS for bug-gnu-emacs@gnu.org; Sat, 06 May 2023 14:51:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Philip Kaludercic Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 06 May 2023 18:51:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 60418 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 60418-submit@debbugs.gnu.org id=B60418.168339901415962 (code B ref 60418); Sat, 06 May 2023 18:51:01 +0000 Original-Received: (at 60418) by debbugs.gnu.org; 6 May 2023 18:50:14 +0000 Original-Received: from localhost ([127.0.0.1]:35762 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pvMz0-00049O-5V for submit@debbugs.gnu.org; Sat, 06 May 2023 14:50:14 -0400 Original-Received: from mout02.posteo.de ([185.67.36.66]:59513) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pvMyv-000492-Ic for 60418@debbugs.gnu.org; Sat, 06 May 2023 14:50:13 -0400 Original-Received: from submission (posteo.de [185.67.36.169]) by mout02.posteo.de (Postfix) with ESMTPS id D3FFD240106 for <60418@debbugs.gnu.org>; Sat, 6 May 2023 20:50:03 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1683399003; bh=CLSvuamhcyVwNxBdc5SY63etOnBbGIsSPrtD2hnBfh0=; h=From:To:Cc:Subject:Autocrypt:Date:From; b=Q8oYMzhGGe2+syO9z3Lheam/9AsMdMfniZItjLyQXVLqCAJgnaOBZ9EecfXSvEEjE xeKPRfWBEEEu6Dt5qJkYvfm05jeb80KLJKHpAhJZtQXfiE4AtUeltljczd9Q3vDvS3 H1TgIndODt2yaq+kyu9osY0dhEK3dK/xud9FmvTqVWNVEOuWwNf/8FqrDj9SPW7kVX fXsNaPtzaX1z7y3mAFy8fVqr+KDDeC3UnZzuhduhT92NffTibaXYlkpe19CmBtbjET txfiLr+IZE5m4MSnRmwfUl8/bHdIw5pcQfVTYPxgQwdtr+V7FuzevzVozbd9cL3mJi ZLie2sYHA0niw== Original-Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4QDGnl1yNLz6tm4; Sat, 6 May 2023 20:50:03 +0200 (CEST) In-Reply-To: <83v8h6hb2q.fsf@gnu.org> (Eli Zaretskii's message of "Fri, 05 May 2023 21:45:01 +0300") Autocrypt: addr=philipk@posteo.net; keydata= mDMEZBBQQhYJKwYBBAHaRw8BAQdAHJuofBrfqFh12uQu0Yi7mrl525F28eTmwUDflFNmdui0QlBo aWxpcCBLYWx1ZGVyY2ljIChnZW5lcmF0ZWQgYnkgYXV0b2NyeXB0LmVsKSA8cGhpbGlwa0Bwb3N0 ZW8ubmV0PoiWBBMWCAA+FiEEDg7HY17ghYlni8XN8xYDWXahwukFAmQQUEICGwMFCQHhM4AFCwkI BwIGFQoJCAsCBBYCAwECHgECF4AACgkQ8xYDWXahwulikAEA77hloUiSrXgFkUVJhlKBpLCHUjA0 mWZ9j9w5d08+jVwBAK6c4iGP7j+/PhbkxaEKa4V3MzIl7zJkcNNjHCXmvFcEuDgEZBBQQhIKKwYB BAGXVQEFAQEHQI5NLiLRjZy3OfSt1dhCmFyn+fN/QKELUYQetiaoe+MMAwEIB4h+BBgWCAAmFiEE Dg7HY17ghYlni8XN8xYDWXahwukFAmQQUEICGwwFCQHhM4AACgkQ8xYDWXahwukm+wEA8cml4JpK NeAu65rg+auKrPOP6TP/4YWRCTIvuYDm0joBALw98AMz7/qMHvSCeU/hw9PL6u6R2EScxtpKnWof z4oM X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:261211 Archived-At: Eli Zaretskii writes: >> From: Philip Kaludercic >> Cc: soliditsallgood@mailbox.org, 60418@debbugs.gnu.org, >> felician.nemeth@gmail.com, stefankangas@gmail.com >> Date: Fri, 05 May 2023 17:15:42 +0000 >>=20 >> Eli Zaretskii writes: >>=20 >> >> No, the commit of the latest release is interpreted the same way as >> >> elpa-admin.el does, namely the last revision that modified the "Versi= on" >> >> header. If no such commit can be found, then a message is printed out >> >> and the installation continues under the assumption that the package = is >> >> using a rolling-release model. >> > >> > I thought package-vc-install is used (or at least can be used) to >> > fetch the latest HEAD from the upstream repository? I even thought >> > this was its main raison d'=C3=AAtre? >> > >> > If that's not true, does it mean we have no means for package users to >> > track the latest development code of a package? >>=20 >> This is true, for package-vc-install, but the idea was not do this for >> the :vc keyword to use-package. > > But I wrote the above as a comment to a patch to package-vc.el, not to > use-package. So why use-package is relevant here? Because this patch is related to use-package, and a keyword that would allow for use-package to invoke package-vc-install? >> My understanding is that the main >> interest here is to install packages that are not available via package >> archives. And as use-package is a popular means of bootstrapping a >> configuration, it seems the right approach to use the commit of the >> latest revision, instead of just any commit to avoid instability. > > My understanding is that the :rev keyword allows to use any value that > is acceptable to package-vc-install.=20=20 Right, and what is acceptable to package-vc-install is what is transitively acceptable to `vc-clone'/`vc-retrieve-tag'. > I understand that in most cases > users will want to install the latest,=20 I don't know if that is the case. I might be wrong that the revision of the latest release is a good default? Tony, do you think we should add a user-option to regulate this behaviour. > but once we decided to support > :rev, we must allow any valid value there. Right? Yes. >> By default, this function installs the last revision of the >> package available from its repository. If REV is a string, it >> describes the revision to install, as interpreted by the VC >> backend. The special value `:last-release' (interactively, the >> prefix argument), will use the commit of the latest release, if >> it exists. The latest revision is determined by the latest > ^^^^^^^^^^^^^^^ > "last release", not "latest revision": you are explaining what the > previous sentence said. Whoops, of course. >> revision to modify the \"Version\" header of the main file. >>=20 >> But I couldn't come up with an elegant way to avoid the passive voice in >> the last sentence. > > Here's one way: > > The last release is the latest revision which changed the > \"Version:\" header of the package's main Lisp file. Yes, sounds good. Will apply this change.