From: "João Távora" <joaotavora@gmail.com>
To: Felician Nemeth <felician.nemeth@gmail.com>
Cc: sebastian.poeplau@mailbox.org, adonovan@google.com,
62116@debbugs.gnu.org
Subject: bug#62116: RFE: eglot: support window.showDocument LSP RPC
Date: Sat, 13 May 2023 12:57:38 +0100 [thread overview]
Message-ID: <87wn1c4f65.fsf@gmail.com> (raw)
In-Reply-To: <877ctc8rc9.fsf@betli.tmit.bme.hu> (Felician Nemeth's message of "Sat, 13 May 2023 12:21:10 +0200")
Felician Nemeth <felician.nemeth@gmail.com> writes:
>> + uri external takeFocus selection)
>> + "Handle request window/showDocument."
>> + (if (eq external t) (browse-url uri)
>> + (let* (;; requests run with a let-bound `eglot--cached-server',
>> + ;; but when finding files from handlers, this fools
>> + ;; `eglot--maybe-activate-editing-mode'.
>> + (eglot--cached-server nil))
>
> (I don't understand this part.)
If you look up to near line 1308, you'll notice that the client handlers
for server requests run with `eglot--cached-server` let-bound. This, in
turn makes every subsequent call to `eglot--maybe-a-e-m` activate the
eglot--managed-mode minor mode. There are, unexpectedly, a couple of
calls to `eglot--maybe-a-e-m` but that's due to find-file's logic which
surprisingly temporarily activates another major mode when finding a
file. Apparently this is how it's always been. That first mode is
activated by a call to `major-mode` and then is replaced by a call to
the actual major-mode function, in this case `go-mode`.
>> + (with-current-buffer (find-file-noselect (eglot--uri-to-path uri))
>> + (cond (takeFocus
>> + (pop-to-buffer (current-buffer))
>
> Somehow switch-to-buffer feels more natural to me. But pop-to-buffer is
> probably a better choice.
I think you can do `display-buffer-alist` things to control it.
>> + (select-frame-set-input-focus (selected-frame)))
>> + ((display-buffer (current-buffer))))
>
> Even when takeFous is nil, shouldn't we still at least raise the frame?
> Otherwise Emacs might not show the document.
I don't understand. Can you show this problem. , I think display-buffer
ensures the buffer is displayed. It doesn't guarantee that it is
visible in the context of the windowing system, but that's another
matter.
>
>> + '(:success t))
>
> Regarding Alan's problem, one could argue that it can also be fixed on
> the server-side. However, there might be a general, but complex fix on
> Emacs' side as well: imenu can be modified to asynchronously generate
> its index when it just wants to show it in the menu (and not to users'
> direct request). Then the request of :textDocument/documentSymbol can
> be non-blocking as well. A simpler fix is to delay the opening of the
> file.
Yes, right. Making imenu or textDocument/documentSymbol asynchronous
would be too complex and async doesn't really fit in there. I think
Alan's problem indeed arises with something like imenu being in the
major-mode's hook, perhaps on behalf of which-func-mode. But that was
never confirmed. In the latest version of the patch I've just put a
run-with-timer in the Eglot request handler. It should solve the
conjectured Alan problem and also doesn't require the obscure
eglot--cached-server hack above.
>> I was about to push it, but let's hear your opinions first
> It is great, and I'd be happy if it went in as is. Thank you.
I pushed a version with the above adjustments to master, as we're
converging anyway and it's easier than trading patches.
João
next prev parent reply other threads:[~2023-05-13 11:57 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-10 15:34 bug#62115: RFE: eglot: support window.showDocument LSP RPC Alan Donovan via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-03-10 15:40 ` bug#62116: " Alan Donovan via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-03-11 12:56 ` João Távora
2023-03-11 13:17 ` Eli Zaretskii
2023-03-11 20:20 ` João Távora
2023-03-12 6:26 ` Eli Zaretskii
2023-04-22 9:08 ` Felician Nemeth
2023-05-05 6:03 ` Eli Zaretskii
2023-05-05 7:35 ` João Távora
2023-05-05 16:51 ` João Távora
2023-05-05 17:06 ` Alan Donovan via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-05-05 17:19 ` João Távora
2023-05-05 17:35 ` Alan Donovan via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-05-05 17:36 ` Alan Donovan via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-05-11 23:12 ` João Távora
2023-05-06 12:46 ` Felician Nemeth
2023-05-08 13:23 ` Felician Nemeth
2023-05-08 16:36 ` João Távora
2023-05-09 17:03 ` Felician Nemeth
2023-05-09 17:13 ` Alan Donovan via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-05-11 22:41 ` João Távora
2023-05-12 0:54 ` João Távora
2023-05-12 20:46 ` Alan Donovan via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-05-15 8:48 ` João Távora
2023-05-13 10:21 ` Felician Nemeth
2023-05-13 11:57 ` João Távora [this message]
2023-05-14 19:02 ` Felician Nemeth
2023-05-14 19:19 ` João Távora
2023-05-15 10:45 ` João Távora
2023-05-16 18:34 ` João Távora
2023-05-24 22:13 ` Alan Donovan via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-05-25 1:03 ` Dmitry Gutov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87wn1c4f65.fsf@gmail.com \
--to=joaotavora@gmail.com \
--cc=62116@debbugs.gnu.org \
--cc=adonovan@google.com \
--cc=felician.nemeth@gmail.com \
--cc=sebastian.poeplau@mailbox.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).