From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Robert Pluim Newsgroups: gmane.emacs.bugs Subject: bug#63731: [PATCH] Support Emoji Variation Sequence 16 (FE0F) where appropriate Date: Fri, 26 May 2023 18:24:02 +0200 Message-ID: <87wn0vkqn1.fsf@gmail.com> References: <87a5xrzsph.fsf@stebalien.com> <83pm6nlhll.fsf@gnu.org> <87v8gfmqyt.fsf@gmail.com> <83ilcflbua.fsf@gnu.org> <87mt1rmjjg.fsf@gmail.com> <83v8gfjnzj.fsf@gnu.org> <87edn3mbr3.fsf@gmail.com> <83mt1rjg69.fsf@gnu.org> <875y8fm7x7.fsf@gmail.com> <83lehbjdjd.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="16559"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 63731@debbugs.gnu.org, steven@stebalien.com To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri May 26 18:25:24 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1q2aFn-00043w-2n for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 26 May 2023 18:25:23 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1q2aFZ-0004Tr-AO; Fri, 26 May 2023 12:25:09 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1q2aFS-00048P-Se for bug-gnu-emacs@gnu.org; Fri, 26 May 2023 12:25:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1q2aFS-0005ZN-F7 for bug-gnu-emacs@gnu.org; Fri, 26 May 2023 12:25:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1q2aFS-00036k-8k for bug-gnu-emacs@gnu.org; Fri, 26 May 2023 12:25:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Robert Pluim Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 26 May 2023 16:25:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 63731 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 63731-submit@debbugs.gnu.org id=B63731.168511825211875 (code B ref 63731); Fri, 26 May 2023 16:25:02 +0000 Original-Received: (at 63731) by debbugs.gnu.org; 26 May 2023 16:24:12 +0000 Original-Received: from localhost ([127.0.0.1]:50661 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1q2aEd-00035T-NA for submit@debbugs.gnu.org; Fri, 26 May 2023 12:24:12 -0400 Original-Received: from mail-wm1-f47.google.com ([209.85.128.47]:55644) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1q2aEb-00035D-Vb for 63731@debbugs.gnu.org; Fri, 26 May 2023 12:24:10 -0400 Original-Received: by mail-wm1-f47.google.com with SMTP id 5b1f17b1804b1-3f6e1394060so6827275e9.3 for <63731@debbugs.gnu.org>; Fri, 26 May 2023 09:24:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1685118244; x=1687710244; h=content-transfer-encoding:mime-version:message-id:date:references :in-reply-to:subject:cc:to:from:from:to:cc:subject:date:message-id :reply-to; bh=0G4StLxcWTbgmfGH0KB0zGhpzQIxgWdZdkuVoNQDde4=; b=AlSIEmhW+g2ww6P+YYv5cgBQopQo9xLRTP/ng+d84luU/rFhDR9SjSFxzUga7V/nq7 rvYChEY07F/xtZRttg0x9yhKbJFWiFX3K2f2vWlO9j5coi8aOXDa05u4eHRqtVFedgBX UHtfaZTuPK8zJg0lJcN2vX3aR7ukrOwj10ql2ZBBa/5kI+zvan5baZpd0r768X7zboWB Hu+I/BY2tjXzZTn6uRDt4MZiCpTNmFxC1ZdJh+vJBNW3F5UIeyJu714/UJsov2OdcL+9 rQFkCbr3RChxFWsG9PA+KUEueUPAU9aRapWWQKaWy5eFLf0L9x3vIyno93t+4qPbH+ON lndQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1685118244; x=1687710244; h=content-transfer-encoding:mime-version:message-id:date:references :in-reply-to:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=0G4StLxcWTbgmfGH0KB0zGhpzQIxgWdZdkuVoNQDde4=; b=PsHdob+Z9WeYpHkpKvE3nGULwHyiTUk+SnDgoZ3y3k/CLMeAIScOEna6AXt0VMJcUY qXgaUx/pmaK8bjSZt8fQv4bMx+RTaeFPHzfYYG9XRlEutfx56nq4iC0Eb23fR0sD2CFR vJWnvvYBGtyreI36kFHTzePzF9i842uhN+WvgfvHE1X7kr6jgpggJ5pK1T2U5B7Ag1ch 5TivuDlcDmPi62TgIP2URmAOCWxRPfr34m1L35fgVXH8S+MvgG+6oIXjxnZNj6CAIGme k2oQEnaeJnMUknVQF/a9VbpkJWKOPjjY4Nosx0Pl9nX2hX1KxvTDUYxo5EbbuT/0Is6G qKew== X-Gm-Message-State: AC+VfDw1W8tos41u2wilJUcRKklMAfmDLS3jBBblmbSEuz4CQySkwRh1 Qpt+ZqSoE/F7Hlt3suXpV7c= X-Google-Smtp-Source: ACHHUZ4c4nIzsVE9JujX0bmOTZ5VA8UayijXATaZeIjFLZB6n2UxEXt1C9ZEJkQTHtVMnNHt0TXocg== X-Received: by 2002:adf:dc89:0:b0:306:37ac:ef8e with SMTP id r9-20020adfdc89000000b0030637acef8emr1815630wrj.56.1685118243689; Fri, 26 May 2023 09:24:03 -0700 (PDT) Original-Received: from rltb ([82.66.8.55]) by smtp.gmail.com with ESMTPSA id z14-20020a5d4c8e000000b003063938bf7bsm5521675wrs.86.2023.05.26.09.24.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 26 May 2023 09:24:03 -0700 (PDT) In-Reply-To: <83lehbjdjd.fsf@gnu.org> (Eli Zaretskii's message of "Fri, 26 May 2023 18:52:22 +0300") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:262445 Archived-At: >>>>> On Fri, 26 May 2023 18:52:22 +0300, Eli Zaretskii said: >> From: Robert Pluim >> Cc: steven@stebalien.com, 63731@debbugs.gnu.org >> Date: Fri, 26 May 2023 17:25:24 +0200 >>=20 Eli> Or are you saying that without including VS-15, CHAR+FE0E is not Eli> displayed using its text representation? >>=20 >> Not quite. If I don=CA=BCt have compose-gstring-for-graphic for VS-1= 5, no >> composition occurs for CHAR+FE0E. With my change you=CA=BCll get >> composition, but it=CA=BCs still not 100% correct: CHAR+FE0E when CH= AR is a >> member of the emoji script will use emoji presentation, not text, but >> the extra empty box will not show, so it=CA=BCs still an improvement. Eli> OK. And what about CHAR+FE0E when CHAR is not an Emoji? Then you get the (composed) text presentation (and the composed emoji presentation when it=CA=BCs CHAR+FE0F). Eli> Anyway, I think you should install the patch on emacs-29, and we Eli> should then try to fix the text-representation bug with VS-15 on Eli> master. (I guess it requires a change to font.c or something?) It requires something that answers the question "what font would we use for this codepoint if it was not an emoji?". Maybe we can have a separate fontset that pretends that the emoji script is equivalent to symbol? Or invent some kind of 'text-presentation-font' property to put somewhere? Eli> Did you test the proposed change with the admin/emoji-*.txt files,= to Eli> make sure they all still display OK? >>=20 >> Yes. I=CA=BCve also got a change that makes Emoji_Keycap_Sequence wo= rk, but >> I think we can leave that for master. Eli> Depends on the solution, I guess. Isn't it just a change to the Eli> VS-16's entry in composition-function-table? Or maybe a change in= the Eli> #x20e3's entry? (Did we discus the Emoji_Keycap_Sequence case bef= ore?) It=CA=BCs a change to the VS-16 entry. We did discuss it before, and decided to put it aside because the solutions all involved adding composition-function-table entries for 0-9 or similar. I don=CA=BCt remember why we didn=CA=BCt consider adding to VS-16=CA=BCs entry. I=CA=BCll do some more testing, and post a final version hopefully this weekend sometime. Robert --=20