From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Michael Heerdegen Newsgroups: gmane.emacs.bugs Subject: bug#14013: 24.3.50; dired-isearch-filenames-regexp is matching text outside filenames Date: Sat, 03 Jun 2023 00:29:33 +0200 Message-ID: <87wn0lpkfm.fsf@web.de> References: <87li9hk5e5.fsf@web.de> <87wqt1vd0o.fsf@mail.jurta.org> <87d2ut4mji.fsf@web.de> <87620lvavl.fsf@mail.jurta.org> <87zjxxsd6c.fsf@web.de> <87vc8ke4os.fsf@mail.jurta.org> <86zgmutwx9.fsf@mail.linkov.net> <87o83ab67d.fsf@web.de> <86r185520f.fsf@mail.linkov.net> <87czjn39yf.fsf@web.de> <86y2215rbn.fsf@mail.linkov.net> <87sfbar6j6.fsf@web.de> <86wn0m4fq0.fsf@mail.linkov.net> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="4925"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: Stefan Monnier , 14013@debbugs.gnu.org To: Juri Linkov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Jun 03 00:30:30 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1q5DHy-00016u-6f for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 03 Jun 2023 00:30:30 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1q5DHb-0001Do-Jc; Fri, 02 Jun 2023 18:30:07 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1q5DHY-0001D2-SD for bug-gnu-emacs@gnu.org; Fri, 02 Jun 2023 18:30:04 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1q5DHX-0001xj-If for bug-gnu-emacs@gnu.org; Fri, 02 Jun 2023 18:30:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1q5DHX-0001cw-75 for bug-gnu-emacs@gnu.org; Fri, 02 Jun 2023 18:30:03 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Michael Heerdegen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 02 Jun 2023 22:30:03 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 14013 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 14013-submit@debbugs.gnu.org id=B14013.16857449886198 (code B ref 14013); Fri, 02 Jun 2023 22:30:03 +0000 Original-Received: (at 14013) by debbugs.gnu.org; 2 Jun 2023 22:29:48 +0000 Original-Received: from localhost ([127.0.0.1]:40979 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1q5DHI-0001bt-Ae for submit@debbugs.gnu.org; Fri, 02 Jun 2023 18:29:48 -0400 Original-Received: from mout.web.de ([212.227.15.14]:44985) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1q5DHE-0001be-2N for 14013@debbugs.gnu.org; Fri, 02 Jun 2023 18:29:47 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=web.de; s=s29768273; t=1685744974; x=1686349774; i=michael_heerdegen@web.de; bh=dQ+VaGHL+UlM1bWb3qliSREVx9Zh0Lvhe4ArNhS7Bz8=; h=X-UI-Sender-Class:From:To:Cc:Subject:In-Reply-To:References:Date; b=M57pr+bpJcZxi6zNTfkyCuyKlo6iOTc5JVXNrkvbrzb7hu5Ux+N8+qsSbCqyZuYjxJl+l9Y EbC4L6MDgDlVnRLAMD4T0Xmj4hKsKP8zKk5Q0CTplVm9uwFFV8oaIebhX2cbeE59ekRnNcD0K 34TKrkVf4gwxDmjDrJVM6CsNQ0b5jB24q8jbAcgYmU4NteWMvXJRolSOTaVxCSD8mTgEoaZ0E mLdeNziWePCn53Fo9qKB5yfVgNV29+HsdWa8vFDcQlOGszCxmPKJA8l1AIafLxpl662ZBPoo2 IOvggoKOvBWPGt3ARLLDB4X23+ApHs4CU2Jg6uwAMPzTarHjObsA== X-UI-Sender-Class: 814a7b36-bfc1-4dae-8640-3722d8ec6cd6 Original-Received: from drachen.dragon ([178.14.74.62]) by smtp.web.de (mrweb005 [213.165.67.108]) with ESMTPSA (Nemesis) id 1N6sG3-1q8HIn1gI3-018NYo; Sat, 03 Jun 2023 00:29:34 +0200 In-Reply-To: <86wn0m4fq0.fsf@mail.linkov.net> (Juri Linkov's message of "Fri, 02 Jun 2023 09:28:39 +0300") X-Provags-ID: V03:K1:eQt4mq5Y4muwUjlNlTaujX+Yv9m0M1/Jc1epSsY4NmEutkvKlG8 LEWKAllGkqtXtWJsL/Yxe8/blmftR4uQF59Kwmw8oP6ZbhM1U5lAJaFWapt93YXKpkcA5RX /SmZKDvk8hD3CE7tN9teU9if7kmDB/hSp167rSGNhz4/fw35YIG7/J/6MqIzpW4VRqQBRLW ZVWL8Kom4PySlnLgs81iw== UI-OutboundReport: notjunk:1;M01:P0:5LldYNLq0Eo=;brnT58Iiryezl55bQ3ABOVCojN5 VSWSsXgzl1wkSaDfKV5ow8lfTjvuNUGG21UOiUJQ8lMPnql5eKWOJqNWrej7wVnX6qv2nJU0d ye3WACJapu2JOYDSYCzLhbG/GSRB97gsAeb9EhuG6QudTP3lnd5PKhTjHvaV3cWjldNVrlnnb bOP4uDOgBu3D9rkTNzChL3QQNPhYzqx6MSNeZV0YM3sZ+2Kyhox7FkWulaxy6gCOxBRw5oqh4 zVufs0iOH4Y97DXYe6ed5xSLEVrkoNTYIAcLD0MJtGz/L7lRPfJCaPp3EY0Z6XD/NkMHdNVNA vT+g9vqWIK1pe9n7ETYjCZI08tHtkJCTONjGCdQDGJmGB5i+VXfe3Ufa6vvT/3xHO3mhsQI47 GcK+rETADR4nFl76uPDTSXmPE6EIifchgbhGmvKg0As8sfHYJc1Da6ZQIywipSRFdFEFCScoe IEbzuTF/oLJ71rZAWTuraCVFRMBWy+NmU/He1j9RRms8fNM8j4QUn50L55u2SW/u2RcYSTe/+ c7Cy8rR20dxvpHtyQWQxM6o86r1EOYIhm1A0efjeZnVYIRLNyEKihHQ4UVJjzgAcGHKn58Vjt jsWyAdooCnhRkHyUQs3RlUyDLt3EDHs9VSiwF3hRktmDPrgpWzbqjlDGjHXs6blVF3VyYykOs GWYD5bEX+4QZloy5MGXE4wnzVH0K/MOl+fzMXN07FcrSxaIKzhfR2gn8qu0xOQ+1mypdh5CWk 4rcF+9xyrlw0lPCwKRHiJwv1q1kAjesqGWLnElG0b6P6edBk0k4lj+TB+udvZvvGwT479LwD X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:262786 Archived-At: Juri Linkov writes: > >> - (remove-function (local 'isearch-filter-predicate) > >> - #'wdired-isearch-filter-read-only) > >> + (when wdired-search-replace-filenames > >> + (remove-function (local 'isearch-search-fun-function) > >> + #'dired-isearch-search-filenames) > >> + (kill-local-variable 'replace-search-function) > >> + (kill-local-variable 'replace-re-search-function)) > > > > Juri, when a user disables `wdired-search-replace-filenames' while still > > in wdired-mode, won't we fail to undo these settings when the user > > then returns to normal dired? - should we not better undo these things > > unconditionally? > > If these calls are idempotent, we could remove the condition. > Could you please confirm there is no adverse effect after removing this. Both `remove-function' and `k-l-variable' are documented to do nothing when the function to be removed is not present/ there is no local variable binding. > Also there is another call at the end that can't be removed: > > (add-hook 'isearch-mode-hook #'dired-isearch-filenames-setup nil t) I think we should remove the condition when entering wdired here (for the same reason). > > Second question: could we advice (local 'replace-search-function) and > > (local 'replace-re-search-function) instead of replacing the value (it > > might be nicer to users of other packages)? > > This looks nicer in theory. But in practice I expect to see a lot of > conflicts. What conflicts? Michael.