From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Vladimir Sedach Newsgroups: gmane.emacs.bugs Subject: bug#64311: [PATCH] Fix shell-dirtrack-mode showing up as enabled in unrelated buffers Date: Thu, 29 Jun 2023 10:26:38 -0600 Message-ID: <87wmzmb5fl.fsf@t510.orion.oneofus.la> References: <87pm5h4iy1.fsf@t510.orion.oneofus.la> <83h6qtw3tq.fsf@gnu.org> <87wmzp2e0d.fsf@t510.orion.oneofus.la> <831qhwx5qf.fsf@gnu.org> <87zg4k76es.fsf@orphne.orion.oneofus.la> <83mt0jvmfu.fsf@gnu.org> <87r0pva66g.fsf@t510.orion.oneofus.la> <834jmrv3p6.fsf@gnu.org> <87o7kz9wej.fsf@t510.orion.oneofus.la> <83wmzmuaq7.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="8275"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: mu4e 1.4.15; emacs 28.2 Cc: 64311@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Jun 29 18:27:20 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qEuUJ-0001xR-Mv for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 29 Jun 2023 18:27:20 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qEuU4-0002rc-TM; Thu, 29 Jun 2023 12:27:04 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qEuU3-0002rP-M3 for bug-gnu-emacs@gnu.org; Thu, 29 Jun 2023 12:27:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qEuU3-0000Zi-Au for bug-gnu-emacs@gnu.org; Thu, 29 Jun 2023 12:27:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qEuU2-0007pg-IT for bug-gnu-emacs@gnu.org; Thu, 29 Jun 2023 12:27:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Vladimir Sedach Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 29 Jun 2023 16:27:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 64311 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 64311-submit@debbugs.gnu.org id=B64311.168805600730085 (code B ref 64311); Thu, 29 Jun 2023 16:27:02 +0000 Original-Received: (at 64311) by debbugs.gnu.org; 29 Jun 2023 16:26:47 +0000 Original-Received: from localhost ([127.0.0.1]:53936 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qEuTm-0007pB-Qo for submit@debbugs.gnu.org; Thu, 29 Jun 2023 12:26:47 -0400 Original-Received: from robust-software.ca ([174.136.98.50]:35464) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qEuTi-0007oy-CT for 64311@debbugs.gnu.org; Thu, 29 Jun 2023 12:26:45 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; s=virgo1; bh=pysbR7p/Ztij5 opJchzxpZmMKWlhavpDOGHxD7uVVbo=; h=date:in-reply-to:subject:cc:to: from:references; d=oneofus.la; b=mFGvtCkg1sXQgY0FaqMTCdQuxAXZzefGUfdgq Gh54dhEqWN3LUPFvCVhpSn9f3qQS1Qc+0SGyLWr/zDXxZXvwF9vq5+3o6Z8ZiT9loRw8b3 aL45k8+xaU7BugOQDGXXHUtukI5eEft4UelS70OiiH8y/K8JZlprO0sl0SxymDgk= Original-Received: from t510.orion.oneofus.la (node-1w7jra28qzk6xj57njf87zz1o.ipv6.telus.net [2001:56a:f913:3c01:6067:9d9:8a35:d32c]) by virgo1.oneofus.la (OpenSMTPD) with ESMTPSA id 98b60d1c (TLSv1.3:TLS_AES_256_GCM_SHA384:256:NO); Thu, 29 Jun 2023 09:26:40 -0700 (PDT) In-reply-to: <83wmzmuaq7.fsf@gnu.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:264281 Archived-At: Eli Zaretskii writes: > So making the default value nil will solve the problem? Yes, but you are asking the wrong question. When I came upon this problem, the first questions I had were: what is the variable shell-dirtrackp, and why is it aliased to shell-dirtrack-mode? This is why I came up with a fix that follows the X-mode control variable convention, marks the redundant variable obsolete, replaces any leftover references to the redundant variable with shell-dirtrack-mode, and adds unit tests for the control paths of the affected code. Instead of a half-assed "let's just flip the value of this boolean flag" workaround, that doesn't help or explain anything to someone trying to work with shell.el -- Vladimir Sedach