From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Ihor Radchenko Newsgroups: gmane.emacs.bugs Subject: bug#64596: 30.0.50; On FIXME: in src/buffer.c:1481 (force-mode-line-update) Date: Wed, 19 Jul 2023 10:11:19 +0000 Message-ID: <87wmyww6rc.fsf@localhost> References: <877cr4nez9.fsf@localhost> <83lefj4okb.fsf@gnu.org> <83fs5r3tqv.fsf@gnu.org> <834jm6fppc.fsf@gnu.org> <87a5vyidy6.fsf@localhost> <83sf9qe2ip.fsf@gnu.org> <83a5vxejz6.fsf@gnu.org> <87ttu4gnpt.fsf@localhost> <83bkgb8xo5.fsf@gnu.org> <87jzuz1uq5.fsf@localhost> <83a5vv8edp.fsf@gnu.org> <87ttu2zydc.fsf@localhost> <83351m92jl.fsf@gnu.org> <87y1jeiw8t.fsf@localhost> <831qh6917k.fsf@gnu.org> <87msztv95v.fsf@localhost> <83cz0p780j.fsf@gnu.org> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="30104"; mail-complaints-to="usenet@ciao.gmane.io" Cc: monnier@iro.umontreal.ca, 64596@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Jul 19 12:12:26 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qM4AU-0007dy-16 for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 19 Jul 2023 12:12:26 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qM4AB-0004HX-8I; Wed, 19 Jul 2023 06:12:07 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qM4A7-00049z-85 for bug-gnu-emacs@gnu.org; Wed, 19 Jul 2023 06:12:04 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qM4A6-0000Em-F4 for bug-gnu-emacs@gnu.org; Wed, 19 Jul 2023 06:12:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qM4A5-0000a6-Uu for bug-gnu-emacs@gnu.org; Wed, 19 Jul 2023 06:12:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Ihor Radchenko Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 19 Jul 2023 10:12:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 64596 X-GNU-PR-Package: emacs Original-Received: via spool by 64596-submit@debbugs.gnu.org id=B64596.16897614792187 (code B ref 64596); Wed, 19 Jul 2023 10:12:01 +0000 Original-Received: (at 64596) by debbugs.gnu.org; 19 Jul 2023 10:11:19 +0000 Original-Received: from localhost ([127.0.0.1]:55005 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qM49O-0000ZD-S6 for submit@debbugs.gnu.org; Wed, 19 Jul 2023 06:11:19 -0400 Original-Received: from mout01.posteo.de ([185.67.36.65]:35307) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qM49M-0000Yy-2x for 64596@debbugs.gnu.org; Wed, 19 Jul 2023 06:11:17 -0400 Original-Received: from submission (posteo.de [185.67.36.169]) by mout01.posteo.de (Postfix) with ESMTPS id BF284240027 for <64596@debbugs.gnu.org>; Wed, 19 Jul 2023 12:11:09 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1689761469; bh=DCnhQqI2nf9QL3r17MiWpeXO24XFrFXGfhpDU+uAa40=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version:From; b=mjz8FRH8Skz3ush5stUAfANdGygsuCDX9JzH0Qa75Px1DF+WsBRBJH4W4ETgTYjFT 0nhdw1TRZtlSC3twdceUDHke+pTaWagMWJgUUhNWaqzARcZ9ufpBEz5s00LaLMYYWT 0+HF1YeRnapR6ilkFHV7EsTCRf0BXnvcTFzNFeorFSQwexUQJIUmLBSy9xSPV/NOLG 1hjZj1l0oDTzaabUmQARA4gyDceQBHLHj9T9jo46MQLrHnJb8po3iIqCIDjM1mRuZN itIwqKtp8MTcOZB3wTMwB/QErYk1G6ViTnUB9S5MWlg8/C3bQo8zU333Cupf6rSXjm 7JimEk/zIZD8Q== Original-Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4R5Wmr3nKtz9rxM; Wed, 19 Jul 2023 12:11:08 +0200 (CEST) In-Reply-To: <83cz0p780j.fsf@gnu.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:265521 Archived-At: --=-=-= Content-Type: text/plain Eli Zaretskii writes: >> I saw this. But "update" is not used consistently across that >> commentary. > > Tough. "Update" is too general a word to limit is use. Sorry. May it be replaced by another, more precise, term then? >> If we read at the very beginning: >> >> /* New redisplay written by Gerd Moellmann . >> >> Redisplay. >> >> Emacs separates the task of updating the display from code >> modifying global state, e.g. buffer text. ... >> >> Updating the display is triggered by the Lisp interpreter when it >> decides it's time to do it.... >> >> Which immediately creates an impression that "redisplay" and "update" >> are referring to the same thing. > > There's no practical way to avoid all the possible misinterpretations > of this large and complex text, especially when it is read for the > first time. What about the attached patch? --=-=-= Content-Type: text/x-patch Content-Disposition: inline; filename=0001-src-xdisp.c-Clarify-the-meaning-of-update-term-in-co.patch >From 2be256093307246f8a3a62a5613467ceb6e7e9b8 Mon Sep 17 00:00:00 2001 Message-ID: <2be256093307246f8a3a62a5613467ceb6e7e9b8.1689761362.git.yantar92@posteo.net> From: Ihor Radchenko Date: Wed, 19 Jul 2023 13:08:54 +0300 Subject: [PATCH] * src/xdisp.c: Clarify the meaning of "update" term in commentary See bug#64596. --- src/xdisp.c | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/src/xdisp.c b/src/xdisp.c index a3464c2c375..b306159c2f9 100644 --- a/src/xdisp.c +++ b/src/xdisp.c @@ -75,6 +75,13 @@ Copyright (C) 1985-2023 Free Software Foundation, Inc. and to make these changes visible. Preferably it would do that in a moderately intelligent way, i.e. fast. + To be as fast as possible, redisplay code tries hard to avoid + updating unchanged parts of the display on the glass. Redisplay + process starts from examining what has been changed since the + previous redisplay and only running the glass _update_ action when + necessary. In the code below, functions and variables related to + updating on the glass will have _update_ in their names. + Changes in buffer text can be deduced from window and buffer structures, and from some global variables like `beg_unchanged' and `end_unchanged'. The contents of the display are additionally -- 2.41.0 --=-=-= Content-Type: text/plain -- Ihor Radchenko // yantar92, Org mode contributor, Learn more about Org mode at . Support Org development at , or support my work at --=-=-=--