From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Philip Kaludercic Newsgroups: gmane.emacs.bugs Subject: bug#64799: [PATCH] Add 'project-prompt-key' face Date: Sun, 23 Jul 2023 13:41:43 +0000 Message-ID: <87wmyqhhig.fsf@posteo.net> References: <87zg3nqbuc.fsf@protesilaos.com> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="2634"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 64799@debbugs.gnu.org To: Protesilaos Stavrou Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Jul 23 15:42:17 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qNZLl-0000Te-N2 for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 23 Jul 2023 15:42:17 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qNZLX-00008F-L5; Sun, 23 Jul 2023 09:42:03 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qNZLW-000084-9t for bug-gnu-emacs@gnu.org; Sun, 23 Jul 2023 09:42:02 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qNZLW-0004Vh-25 for bug-gnu-emacs@gnu.org; Sun, 23 Jul 2023 09:42:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qNZLV-0003Us-UA for bug-gnu-emacs@gnu.org; Sun, 23 Jul 2023 09:42:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Philip Kaludercic Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 23 Jul 2023 13:42:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 64799 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 64799-submit@debbugs.gnu.org id=B64799.169011971713432 (code B ref 64799); Sun, 23 Jul 2023 13:42:01 +0000 Original-Received: (at 64799) by debbugs.gnu.org; 23 Jul 2023 13:41:57 +0000 Original-Received: from localhost ([127.0.0.1]:39043 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qNZLQ-0003UX-SO for submit@debbugs.gnu.org; Sun, 23 Jul 2023 09:41:57 -0400 Original-Received: from mout02.posteo.de ([185.67.36.66]:49665) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qNZLL-0003UH-Hv for 64799@debbugs.gnu.org; Sun, 23 Jul 2023 09:41:55 -0400 Original-Received: from submission (posteo.de [185.67.36.169]) by mout02.posteo.de (Postfix) with ESMTPS id EA436240106 for <64799@debbugs.gnu.org>; Sun, 23 Jul 2023 15:41:44 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1690119704; bh=rob5Y8mMv5PG/X4aAgSSPYCeTWHy1dwAf1SOTamtbs0=; h=From:To:Cc:Subject:Autocrypt:Date:Message-ID:MIME-Version:From; b=nUAKEij+a7czhaSiDAe1GNfMPGhf4JEMYRJhn3j63gueA2bZC7GIKf8OSirb8ZjJK dsOVQUjB8qkw5VbB8z9rwcZsz/ywDaFGGFHVLDteaeVSRTZ3VDfrnIz3e4kDmFXd4T qTumkkKpjYqR+H6fBltphx9O8gUl30mdXkW6qQLjU1hT6TJBVrurixC0a90nu0aqZZ P8vmOtURDXhW0DN6izOcAptcDzamLbHixyXKUOlJ5JS08pLAB7somSvZdiB/wjwRGb d9+PvMC7XREdFHW2Z8hBmEtUUAwccQdAks/2nfih1qRyFN7rNBsOlQV82eVDo7kgde Tpjkgmy4d3+tg== Original-Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4R84G03qvYz9ry0; Sun, 23 Jul 2023 15:41:44 +0200 (CEST) In-Reply-To: <87zg3nqbuc.fsf@protesilaos.com> (Protesilaos Stavrou's message of "Sun, 23 Jul 2023 11:19:23 +0300") Autocrypt: addr=philipk@posteo.net; keydata= mDMEZBBQQhYJKwYBBAHaRw8BAQdAHJuofBrfqFh12uQu0Yi7mrl525F28eTmwUDflFNmdui0QlBo aWxpcCBLYWx1ZGVyY2ljIChnZW5lcmF0ZWQgYnkgYXV0b2NyeXB0LmVsKSA8cGhpbGlwa0Bwb3N0 ZW8ubmV0PoiWBBMWCAA+FiEEDg7HY17ghYlni8XN8xYDWXahwukFAmQQUEICGwMFCQHhM4AFCwkI BwIGFQoJCAsCBBYCAwECHgECF4AACgkQ8xYDWXahwulikAEA77hloUiSrXgFkUVJhlKBpLCHUjA0 mWZ9j9w5d08+jVwBAK6c4iGP7j+/PhbkxaEKa4V3MzIl7zJkcNNjHCXmvFcEuDgEZBBQQhIKKwYB BAGXVQEFAQEHQI5NLiLRjZy3OfSt1dhCmFyn+fN/QKELUYQetiaoe+MMAwEIB4h+BBgWCAAmFiEE Dg7HY17ghYlni8XN8xYDWXahwukFAmQQUEICGwwFCQHhM4AACgkQ8xYDWXahwukm+wEA8cml4JpK NeAu65rg+auKrPOP6TP/4YWRCTIvuYDm0joBALw98AMz7/qMHvSCeU/hw9PL6u6R2EScxtpKnWof z4oM X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:265904 Archived-At: Protesilaos Stavrou writes: > Dear maintainers, > > I noticed that the project switching dispatch menu hardcodes its face to > 'bold'. Adding a new face here allows themes/users to customise that > style (e.g. to inherit the 'help-key-binding' face). Does this even need a separate face, or shouldn't `help-key-binding' be reused directly? > This is the least intrusive change, though I would personally also > remove the square brackets from the format specifier. > > What do you think? > > All the best, > Protesilaos (or simply "Prot") > > -- > Protesilaos Stavrou > https://protesilaos.com > >>>From fcef17068821bd05e281dc75452c807bbc27c8dd Mon Sep 17 00:00:00 2001 > Message-ID: > From: Protesilaos Stavrou > Date: Sun, 23 Jul 2023 10:55:37 +0300 > Subject: [PATCH] Add 'project-prompt-key' face > > * etc/NEWS: Announce the face. > * lisp/progmodes/project.el (project-prompt-key): Define the face. > (project--keymap-prompt): Use the face. > --- > etc/NEWS | 4 ++++ > lisp/progmodes/project.el | 5 ++++- > 2 files changed, 8 insertions(+), 1 deletion(-) > > diff --git a/etc/NEWS b/etc/NEWS > index 5883b4df2a7..70d0bf18f50 100644 > --- a/etc/NEWS > +++ b/etc/NEWS > @@ -82,6 +82,10 @@ This allows the user to customize the prompt that is appended by > This is used for displaying the time and date components of > 'display-time-mode'. > > +--- > +** New face 'project-prompt-key'. > +This is used in the Project switch commands prompt. > + > --- > ** New icon images for general use. > Several symbolic icons are added to "etc/images/symbols", including > diff --git a/lisp/progmodes/project.el b/lisp/progmodes/project.el > index 03ed966cc45..c2deec7c38d 100644 > --- a/lisp/progmodes/project.el > +++ b/lisp/progmodes/project.el > @@ -1821,6 +1821,9 @@ (defcustom project-switch-use-entire-map nil > :group 'project > :version "28.1") > > +(defface project-prompt-key '((t :inherit bold)) > + "Face for keys in the Project switch commands prompt.") > + > (defun project--keymap-prompt () > "Return a prompt for the project switching dispatch menu." > (mapconcat > @@ -1834,7 +1837,7 @@ (defun project--keymap-prompt () > (vector key) > (where-is-internal cmd (list project-prefix-map) t)))) > (format "[%s] %s" > - (propertize (key-description key) 'face 'bold) > + (propertize (key-description key) 'face 'project-prompt-key) > label))) > project-switch-commands > " "))