From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Manphiz Newsgroups: gmane.emacs.bugs Subject: bug#65882: 29.1; rcirc doesn't rejoin channels automatically on reconnecting Date: Fri, 15 Sep 2023 01:15:21 -0700 Message-ID: <87wmwram3q.fsf@debian-hx90.lan> References: <87bke85hsb.fsf@gmail.com> <87a5tobby9.fsf@debian-hx90.lan> <871qf0atqs.fsf@debian-hx90.lan> <878r97ooxs.fsf@posteo.net> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="8636"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) Cc: 65882@debbugs.gnu.org, Ryan Yeske , Stefan Kangas , Leo Liu To: Philip Kaludercic Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Sep 15 15:05:23 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qh8Vf-00021R-GE for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 15 Sep 2023 15:05:23 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qh8VI-0008Mc-Dp; Fri, 15 Sep 2023 09:05:00 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qh8VF-0008LA-Ha for bug-gnu-emacs@gnu.org; Fri, 15 Sep 2023 09:04:57 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qh8VF-0002vT-8R for bug-gnu-emacs@gnu.org; Fri, 15 Sep 2023 09:04:57 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qh8VL-0007l3-Ld for bug-gnu-emacs@gnu.org; Fri, 15 Sep 2023 09:05:03 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Manphiz Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 15 Sep 2023 13:05:03 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 65882 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 65882-submit@debbugs.gnu.org id=B65882.169478304529701 (code B ref 65882); Fri, 15 Sep 2023 13:05:03 +0000 Original-Received: (at 65882) by debbugs.gnu.org; 15 Sep 2023 13:04:05 +0000 Original-Received: from localhost ([127.0.0.1]:42412 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qh8UM-0007ia-FG for submit@debbugs.gnu.org; Fri, 15 Sep 2023 09:04:05 -0400 Original-Received: from mail-pj1-x1029.google.com ([2607:f8b0:4864:20::1029]:45562) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qh3zE-0008FK-4E for 65882@debbugs.gnu.org; Fri, 15 Sep 2023 04:15:38 -0400 Original-Received: by mail-pj1-x1029.google.com with SMTP id 98e67ed59e1d1-27499bb759cso362047a91.3 for <65882@debbugs.gnu.org>; Fri, 15 Sep 2023 01:15:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1694765723; x=1695370523; darn=debbugs.gnu.org; h=mime-version:user-agent:message-id:in-reply-to:date:references :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=lSgLjyl8EdqkdKlovGof7jOEbeFRSe3dX5q3ZDj0lHA=; b=OTl/D5MgisnU5QfuVqaADowKDRCzbwokBLalP+I+QoiLhlb1UlnsFUbQdr7F/9bc3q RJAGTC7GWgtsxwAXmYK0X350NmEgvJ7+Y8UvDTryxBS3KxJtrULZ+SKf4NKnpz+1Y0en DpXX4mLQQ7L91b+E/D9OUAvg2qM9l3yZWcrL1zLvWDi/4lR7/sy5JROh1nox/fmwiEtg 2sc3wtEZW9CISrY/tF6hvtJ4uTVRRJ5wouqe8TFtu5DzyCdTSjyVSoSzaIhh3l0L/una nFNW41aSBB0Tv24/gW62j60qwrZl5/QYfgBvT2IUW/IiU3ll6MMkSWvUUjuiuaKBvuwE 3IdA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1694765723; x=1695370523; h=mime-version:user-agent:message-id:in-reply-to:date:references :subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=lSgLjyl8EdqkdKlovGof7jOEbeFRSe3dX5q3ZDj0lHA=; b=kWaLQ9SxWspIcXx5QuAKGEQUGc+dGBrIJexhw9aSmCmek4Ue3F4cEB4fbsou3iWns4 42agi2rra7e6YP9gsMAjIIuXoxlJYai7JExqf3zOPTxviiwj/vW4Xo85WNWct9f8sfBX lc8hMt0I6vTDobhZsRFYkIkoa5VyEpDQjxUH4EtKbl+m+huS9yH9aX7jBqSeV22MQa7i HOSPQEBOLcJkKF8HRqAQkkLFjSvw3y8/VkteSQxrbF7MQxKcQi4YD50ymF23TIZOjE88 4UngtjeURcYWrPkDK9Dg5FGbkFTeroCZW/pXPL52c8d3nZ9JYfs6MUjlSoAiq0DoIeus 3UmA== X-Gm-Message-State: AOJu0Yx8xTGJ1VRsoBi/5Nv8jIHqnbkz4xH/zW0QiJmKV84KimkukYOm +5X8UdmC3QPCpqZpoh7ZMpo= X-Google-Smtp-Source: AGHT+IGAVhS5OAkhZatKRBL3Eab60Z+EXuVzfEvKAWYj6W5YD8+8AptFNzu4/hlpEYkG/yq2vNLeXQ== X-Received: by 2002:a17:90a:e512:b0:273:f017:cac0 with SMTP id t18-20020a17090ae51200b00273f017cac0mr750376pjy.39.1694765723392; Fri, 15 Sep 2023 01:15:23 -0700 (PDT) Original-Received: from debian-hx90 (2603-8000-a400-0cdc-6a6c-5013-2246-54ab.res6.spectrum.com. [2603:8000:a400:cdc:6a6c:5013:2246:54ab]) by smtp.gmail.com with ESMTPSA id ga20-20020a17090b039400b0026b41363887sm869362pjb.27.2023.09.15.01.15.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 15 Sep 2023 01:15:22 -0700 (PDT) In-Reply-To: <878r97ooxs.fsf@posteo.net> (Philip Kaludercic's message of "Fri, 15 Sep 2023 07:50:23 +0000") X-Mailman-Approved-At: Fri, 15 Sep 2023 09:04:01 -0400 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:270535 Archived-At: Philip Kaludercic writes: > The change makes sense, but I'll want to try it out to make sure we are > doing the right thing. Unless I write something here, ping me in a few > days. Thanks Philip! Will do. > These kinds of auto-reconnect bugs can be annoying to debug in > real-life situations. > Indeed. Learned it the hard way when debugging this issue. > Manphiz writes: > >> Stefan Kangas writes: >> >>> severity 65882 + minor >>> thanks >>> >>> Manphiz writes: >>> >>>> I noticed that you lowered the severity of this bug from "normal" to >>>> "wishlist". AIUI rcirc provides a way to automatically join channels >>>> upon connecting to a server and currently this is not working as >>>> intended, so IMHO it should be considered a bug instead of a feature >>>> request (a wishlist). >>> >>> Thanks, so I bumped it to minor. I hope that makes more sense. >>> >> >> Thanks! >> >>>> (If you are using severity as a means to manage bug triage priority >>>> I'm OK with that.) >>> >>> My impression is that almost no one pays attention to bug severities, so >>> I wouldn't make too much of it. Bug reports that come with a patch, >>> like yours did, tend to get more visibility though. >>> >> >> Ah got it. It's my first time filing bug here so not very familiar with >> the convention. Looks like tagging patch was a good move :) > > So this patch would be applied without a copyright assignment, right? > Yes if it would mean that it can be included faster once approved, or whatever even faster means if you see fit :) >>>> Personally, as the patch is sufficiently trivial, I would hope it won't >>>> take too much work for a review. But I would understand if dealing with >>>> rcirc-user-authenticated is more involved than it looks like and should >>>> be handled with care. >>> >>> I've copied in the rcirc maintainers. Let's see if they have any >>> comments first. >> >> Great! Thanks again! -- Manphiz