From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Jonas Bernoulli via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#62751: 29.0.90; New libraries that still need to be assigned to packages Date: Mon, 18 Sep 2023 00:06:33 +0200 Message-ID: <87wmwobgk6.fsf@bernoul.li> References: <87zg7fyjka.fsf@bernoul.li> Reply-To: Jonas Bernoulli Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="39461"; mail-complaints-to="usenet@ciao.gmane.io" To: Stefan Kangas , 62751@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Sep 18 00:07:23 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qhzvG-000A45-3J for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 18 Sep 2023 00:07:22 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qhzus-0000XR-Tw; Sun, 17 Sep 2023 18:06:58 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qhzup-0000X8-8Y for bug-gnu-emacs@gnu.org; Sun, 17 Sep 2023 18:06:55 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qhzuo-0000OD-85 for bug-gnu-emacs@gnu.org; Sun, 17 Sep 2023 18:06:55 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qhzuv-00065P-PP for bug-gnu-emacs@gnu.org; Sun, 17 Sep 2023 18:07:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Jonas Bernoulli Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 17 Sep 2023 22:07:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 62751 X-GNU-PR-Package: emacs Original-Received: via spool by 62751-submit@debbugs.gnu.org id=B62751.169498841523382 (code B ref 62751); Sun, 17 Sep 2023 22:07:01 +0000 Original-Received: (at 62751) by debbugs.gnu.org; 17 Sep 2023 22:06:55 +0000 Original-Received: from localhost ([127.0.0.1]:51577 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qhzuo-000654-Qp for submit@debbugs.gnu.org; Sun, 17 Sep 2023 18:06:55 -0400 Original-Received: from mail.hostpark.net ([212.243.197.30]:41844) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qhzuk-00064k-Ai for 62751@debbugs.gnu.org; Sun, 17 Sep 2023 18:06:53 -0400 Original-Received: from localhost (localhost [127.0.0.1]) by mail.hostpark.net (Postfix) with ESMTP id A808F164CC; Mon, 18 Sep 2023 00:06:35 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=bernoul.li; h= content-type:content-type:mime-version:message-id:date:date :references:in-reply-to:subject:subject:from:from; s=sel2011a; t=1694988395; bh=4anmz1eDMooN1Kt5vFIGYUxkEl0L/F1a9nHOEqI9338=; b= TzFRDutpKph0L6RhOl/FO2OETjDA3+6ovnu8VyfdtCoa70cjAXjg2EwMB/fMVJ5F HDAniD3sAQBCG1YDAvXw9EiQcUnoHM/sZIAeJPQDdlXErxvVgRDicw5HkkdEJBYV feh5xeVvG1exoQ+RnbtAjskppfPolpJFM4d9jnW7uAg= X-Virus-Scanned: by Hostpark/NetZone Mailprotection at hostpark.net Original-Received: from mail.hostpark.net ([127.0.0.1]) by localhost (mail0.hostpark.net [127.0.0.1]) (amavisd-new, port 10224) with ESMTP id evds1CMsApNq; Mon, 18 Sep 2023 00:06:35 +0200 (CEST) Original-Received: from customer (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mail.hostpark.net (Postfix) with ESMTPSA id 47CCD164B4; Mon, 18 Sep 2023 00:06:35 +0200 (CEST) In-Reply-To: X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:270725 Archived-At: Thanks! Stefan Kangas writes: > Jonas Bernoulli writes: >> 4. All, or most, of the *-ts-mode.el probably should be treated as >> separate packages. > > I might be missing something, but isn't this already the case? It is. >> 9. It seems a bit excessive to consider each use-package*.el a separate >> package. Maybe they should all be part of a single use-package >> package. An entry in finder--builtins-alist should be used to >> accomplish that. > > Done. Maybe lisp/use-package/bind-key.el should be a separate package (and maybe it should be moved out of that directory). >> Maybe we should stop falling though to assign a new library to its own >> separate package, if nothing else is specified explicitly? It is of >> course nice not having to either add a "Package" library header or a >> finder--builtins-alist entry, but it also makes it easy to forget to >> explicitly specify the package when doing that would be necessary. > > Hmm, yes that might make more sense. One would have to add package > statements to a ton of libraries, though. So there'll be a lot of > churn. > > Maybe it's worth it in the end, I don't know. Probably not, but "carefully check any additions to package--builtins" should be added to the release steps. For the Emacsmirror I run code similar to `finder-compile-keywords'. (I don't use that function, mainly because I need more details for the Emacsmirror database, but also because for the last few releases there have always been issues like this, which I had to override.) For 29.1 I opened this issue, for 28.1 bug#55388. I have done that early enough so that it could have been taken into account before these releases shipped with questionable entries in package--builtins. I intend to do that well before the next release again. By the way, IMO it would make sense to apply these on "emacs-29", not just "master". >> Speaking of finder--builtins-alist, what about adding these entries?: >> ("leim" . emacs) >> ("obsolete" . emacs) > > Done. I think that has to be extended for "leim", similar to how there is a separate entry for every subdirectory of "lisp/semantic": ("leim" . emacs) +("ja-dic" . emacs) +("quail" . emacs) In addition to adding an entry for "lisp/obsolete", the "Package" header should be removed from all files in that directory. Please also have a look at bug#55388, a similar report for Emacs 28.1, which also has not been fully addressed yet. "lisp/emacs-lisp/shorthands.el" should provide a feature and be added to the "emacs" package.