From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: "Basil L. Contovounesios" via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#66150: 30.0.50; Duplicate :tag in remote-file-name-inhibit-cache Date: Fri, 22 Sep 2023 11:41:32 +0200 Message-ID: <87wmwimto3.fsf@epfl.ch> Reply-To: "Basil L. Contovounesios" Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="21018"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: Michael Albinus To: 66150@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Sep 22 11:43:14 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qjcgs-0005LW-GC for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 22 Sep 2023 11:43:14 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qjcgY-0000WW-Qd; Fri, 22 Sep 2023 05:42:54 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qjcgW-0000Ux-LN for bug-gnu-emacs@gnu.org; Fri, 22 Sep 2023 05:42:52 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qjcgW-0005NW-DT for bug-gnu-emacs@gnu.org; Fri, 22 Sep 2023 05:42:52 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qjcgg-0000ro-Gl; Fri, 22 Sep 2023 05:43:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: "Basil L. Contovounesios" Original-Sender: "Debbugs-submit" Resent-CC: michael.albinus@gmx.de, bug-gnu-emacs@gnu.org Resent-Date: Fri, 22 Sep 2023 09:43:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 66150 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch X-Debbugs-Original-To: bug-gnu-emacs@gnu.org X-Debbugs-Original-Xcc: Michael Albinus Original-Received: via spool by submit@debbugs.gnu.org id=B.16953757253266 (code B ref -1); Fri, 22 Sep 2023 09:43:02 +0000 Original-Received: (at submit) by debbugs.gnu.org; 22 Sep 2023 09:42:05 +0000 Original-Received: from localhost ([127.0.0.1]:35333 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qjcfk-0000qc-KJ for submit@debbugs.gnu.org; Fri, 22 Sep 2023 05:42:05 -0400 Original-Received: from lists.gnu.org ([2001:470:142::17]:48772) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qjcff-0000q6-Tq for submit@debbugs.gnu.org; Fri, 22 Sep 2023 05:42:03 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qjcfQ-00085N-01 for bug-gnu-emacs@gnu.org; Fri, 22 Sep 2023 05:41:44 -0400 Original-Received: from mail-ej1-x62c.google.com ([2a00:1450:4864:20::62c]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qjcfL-0005AS-NE for bug-gnu-emacs@gnu.org; Fri, 22 Sep 2023 05:41:43 -0400 Original-Received: by mail-ej1-x62c.google.com with SMTP id a640c23a62f3a-99c3c8adb27so240764266b.1 for ; Fri, 22 Sep 2023 02:41:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tcd.ie; s=google21; t=1695375695; x=1695980495; darn=gnu.org; h=mime-version:user-agent:message-id:date:subject:to:from:from:to:cc :subject:date:message-id:reply-to; bh=LjBikb3cxVmJWWHvYBLNyUNLTUJAvYy0JJqou3VCE7o=; b=BR9vT4ymf3f/raXTo1SAejX0aNIRCKRqBr9r9PsVz5IrQef29omIu4R0RMy5JYcxR6 R6hAvPKtTSB2PBA440x/ZmfcMxG6EXN9HxOS+tpoe8d7bdxqa1mx2EyM1ZaEzXf9kp8h n9cqSH+m7v9lnxymq1+HR+hyt1oXVubjkErnvrmRkrkcg/ejSISdbXwlpo8QQTrlaDxV /M588f0y4qtn7NoQ2PlCU9sgBu9zsnYVM9ylN2seAMQWdzmnSLTDdqzvPgZ1a3s9ffx5 hnL3JvfYK/XEZJK3HiW6m0poZReaBFJEsidz8Su74ZUwDVKA6egkrz6Y6JTXfZ97KYNF Cj8g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1695375695; x=1695980495; h=mime-version:user-agent:message-id:date:subject:to:from :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=LjBikb3cxVmJWWHvYBLNyUNLTUJAvYy0JJqou3VCE7o=; b=dYFKHZBTaxfQeuyeID+FroxA16L8L8NmUPCwu9kXdXQ+9Peq+5FmclUwKwHgxEDnP+ 25dgTBZhVzzIhJJ9lAsEBC/AP6r3UyVC6rIQ++4VYHJmIN9uck1bx+YM2oxHXmiWcb2w J1gMwu8UOVAIlvVYR+nCEFfnOPAQkk6pf7uG9um5SrJrsdRTkL1QlqlH70EaG6lbSVZm NscMLZb3I+oF9HBPuaDMMY7pAQFs0Ud4MrC0i9qHbrcpb8uxrQrlWisc6irtk2dfGFhv AJ9Ihb0kUgMFHGt25v02dSfk7Qf14rSTAqYtd8Hi8HPC0Izb7yve0YgL3R3LC6OL9yqr NKJg== X-Gm-Message-State: AOJu0YwBFw35ySs6MRYuuWzBhC9XntDTib1eqnXQj5VocZi94wFFSodA SgKWVs7U4LSeUhJDXIRDT2vv9QuVQrJ+wsHfcqa2HA== X-Google-Smtp-Source: AGHT+IEj5XfTU7GIh7OhGlKv46mogV/jJ1Y2kFavTgYwAUnhvfUZYr4uVLf5YLLH+IQ17PpUo2X2bQ== X-Received: by 2002:a17:906:cc13:b0:9ae:540c:90ef with SMTP id ml19-20020a170906cc1300b009ae540c90efmr5374958ejb.18.1695375695281; Fri, 22 Sep 2023 02:41:35 -0700 (PDT) Original-Received: from localhost (vpn-254-222.epfl.ch. [128.179.254.222]) by smtp.gmail.com with ESMTPSA id va1-20020a17090711c100b0099d9dee8108sm2463099ejb.149.2023.09.22.02.41.34 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 22 Sep 2023 02:41:34 -0700 (PDT) Received-SPF: pass client-ip=2a00:1450:4864:20::62c; envelope-from=contovob@tcd.ie; helo=mail-ej1-x62c.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:271057 Archived-At: --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Severity: minor Tags: patch Building master, I see the following warning: In toplevel form: files.el:1327:12: Warning: in defcustom for =E2=80=98remote-file-name-inh= ibit-cache=E2=80=99: duplicated :tag string in =E2=80=98choice=E2=80=99: "Do not use file name= cache" Is the following patch acceptable? It tries to improve on the following points: - Avoid too much negation - Fix then/than typo - Avoid mid-sentence %v :format since it extends to eol --=-=-= Content-Type: text/x-diff Content-Disposition: inline; filename=0001-Improve-remote-file-name-inhibit-cache-type.patch >From cd861f4e80b9bd0d656b024834ea49dbbd02f399 Mon Sep 17 00:00:00 2001 From: "Basil L. Contovounesios" Date: Fri, 22 Sep 2023 11:27:29 +0200 Subject: [PATCH] Improve remote-file-name-inhibit-cache :type * lisp/files.el (remote-file-name-inhibit-cache): Avoid duplicated :tag string. Try to clarify wording and formatting. --- lisp/files.el | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/lisp/files.el b/lisp/files.el index b67482a2f74..3f351d2aff8 100644 --- a/lisp/files.el +++ b/lisp/files.el @@ -1322,10 +1322,10 @@ remote-file-name-inhibit-cache :group 'tramp :version "24.1" :type '(choice - (const :tag "Do not inhibit file name cache" nil) - (const :tag "Do not use file name cache" t) - (integer :tag "Do not use file name cache" - :format "Do not use file name cache older then %v seconds" + (const :tag "Inhibit remote file cache" t) + (const :tag "Cache remote file attributes" nil) + (integer :tag "Cache remote file attributes with expiration" + :format "Cache expiry in seconds: %v" :value 10))) (defcustom remote-file-name-access-timeout nil -- 2.40.1 --=-=-= Content-Type: text/plain If it's acceptable, does it belong on master or emacs-29? Thanks, -- Basil In GNU Emacs 30.0.50 (build 1, x86_64-pc-linux-gnu, X toolkit, cairo version 1.17.8, Xaw3d scroll bars) of 2023-09-22 built on tia Repository revision: d71b9673a07da93cd7651540cd015636b8f66fda Repository branch: master Windowing system distributor 'The X.Org Foundation', version 11.0.12101008 System Description: Debian GNU/Linux trixie/sid Configured using: 'configure 'CFLAGS=-O2 -ggdb3' -C --prefix=/home/blc/.local --enable-checking=structs --with-file-notification=yes --with-x-toolkit=lucid --with-x' Configured features: ACL CAIRO DBUS FREETYPE GIF GLIB GMP GNUTLS GPM GSETTINGS HARFBUZZ JPEG JSON LCMS2 LIBOTF LIBSELINUX LIBSYSTEMD LIBXML2 M17N_FLT MODULES NOTIFY INOTIFY PDUMPER PNG RSVG SECCOMP SOUND SQLITE3 THREADS TIFF TOOLKIT_SCROLL_BARS TREE_SITTER WEBP X11 XAW3D XDBE XIM XINPUT2 XPM LUCID ZLIB Important settings: value of $LANG: en_IE.UTF-8 value of $XMODIFIERS: @im=ibus locale-coding-system: utf-8-unix Major mode: Lisp Interaction Minor modes in effect: tooltip-mode: t global-eldoc-mode: t eldoc-mode: t show-paren-mode: t electric-indent-mode: t mouse-wheel-mode: t tool-bar-mode: t menu-bar-mode: t file-name-shadow-mode: t global-font-lock-mode: t font-lock-mode: t blink-cursor-mode: t minibuffer-regexp-mode: t line-number-mode: t indent-tabs-mode: t transient-mark-mode: t auto-composition-mode: t auto-encryption-mode: t auto-compression-mode: t Load-path shadows: None found. Features: (shadow sort mail-extr emacsbug message mailcap yank-media puny dired dired-loaddefs rfc822 mml mml-sec password-cache epa derived epg rfc6068 epg-config gnus-util text-property-search time-date subr-x mm-decode mm-bodies mm-encode mail-parse rfc2231 mailabbrev gmm-utils mailheader cl-loaddefs cl-lib sendmail rfc2047 rfc2045 ietf-drums mm-util mail-prsvr mail-utils rmc iso-transl tooltip cconv eldoc paren electric uniquify ediff-hook vc-hooks lisp-float-type elisp-mode mwheel term/x-win x-win term/common-win x-dnd touch-screen tool-bar dnd fontset image regexp-opt fringe tabulated-list replace newcomment text-mode lisp-mode prog-mode register page tab-bar menu-bar rfn-eshadow isearch easymenu timer select scroll-bar mouse jit-lock font-lock syntax font-core term/tty-colors frame minibuffer nadvice seq simple cl-generic indonesian philippine cham georgian utf-8-lang misc-lang vietnamese tibetan thai tai-viet lao korean japanese eucjp-ms cp51932 hebrew greek romanian slovak czech european ethiopic indian cyrillic chinese composite emoji-zwj charscript charprop case-table epa-hook jka-cmpr-hook help abbrev obarray oclosure cl-preloaded button loaddefs theme-loaddefs faces cus-face macroexp files window text-properties overlay sha1 md5 base64 format env code-pages mule custom widget keymap hashtable-print-readable backquote threads dbusbind inotify lcms2 dynamic-setting system-font-setting font-render-setting cairo x-toolkit xinput2 x multi-tty move-toolbar make-network-process emacs) Memory information: ((conses 16 38057 8789) (symbols 48 5209 0) (strings 32 14031 1562) (string-bytes 1 382797) (vectors 16 10297) (vector-slots 8 156208 12401) (floats 8 23 23) (intervals 56 259 0) (buffers 992 10)) --=-=-=--