From mboxrd@z Thu Jan  1 00:00:00 1970
Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail
From: Philip Kaludercic <philipk@posteo.net>
Newsgroups: gmane.emacs.bugs
Subject: bug#66567: [PATCH] use-package: Add ignored-files support to :vc
 keyword
Date: Tue, 07 Nov 2023 21:24:58 +0000
Message-ID: <87wmutfe8l.fsf@posteo.net>
References: <877cnn4z2v.fsf@hyperspace> <87ttq5u9fj.fsf@posteo.net>
 <87ttq5bx2y.fsf@hyperspace> <87r0l91vww.fsf@posteo.net>
 <87r0l9fsl1.fsf@hyperspace> <871qd91l9e.fsf@posteo.net>
 <87bkc59wv8.fsf@hyperspace>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214";
	logging-data="39803"; mail-complaints-to="usenet@ciao.gmane.io"
Cc: stefankangas@gmail.com, 66567@debbugs.gnu.org
To: Tony Zorman <tonyzorman@mailbox.org>
Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue Nov 07 22:25:39 2023
Return-path: <bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org>
Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org
Original-Received: from lists.gnu.org ([209.51.188.17])
	by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
	(Exim 4.92)
	(envelope-from <bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org>)
	id 1r0TZq-000A9q-R5
	for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 07 Nov 2023 22:25:38 +0100
Original-Received: from localhost ([::1] helo=lists1p.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.90_1)
	(envelope-from <bug-gnu-emacs-bounces@gnu.org>)
	id 1r0TZe-0004FG-3n; Tue, 07 Nov 2023 16:25:26 -0500
Original-Received: from eggs.gnu.org ([2001:470:142:3::10])
 by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <Debian-debbugs@debbugs.gnu.org>)
 id 1r0TZb-0004F7-VP
 for bug-gnu-emacs@gnu.org; Tue, 07 Nov 2023 16:25:24 -0500
Original-Received: from debbugs.gnu.org ([2001:470:142:5::43])
 by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)
 (Exim 4.90_1) (envelope-from <Debian-debbugs@debbugs.gnu.org>)
 id 1r0TZb-0004VI-Nb
 for bug-gnu-emacs@gnu.org; Tue, 07 Nov 2023 16:25:23 -0500
Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2)
 (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1r0TaD-0008Of-R6
 for bug-gnu-emacs@gnu.org; Tue, 07 Nov 2023 16:26:01 -0500
X-Loop: help-debbugs@gnu.org
Resent-From: Philip Kaludercic <philipk@posteo.net>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces@debbugs.gnu.org>
Resent-CC: bug-gnu-emacs@gnu.org
Resent-Date: Tue, 07 Nov 2023 21:26:01 +0000
Resent-Message-ID: <handler.66567.B66567.169939234832254@debbugs.gnu.org>
Resent-Sender: help-debbugs@gnu.org
X-GNU-PR-Message: followup 66567
X-GNU-PR-Package: emacs
X-GNU-PR-Keywords: patch
Original-Received: via spool by 66567-submit@debbugs.gnu.org id=B66567.169939234832254
 (code B ref 66567); Tue, 07 Nov 2023 21:26:01 +0000
Original-Received: (at 66567) by debbugs.gnu.org; 7 Nov 2023 21:25:48 +0000
Original-Received: from localhost ([127.0.0.1]:43430 helo=debbugs.gnu.org)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <debbugs-submit-bounces@debbugs.gnu.org>)
 id 1r0Ta0-0008O7-19
 for submit@debbugs.gnu.org; Tue, 07 Nov 2023 16:25:48 -0500
Original-Received: from mout01.posteo.de ([185.67.36.65]:46961)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <philipk@posteo.net>) id 1r0TZv-0008Np-Ue
 for 66567@debbugs.gnu.org; Tue, 07 Nov 2023 16:25:46 -0500
Original-Received: from submission (posteo.de [185.67.36.169]) 
 by mout01.posteo.de (Postfix) with ESMTPS id 891BB240029
 for <66567@debbugs.gnu.org>; Tue,  7 Nov 2023 22:24:59 +0100 (CET)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017;
 t=1699392299; bh=dCYpXfhlvUWJaU5rpBh9AaewmbujfjstsLd6TnQfHKg=;
 h=From:To:Cc:Subject:Autocrypt:Date:Message-ID:MIME-Version:
 Content-Transfer-Encoding:From;
 b=qVAE6G0ZFgMEKIapbHaybnvZcxot1hrkGoVCXH9NxPIN6vi9mc5sQZZ4a1l6CUVBv
 +aQVk9rgLi+xmh9UJHbMxqmYZpYlmdtaoWfxvYDUxiqb/qOmhhneCBS4Bj959pHjqe
 64nTZ2Tb0QjMB/tll3WfPobCJ4hw7kiLdNM/ihj/i4jfH2a2Lij1fYSCOKtw7ARq/7
 m82hdiWhC485T+0G70sHXgfeOSuC+BvdkwrDmQDPTBJZr98F0Li26cPi7OiLrltXAM
 Ie2yor7NF9DDEjWvRDeluMo6eCVpVoNXMMMv6z9dnfTt3BYd67iRqdoZ7kvuZTJCSQ
 U4ADknK7MrmXA==
Original-Received: from customer (localhost [127.0.0.1])
 by submission (posteo.de) with ESMTPSA id 4SQ1T63DKBz9rxB;
 Tue,  7 Nov 2023 22:24:58 +0100 (CET)
In-Reply-To: <87bkc59wv8.fsf@hyperspace> (Tony Zorman's message of "Tue, 07
 Nov 2023 20:39:07 +0100")
Autocrypt: addr=philipk@posteo.net; keydata=
 mDMEZBBQQhYJKwYBBAHaRw8BAQdAHJuofBrfqFh12uQu0Yi7mrl525F28eTmwUDflFNmdui0QlBo
 aWxpcCBLYWx1ZGVyY2ljIChnZW5lcmF0ZWQgYnkgYXV0b2NyeXB0LmVsKSA8cGhpbGlwa0Bwb3N0
 ZW8ubmV0PoiWBBMWCAA+FiEEDg7HY17ghYlni8XN8xYDWXahwukFAmQQUEICGwMFCQHhM4AFCwkI
 BwIGFQoJCAsCBBYCAwECHgECF4AACgkQ8xYDWXahwulikAEA77hloUiSrXgFkUVJhlKBpLCHUjA0
 mWZ9j9w5d08+jVwBAK6c4iGP7j+/PhbkxaEKa4V3MzIl7zJkcNNjHCXmvFcEuDgEZBBQQhIKKwYB
 BAGXVQEFAQEHQI5NLiLRjZy3OfSt1dhCmFyn+fN/QKELUYQetiaoe+MMAwEIB4h+BBgWCAAmFiEE
 Dg7HY17ghYlni8XN8xYDWXahwukFAmQQUEICGwwFCQHhM4AACgkQ8xYDWXahwukm+wEA8cml4JpK
 NeAu65rg+auKrPOP6TP/4YWRCTIvuYDm0joBALw98AMz7/qMHvSCeU/hw9PL6u6R2EScxtpKnWof
 z4oM
X-BeenThere: debbugs-submit@debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
X-BeenThere: bug-gnu-emacs@gnu.org
List-Id: "Bug reports for GNU Emacs,
 the Swiss army knife of text editors" <bug-gnu-emacs.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/bug-gnu-emacs>,
 <mailto:bug-gnu-emacs-request@gnu.org?subject=unsubscribe>
List-Archive: <https://lists.gnu.org/archive/html/bug-gnu-emacs>
List-Post: <mailto:bug-gnu-emacs@gnu.org>
List-Help: <mailto:bug-gnu-emacs-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/bug-gnu-emacs>,
 <mailto:bug-gnu-emacs-request@gnu.org?subject=subscribe>
Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org
Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org
Xref: news.gmane.io gmane.emacs.bugs:273949
Archived-At: <http://permalink.gmane.org/gmane.emacs.bugs/273949>

Tony Zorman <tonyzorman@mailbox.org> writes:

> On Wed, Nov 01 2023 16:38, Philip Kaludercic wrote:
>> Tony Zorman <tonyzorman@mailbox.org> writes:
>>> On Wed, Nov 01 2023 12:48, Philip Kaludercic wrote:
>>>> Tony Zorman <tonyzorman@mailbox.org> writes:
>>>>> On Wed, Nov 01 2023 09:09, Philip Kaludercic wrote:
>>>>>
>>>>>> Why is use-package checking for valid keywords in the first place?
>>>>>
>>>>> Better error messages, mostly. Especially people switching from
>>>>> quelpa/straight/vc-use-package might be surprised that :vc is not a
>>>>> drop-in replacement for those packages. I feel like alerting them to
>>>>> this fact sooner rather than later makes for a better experience.
>>>>
>>>> IIUC this would raise an error when an unknown keyword is encountered,
>>>> right?
>>>
>>> Yes, a declaration like
>>>
>>>     (use-package foo
>>>       :vc (:url "url" :blargh "123"))
>>>
>>> would result in the following message
>>>
>>>     =E2=9B=94 Error (use-package): Failed to parse package foo: use-pac=
kage: Keyword :vc received unknown argument: :blargh. Supported keywords ar=
e: (:url :branch :lisp-dir :main-file :vc-backend :rev :shell-command :make=
 :ignored-files)
>>>
>>> Things get a bit muddier if ':blargh' would be passed down to
>>> package-vc-install.
>>
>> What I was wondering, was if it would make sense to raise an warning
>> instead.
>
> Now I'm a bit confused: where exactly? Inside of use-package or
> package-vc? Either way, I think raising an error when the user inputs
> nonsense is totally justified=E2=80=94I'd just like that error to be
> understandable as quickly as possible.

I was thinking that package-vc should emit an error, but that
use-package could emit a warning, in case a new keyword is added to
package-vc specifications but hasn't yet been added to the use-package
layer -- mainly because I don't use the latter and am not that familiar
with the code.

>   Tony