unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: john muhl via "Bug reports for GNU Emacs, the Swiss army knife of text editors" <bug-gnu-emacs@gnu.org>
To: Noah Peart <noah.v.peart@gmail.com>
Cc: 67616@debbugs.gnu.org
Subject: bug#67616: [PATCH] Fix: add comint hook locally in lua-ts-inferior-lua
Date: Sun, 03 Dec 2023 22:18:22 -0600	[thread overview]
Message-ID: <87wmtua8t6.fsf@pub.pink> (raw)
In-Reply-To: <CAPVBTScduNJNuzOEjESO2PkvHLGd5nkYZ142Yu3C64+JMtCdZw@mail.gmail.com>

[-- Attachment #1: Type: text/plain, Size: 288 bytes --]

Noah Peart <noah.v.peart@gmail.com> writes:

> Tags: patch
>
> Bug: In `lua-ts-inferior-lua`, `comint-preoutput-filter-functions` hook
> isn't added locally.

Thanks. I think that obsoletes the buffer-name check at the
beginning. A quick test looks that way to me. Could you give a try?


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0001-Fix-add-comint-hook-locally-in-lua-ts-inferior-lua.patch --]
[-- Type: text/x-patch, Size: 1745 bytes --]

From 077258d0f95d6597108a5cab8b73833deba05339 Mon Sep 17 00:00:00 2001
From: nverno <noah.v.peart@gmail.com>
Date: Sun, 3 Dec 2023 19:21:04 -0800
Subject: [PATCH] Fix: add comint hook locally in lua-ts-inferior-lua

* lisp/progmodes/lua-ts-mode.el (lua-ts-inferior-lua): Add
comint-preoutput-filter-functions hook locally.
---
 lisp/progmodes/lua-ts-mode.el | 7 +++----
 1 file changed, 3 insertions(+), 4 deletions(-)

diff --git a/lisp/progmodes/lua-ts-mode.el b/lisp/progmodes/lua-ts-mode.el
index 7307a5b13f1..5318144a057 100644
--- a/lisp/progmodes/lua-ts-mode.el
+++ b/lisp/progmodes/lua-ts-mode.el
@@ -560,9 +560,7 @@ lua-ts-inferior-lua
       (comint-read-input-ring t)
       (add-hook 'comint-preoutput-filter-functions
                 (lambda (string)
-                  (if (or (not (equal (buffer-name) lua-ts-inferior-buffer))
-                          (equal string
-                                 (concat lua-ts-inferior-prompt-continue " ")))
+                  (if (equal string (concat lua-ts-inferior-prompt-continue " "))
                       string
                     (concat
                      ;; Filter out the extra prompt characters that
@@ -576,7 +574,8 @@ lua-ts-inferior-lua
                                                     (group (* nonl))))
                                                "\\1" string)
                      ;; Re-add the prompt for the next line.
-                     lua-ts-inferior-prompt " "))))))
+                     lua-ts-inferior-prompt " ")))
+                nil t)))
   (select-window (display-buffer lua-ts-inferior-buffer
                                  '((display-buffer-reuse-window
                                     display-buffer-pop-up-frame)
-- 
2.41.0


  reply	other threads:[~2023-12-04  4:18 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-12-04  3:26 bug#67616: [PATCH] Fix: add comint hook locally in lua-ts-inferior-lua Noah Peart
2023-12-04  4:18 ` john muhl via Bug reports for GNU Emacs, the Swiss army knife of text editors [this message]
2023-12-04  7:58   ` Noah Peart
2023-12-04 18:17     ` john muhl via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-12-16  9:39       ` Eli Zaretskii

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87wmtua8t6.fsf@pub.pink \
    --to=bug-gnu-emacs@gnu.org \
    --cc=67616@debbugs.gnu.org \
    --cc=jm@pub.pink \
    --cc=noah.v.peart@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).