From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Philip Kaludercic Newsgroups: gmane.emacs.bugs Subject: bug#66554: [PATCH] Add the public API of Compat to the core Date: Fri, 12 Jan 2024 07:38:20 +0000 Message-ID: <87wmsfm26r.fsf@posteo.net> References: <87pm1ggrdx.fsf@posteo.net> <87bk9scucg.fsf@daniel-mendler.de> <87y1cwpanh.fsf@posteo.net> <877ckgpa45.fsf@daniel-mendler.de> <87mstbpyd7.fsf@posteo.net> <87h6jjah1g.fsf@daniel-mendler.de> <87edenptba.fsf@posteo.net> <875xzzpqiu.fsf@posteo.net> <83ply7j9by.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="1636"; mail-complaints-to="usenet@ciao.gmane.io" Cc: mail@daniel-mendler.de, stefankangas@gmail.com, monnier@iro.umontreal.ca, 66554@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Jan 12 08:39:24 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rOC8R-0000Em-MT for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 12 Jan 2024 08:39:23 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rOC8B-0006dG-1X; Fri, 12 Jan 2024 02:39:07 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rOC89-0006d7-AW for bug-gnu-emacs@gnu.org; Fri, 12 Jan 2024 02:39:05 -0500 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1rOC88-00058D-IO for bug-gnu-emacs@gnu.org; Fri, 12 Jan 2024 02:39:05 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1rOC86-0004O9-7V for bug-gnu-emacs@gnu.org; Fri, 12 Jan 2024 02:39:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Philip Kaludercic Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 12 Jan 2024 07:39:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 66554 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 66554-submit@debbugs.gnu.org id=B66554.170504511016826 (code B ref 66554); Fri, 12 Jan 2024 07:39:02 +0000 Original-Received: (at 66554) by debbugs.gnu.org; 12 Jan 2024 07:38:30 +0000 Original-Received: from localhost ([127.0.0.1]:34779 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rOC7Z-0004NJ-RD for submit@debbugs.gnu.org; Fri, 12 Jan 2024 02:38:30 -0500 Original-Received: from mout01.posteo.de ([185.67.36.65]:33391) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rOC7W-0004N2-Ng for 66554@debbugs.gnu.org; Fri, 12 Jan 2024 02:38:28 -0500 Original-Received: from submission (posteo.de [185.67.36.169]) by mout01.posteo.de (Postfix) with ESMTPS id AE461240028 for <66554@debbugs.gnu.org>; Fri, 12 Jan 2024 08:38:22 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1705045102; bh=GlahtJGWsc2uNkOJRT5u4wUNZJsUkId3lpVrUyLgfM0=; h=From:To:Cc:Subject:Autocrypt:OpenPGP:Date:Message-ID:MIME-Version: From; b=DQGlpUVywJ9WIuLtKIlmOlZvlFRRuAjBy2LsQQXNnxj7OnZecVMEtbLlbV3ReLBa5 wiwKqMEsDr1o1I7JVDAOjKoePh4RyaLMaxHnshGGFdSTHsrbU9YoDdQAiHqpJFNLFs LfviX8etwv14WYHfuevZuNEFI5JuinT7fvRvqAPto5YqEEBszUB4xzIa1XbpkjyfUf d4mRuBmm31lYVnUFbsVqjTu/pzZ8wIKFktnAY7NpxTYeGjdO+kNk9+NNjK+y3T4dIj Y239ZWo52qrYI043JQ9dtRpKn15PULl1qHitcC+WLklvXltQyABCWjnXcMTIPB40gU OTM/q+uDIJGvA== Original-Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4TBD0s2XVsz9rxN; Fri, 12 Jan 2024 08:38:21 +0100 (CET) In-Reply-To: <83ply7j9by.fsf@gnu.org> (Eli Zaretskii's message of "Fri, 12 Jan 2024 09:32:17 +0200") Autocrypt: addr=philipk@posteo.net; keydata= mDMEZBBQQhYJKwYBBAHaRw8BAQdAHJuofBrfqFh12uQu0Yi7mrl525F28eTmwUDflFNmdui0QlBo aWxpcCBLYWx1ZGVyY2ljIChnZW5lcmF0ZWQgYnkgYXV0b2NyeXB0LmVsKSA8cGhpbGlwa0Bwb3N0 ZW8ubmV0PoiWBBMWCAA+FiEEDg7HY17ghYlni8XN8xYDWXahwukFAmQQUEICGwMFCQHhM4AFCwkI BwIGFQoJCAsCBBYCAwECHgECF4AACgkQ8xYDWXahwulikAEA77hloUiSrXgFkUVJhlKBpLCHUjA0 mWZ9j9w5d08+jVwBAK6c4iGP7j+/PhbkxaEKa4V3MzIl7zJkcNNjHCXmvFcEuDgEZBBQQhIKKwYB BAGXVQEFAQEHQI5NLiLRjZy3OfSt1dhCmFyn+fN/QKELUYQetiaoe+MMAwEIB4h+BBgWCAAmFiEE Dg7HY17ghYlni8XN8xYDWXahwukFAmQQUEICGwwFCQHhM4AACgkQ8xYDWXahwukm+wEA8cml4JpK NeAu65rg+auKrPOP6TP/4YWRCTIvuYDm0joBALw98AMz7/qMHvSCeU/hw9PL6u6R2EScxtpKnWof z4oM OpenPGP: id=7126E1DE2F0CE35C770BED01F2C3CC513DB89F66; url="https://keys.openpgp.org/vks/v1/by-fingerprint/7126E1DE2F0CE35C770BED01F2C3CC513DB89F66"; preference=signencrypt X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:277996 Archived-At: Eli Zaretskii writes: >> From: Philip Kaludercic >> Cc: Daniel Mendler , 66554@debbugs.gnu.org, >> eliz@gnu.org, Stefan Kangas >> Date: Thu, 11 Jan 2024 20:24:25 +0000 >> >> > The addition cab done procedurally, as in >> > >> > ;;;;####autoload (push (list 'compat emacs-major-version >> > emacs-minor-version) package--builtin-versions) >> >> If this work, I like this idea a lot! I'll test it out to see if this >> could simplify things. > > I'm not sure I understand the effects of the above -- can you explain? The idea is to manually register the file as a package while scraping for autoloads, thereby setting the version of the built-in Compat package to whatever the current version of Emacs is. My patch adds a `most-positive-fixnum' to the version number to ensure that the built-in compat is always (or at least for a more than reasonably long while) preferred over an external dependency. The consequence is that we don't have to update any files, and I would assume we don't have to document anything in make-tarball.txt, because nothing has to be done when bumping the version of Emacs itself. > In general, if something needs to be done when the Emacs version is > bumped, that action should be described in make-tarball.txt. It is a > nuisance to follow the procedure there, only to be reminded of > something else via a warning emitted by the build (and that is even > before we consider the possibility that someone launches a build and > goes for a coffee, while the warnings scroll on the screen with no one > to see them). Likewise, if a file is modified by whatever commands we > invoke to bump an Emacs version, that file should be mentioned in > make-tarball.txt, because the person who performs that procedure will > then need to commit the changes with a suitable log message, like we > do today with configure.ac and the rest.