From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Mohsin Kaleem Newsgroups: gmane.emacs.bugs Subject: bug#62994: [PATCH v5] Add support for colored and styled underlines on tty frames Date: Sun, 10 Mar 2024 17:15:25 +0000 Message-ID: <87wmqaf1oy.fsf@kisara.moe> References: <20240211180501.695192-1-mohkale@kisara.moe> <87bk8m1mq8.fsf@yahoo.com> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="34186"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Eli Zaretskii , 62994@debbugs.gnu.org To: Po Lu Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Mar 10 18:16:46 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rjMn0-0008kW-9D for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 10 Mar 2024 18:16:46 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rjMmn-0000qt-L6; Sun, 10 Mar 2024 13:16:33 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rjMmj-0000qd-9C for bug-gnu-emacs@gnu.org; Sun, 10 Mar 2024 13:16:29 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1rjMmi-0000Dx-Qg for bug-gnu-emacs@gnu.org; Sun, 10 Mar 2024 13:16:29 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1rjMnF-0007ff-Ks for bug-gnu-emacs@gnu.org; Sun, 10 Mar 2024 13:17:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Mohsin Kaleem Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 10 Mar 2024 17:17:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 62994 X-GNU-PR-Package: emacs Original-Received: via spool by 62994-submit@debbugs.gnu.org id=B62994.171009096329392 (code B ref 62994); Sun, 10 Mar 2024 17:17:01 +0000 Original-Received: (at 62994) by debbugs.gnu.org; 10 Mar 2024 17:16:03 +0000 Original-Received: from localhost ([127.0.0.1]:37789 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rjMmJ-0007e0-7X for submit@debbugs.gnu.org; Sun, 10 Mar 2024 13:16:03 -0400 Original-Received: from 119.ip-51-38-65.eu ([51.38.65.119]:60014 helo=mail.kisara.moe) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rjMmH-0007dX-8r for 62994@debbugs.gnu.org; Sun, 10 Mar 2024 13:16:01 -0400 Original-Received: from mk-desktop (05408574.skybroadband.com [5.64.133.116]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (prime256v1) server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by mail.kisara.moe (Postfix) with ESMTPSA id 93350A2796; Sun, 10 Mar 2024 18:15:26 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kisara.moe; s=default; t=1710090926; bh=B+jVQkQjNrgHA6Jf+dFFZAotfVcE5pCJJVzmmwVPGU8=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=1lUUYr9aa5V5Bl0gdsUvsbw2RtvOMXt6L+39PZ/3Ca1aik2iROCPj5nh++LU5bN5i jSpWDzGbPLtoa4Fn4niAvaY32XXUpxs8QbMxKrFqkT/JllzMTzIDKaGvgJUKsojSG7 rw5VOQmrFPaMIbAO57DSsSFOl8i+7B0vdWRl+WWSSaIjjJMaL14uepfGP3HcM7J+T3 G3y/gUuTOba/EutTMEgMnE5jW5mYTOBiG/UI2287WaJQnbg49HF/7JwQr4QBE9ISkG uggu5OYE2MtMLZOskE5EqmNgrh180XX5cha0kKIFcx41pfPhBobTmv5xhttfa6eBfb axp4kphVoCd5Q== In-Reply-To: <87bk8m1mq8.fsf@yahoo.com> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:281410 Archived-At: Po Lu writes: > mohkale@kisara.moe writes: > >> ++++ > > Where's the documentation for this change? Referring to the pluses themselves? Or I might be misunderstanding? I was trying to match the format of other records in this file. Many headings seemed to be followed by a mix of +++ or --- so I thought it was required? If not I'll just remove it. > We prefer to punctuate sentences within NEWS headings. Added trailing period. > What about GUI frames? I don't want to see a display feature installed > before it is also implemented for the likes of X. Is this absolutely necessary? I had thought if the framework for supporting this was in place then someone could contribute it down the line but didn't want to prevent a possible terminal feature based on GUI support (and vice versa). Currently if one tries to set a unsupported underline style on GUI frames they'll be met with a single underline as if they didn't specify a style at all. This is the same behaviour we'd get if a you tried setting a face attribute on terminal frames that's only supported by GUI frames. > #define TTY_CAP_UNDERLINE_STYLED (0x32 & TTY_CAP_UNDERLINE) Nice catch. Fixed. > In Emacs, we format code with a mixture of tabs and spaces, using tabs > to indent by whole tab stops and spaces to indent to the desired column, > which is a multiple of 2 columns for most statements or the column after > the opening paren where applicable. Please also insert a space between > function identifiers and argument lists, and confine all text to 80 > columns. > > Here you have evidently typed `M-x tabify' with a comment selected. Do > not insert tabs by whatever means within the body of a comment, although > it is best to indent the body itself with them, whenever possible. > > More indentation problems. I had thought `M-x tabify` was supposed to normalize this to the Emacs code standards. Should I manually reindent this to match or is there another function that can do this for me? Sorry if this is unusual, I'm accustomed to formatting and linting tools that do this in bulk for me :-). > Please don't link to Github, and explain > instead the reasoning behind the sequence itself. > Please also avoid inserting redundant braces in if statements. Fixed and I've looked through a few other places where braces could be remvoed. -- Mohsin Kaleem