From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Visuwesh Newsgroups: gmane.emacs.bugs Subject: bug#70820: [PATCH] Editable grep buffers Date: Thu, 09 May 2024 16:02:35 +0530 Message-ID: <87wmo3jmws.fsf@gmail.com> References: <87seytlhcq.fsf@gmail.com> <86pltxa40q.fsf@gnu.org> <87jzk5kmwk.fsf@gmail.com> <86ikzoa51h.fsf@gnu.org> <878r0klcp1.fsf@gmail.com> <864jb89zwq.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="38844"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: 70820@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu May 09 12:33:49 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1s515u-0009o3-VK for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 09 May 2024 12:33:46 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1s515m-0002dD-EA; Thu, 09 May 2024 06:33:38 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1s515k-0002cn-I0 for bug-gnu-emacs@gnu.org; Thu, 09 May 2024 06:33:36 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1s515k-0007Un-A4 for bug-gnu-emacs@gnu.org; Thu, 09 May 2024 06:33:36 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1s5169-0006B6-Vl for bug-gnu-emacs@gnu.org; Thu, 09 May 2024 06:34:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Visuwesh Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 09 May 2024 10:34:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 70820 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 70820-submit@debbugs.gnu.org id=B70820.171525079423727 (code B ref 70820); Thu, 09 May 2024 10:34:01 +0000 Original-Received: (at 70820) by debbugs.gnu.org; 9 May 2024 10:33:14 +0000 Original-Received: from localhost ([127.0.0.1]:54511 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1s515O-0006Ad-8v for submit@debbugs.gnu.org; Thu, 09 May 2024 06:33:14 -0400 Original-Received: from mail-pl1-x642.google.com ([2607:f8b0:4864:20::642]:45085) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1s515K-0006AX-EV for 70820@debbugs.gnu.org; Thu, 09 May 2024 06:33:12 -0400 Original-Received: by mail-pl1-x642.google.com with SMTP id d9443c01a7336-1edf506b216so4894305ad.2 for <70820@debbugs.gnu.org>; Thu, 09 May 2024 03:32:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1715250758; x=1715855558; darn=debbugs.gnu.org; h=content-transfer-encoding:mime-version:user-agent:message-id:date :references:in-reply-to:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=i17DLaGMRRiWTJ5ycLkXm4W63+7W8/3qJK4Eq6cKqRo=; b=YGjsxh71I5mQ0NA/4v+7Ww0dJrcMLCsGeKHN9mWFpTOoqIDJC52AHDocrp9EPbLyZz r1t1Ffm8i7bu5SwFkQpEHqLpghJxj/P1Ik8I8ysIaYdFnp4y+Wn5ymWDG987K1CnZHKm Sj9GbGjdpQMuQzTKF/yK/8Fym7SxlEiaVqyO6QUct+tLQbEEOzGO2nsNhKla5w7ZkugQ sdYE6Lwe3m2lTf1p32zk+wDShKyBO8WkDhpiMrvKirU0E+nqkPOVklZIubWRVRJ83Qd/ 8xsfvpK9uQeVDJwZ3LmV5jKseEB+A2xnGsbp0ieo80vKVVyrvZQ6DyEIotmQgWEzz/ak u+bg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1715250758; x=1715855558; h=content-transfer-encoding:mime-version:user-agent:message-id:date :references:in-reply-to:subject:cc:to:from:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=i17DLaGMRRiWTJ5ycLkXm4W63+7W8/3qJK4Eq6cKqRo=; b=cReBaMVlqT2eFaEghfwELCMvFN/fadRQuidVZLoZeHi+NYDrqIAW/0Aw4KqxG2xWbl AjshSy8uwQAKp+i44O7WJ+GDJ+CMY7TDFO235m703y0CJq0/VjDcmiwMg+49re8ZeFwY jFdRUcI+cvEGjOBQX1WlL/PffE4iWAtoLDAq5JnEF5/NtipnJD4dxGYBGFyehogjrZeO 1ztfJY/qrRw6fjn4+ugA0cfaPNi1jFbndswHPKO1GYeb5Z13KFAp90Ug/bBImf5wMOui XEoAwNrI6B9sBI/86FaQ6oTnxGD34+YfOQ1rv0w8YXowtd2fITVxX57WftFOFMY8aAzy f3/w== X-Gm-Message-State: AOJu0YwlRUTvBupCslSW4I6+Z9PNwyIJnwsK6RxvPIQolmlx4i0tGSmB V96T4v0uslZdLoBi8LGmqZEPJ48JZs8vSxy3Sw00aJImmGjDMQht X-Google-Smtp-Source: AGHT+IGjtN+dh/VQ8J/aJfXA2/lab6ubZDMqPp7aUbb13DviW6RxsBZH/2duRiCWQkjX8FmYlYqmHQ== X-Received: by 2002:a17:902:cecc:b0:1e5:8175:4968 with SMTP id d9443c01a7336-1eeb03a4865mr63160335ad.9.1715250758549; Thu, 09 May 2024 03:32:38 -0700 (PDT) Original-Received: from localhost ([49.204.138.192]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-1ef0c25698csm11093235ad.305.2024.05.09.03.32.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 09 May 2024 03:32:38 -0700 (PDT) In-Reply-To: <864jb89zwq.fsf@gnu.org> (Eli Zaretskii's message of "Wed, 08 May 2024 16:49:41 +0300") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:284749 Archived-At: [=E0=AE=AA=E0=AF=81=E0=AE=A4=E0=AE=A9=E0=AF=8D =E0=AE=AE=E0=AF=87 08, 2024]= Eli Zaretskii wrote: >> From: Visuwesh >> Cc: 70820@debbugs.gnu.org >> Date: Wed, 08 May 2024 17:48:02 +0530 >>=20 >> [=E0=AE=AA=E0=AF=81=E0=AE=A4=E0=AE=A9=E0=AF=8D =E0=AE=AE=E0=AF=87 08, 20= 24] Eli Zaretskii wrote: >>=20 >> > I think having similar features that work very differently is not a >> > good thing for Emacs. So I urge you to reconsider your decisions and >> > make this more like occur-edit-mode. In particular, I don't >> > understand the difficulty with using the markers and what does it have >> > to do with the ability of having many Grep buffers. >>=20 >> It is not having many Grep buffers but visiting the "original" files >> unnecessarily that tends to be annoying. > > Why is this annoying? > >> > I don't think I understand this difficulty, either: with >> > occur-edit-mode it is solved by making occur-edit-mode be derived from >> > occur-mode. Couldn't you do the same with your mode? >>=20 >> No because occur-mode makes occur-revert-arguments permanent-local so >> `g' survives the major-mode changes. >>=20 >> For revert-buffer alone, compilation-arguments needs to be marked >> permanent-local. As it is a part of compile.el, I am not sure if >> marking it as such is safe. This is why I think having a minor-mode is >> better. > > It sounds like a minor issue which shouldn't have such grave > consequences. Why do you think making compilation-arguments > permanent-local would be a problem? We could ask people who > frequently contribute to compile.e land grep.el if they see any > problem with doing that. It feels like a potential far-fetching change. But in any case, I will give a shot at recreating the required markers, etc. for occur-after-change-function to work. Will send a patch once I have a working prototype.