From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Philip Kaludercic Newsgroups: gmane.emacs.bugs Subject: bug#71789: 29.3; Handling of nested directories of ELPA packages Date: Sun, 30 Jun 2024 10:17:01 +0000 Message-ID: <87wmm6lopu.fsf@posteo.net> References: <8734oz478n.fsf@debian-hx90.lan> <87ikxthrm5.fsf@jeremybryant.net> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="30847"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 71789@debbugs.gnu.org, Xiyue Deng To: Jeremy Bryant Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Jun 30 12:18:16 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1sNrdQ-0007mh-0W for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 30 Jun 2024 12:18:16 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sNrdE-0007Q6-LO; Sun, 30 Jun 2024 06:18:04 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sNrdD-0007Pw-7Q for bug-gnu-emacs@gnu.org; Sun, 30 Jun 2024 06:18:03 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1sNrdC-0004qq-T0 for bug-gnu-emacs@gnu.org; Sun, 30 Jun 2024 06:18:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1sNrdC-0000zR-Cp for bug-gnu-emacs@gnu.org; Sun, 30 Jun 2024 06:18:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Philip Kaludercic Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 30 Jun 2024 10:18:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 71789 X-GNU-PR-Package: emacs Original-Received: via spool by 71789-submit@debbugs.gnu.org id=B71789.17197426353751 (code B ref 71789); Sun, 30 Jun 2024 10:18:02 +0000 Original-Received: (at 71789) by debbugs.gnu.org; 30 Jun 2024 10:17:15 +0000 Original-Received: from localhost ([127.0.0.1]:55167 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sNrcQ-0000yR-6y for submit@debbugs.gnu.org; Sun, 30 Jun 2024 06:17:15 -0400 Original-Received: from mout02.posteo.de ([185.67.36.66]:59323) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sNrcN-0000yC-U0 for 71789@debbugs.gnu.org; Sun, 30 Jun 2024 06:17:13 -0400 Original-Received: from submission (posteo.de [185.67.36.169]) by mout02.posteo.de (Postfix) with ESMTPS id A144A240104 for <71789@debbugs.gnu.org>; Sun, 30 Jun 2024 12:17:03 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1719742624; bh=YumT78QxXMjDv9M40oPYZdrpC9ujHLM6cwV8SE5ezd0=; h=From:To:Cc:Subject:OpenPGP:Date:Message-ID:MIME-Version: Content-Type:From; b=I0sSs51BzzQNiYqh+KVIjBNhWGPUt4i1d+54iP8urii2RpvPv0GPgfeuMSv8RnJIM YCcjDiEBGFhdz6rdwdrrTVt0iExKmXNtcj0VE1yvKIx8AJEQ9bAd6cQJG7k+DeZfIs zgj4SBse7UcqUcKhXx0FkKgkfRSddXsXySBEiq/gzRlAfJEnib8VF5ITUSXAdexaWi lNJzzZrTztMqvZXaej8mazAlEdv1M8e7irDLRqRWCi7afAt5K1TbHzY98aD7GiCqUk UTKAGnE+2R56zsTLkYf8JEbq4dIF8Zp8lQyT1tZrWIDYq++KHL0quEB9ss7+3BJatC cbA3Z+FrsQY5w== Original-Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4WBlTV3z1zz9rxD; Sun, 30 Jun 2024 12:17:02 +0200 (CEST) In-Reply-To: <87ikxthrm5.fsf@jeremybryant.net> (Jeremy Bryant's message of "Fri, 28 Jun 2024 19:03:30 +0100") OpenPGP: id=7126E1DE2F0CE35C770BED01F2C3CC513DB89F66; url="https://keys.openpgp.org/vks/v1/by-fingerprint/7126E1DE2F0CE35C770BED01F2C3CC513DB89F66"; preference=signencrypt X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:288183 Archived-At: Jeremy Bryant writes: > Xiyue Deng writes: > >> Hi, >> >> I'm opening a bug to follow up the discussion at [1]. Given an ELPA >> package `elpafoo' that contains another directory `elpabar' that also >> holds source files, e.g. like the structure below: >> >> ,---- >> | ~/.config/emacs/elpa/elpafoo/ >> | ~/.config/emacs/elpa/elpafoo/elpafoo.el >> | ~/.config/emacs/elpa/elpafoo/elpabar >> | ~/.config/emacs/elpa/elpafoo/elpabar/elpabar.el >> `---- >> >> When installing through package.el, both elpafoo.el and >> elpabar/elpabar.el will be byte-compiled, but only the root source path >> `~/.config/emacs/elpa/elpafoo' is added to `load-path', without any of >> the nested directories. >> >> I wonder whether this is the intended behavior regarding `load-path' >> handling. If nested directories are added, it has the advantage to >> allow more fine-grained source organization; as a downside, it may >> unnecessarily add more unneeded stuff and processing overhead (as >> Michael pointed out at [2]), and potentially break existing code, >> e.g. auctex, which seems to vendor stuff in the `style/' directories but >> not loaded so it's not causing any trouble yet. >> >> So I wonder what is the stance of the Emacs maintainer on this subject, >> or whether this is documented anywhere. Also one more step: whether >> there is a recommended layout for source code organization for ELPA >> packages. I think it is intentional, because the approach is simple but functional enough in most instances. If you need to load a sub-directory, you can add an autoloaded `add-to-list' expression in elpafoo.el. >> [1] https://lists.gnu.org/archive/html/emacs-devel/2024-05/msg00658.html >> [2] https://lists.gnu.org/archive/html/emacs-devel/2024-05/msg01039.html >> >> >> >> In GNU Emacs 29.3 (build 1, x86_64-pc-linux-gnu, GTK+ Version 3.24.38, >> cairo version 1.16.0) of 2024-05-20, modified by Debian built on sbuild >> Windowing system distributor 'The X.Org Foundation', version 11.0.12101007 >> System Description: Debian GNU/Linux 12 (bookworm) >> >> Configured using: >> 'configure --build x86_64-linux-gnu --prefix=/usr >> --sharedstatedir=/var/lib --libexecdir=/usr/libexec >> --localstatedir=/var/lib --infodir=/usr/share/info >> --mandir=/usr/share/man --with-libsystemd --with-pop=yes >> --enable-locallisppath=/etc/emacs:/usr/local/share/emacs/29.3/site-lisp:/usr/local/share/emacs/site-lisp:/usr/share/emacs/29.3/site-lisp:/usr/share/emacs/site-lisp >> --with-sound=alsa --without-gconf --with-mailutils >> --with-native-compilation --build x86_64-linux-gnu --prefix=/usr >> --sharedstatedir=/var/lib --libexecdir=/usr/libexec >> --localstatedir=/var/lib --infodir=/usr/share/info >> --mandir=/usr/share/man --with-libsystemd --with-pop=yes >> --enable-locallisppath=/etc/emacs:/usr/local/share/emacs/29.3/site-lisp:/usr/local/share/emacs/site-lisp:/usr/share/emacs/29.3/site-lisp:/usr/share/emacs/site-lisp >> --with-sound=alsa --without-gconf --with-mailutils >> --with-native-compilation --with-cairo --with-x=yes >> --with-x-toolkit=gtk3 --with-toolkit-scroll-bars 'CFLAGS=-g -O2 >> -ffile-prefix-map=/build/reproducible-path/emacs-29.3+1=. -fstack-protector-strong >> -Wformat -Werror=format-security -Wall' 'CPPFLAGS=-Wdate-time >> -D_FORTIFY_SOURCE=2' LDFLAGS=-Wl,-z,relro' >> >> Configured features: >> ACL CAIRO DBUS FREETYPE GIF GLIB GMP GNUTLS GPM GSETTINGS HARFBUZZ JPEG >> JSON LCMS2 LIBOTF LIBSELINUX LIBSYSTEMD LIBXML2 M17N_FLT MODULES >> NATIVE_COMP NOTIFY INOTIFY PDUMPER PNG RSVG SECCOMP SOUND SQLITE3 >> THREADS TIFF TOOLKIT_SCROLL_BARS TREE_SITTER WEBP X11 XDBE XIM XINPUT2 >> XPM GTK3 ZLIB >> >> Important settings: >> value of $LANG: en_US.UTF-8 >> value of $XMODIFIERS: @im=ibus >> locale-coding-system: utf-8-unix >> >> Major mode: Lisp Interaction >> >> Minor modes in effect: >> global-git-commit-mode: t >> magit-auto-revert-mode: t >> shell-dirtrack-mode: t >> windmove-mode: t >> rcirc-track-minor-mode: t >> server-mode: t >> subword-mode: t >> bug-reference-prog-mode: t >> whitespace-mode: t >> yas-minor-mode: t >> xclip-mode: t >> global-treesit-auto-mode: t >> treemacs-project-follow-mode: t >> treemacs-follow-mode: t >> treemacs-git-mode: t >> treemacs-fringe-indicator-mode: t >> corfu-terminal-mode: t >> corfu-popupinfo-mode: t >> corfu-echo-mode: t >> global-corfu-mode: t >> corfu-mode: t >> activities-tabs-mode: t >> activities-mode: t >> fido-vertical-mode: t >> icomplete-vertical-mode: t >> icomplete-mode: t >> fido-mode: t >> override-global-mode: t >> global-display-line-numbers-mode: t >> display-line-numbers-mode: t >> global-auto-revert-mode: t >> tooltip-mode: t >> global-eldoc-mode: t >> eldoc-mode: t >> show-paren-mode: t >> electric-indent-mode: t >> mouse-wheel-mode: t >> tool-bar-mode: t >> tab-bar-mode: t >> file-name-shadow-mode: t >> global-font-lock-mode: t >> font-lock-mode: t >> blink-cursor-mode: t >> column-number-mode: t >> line-number-mode: t >> transient-mark-mode: t >> auto-composition-mode: t >> auto-encryption-mode: t >> auto-compression-mode: t >> >> Load-path shadows: >> /usr/share/emacs/site-lisp/elpa/debian-el-37.13/debian-autoloads hides /usr/share/emacs/site-lisp/elpa/gnuplot-0.8.1/debian-autoloads >> /usr/share/emacs/site-lisp/elpa/magit-3.3.0/magit-section hides /usr/share/emacs/site-lisp/elpa/magit-section-3.3.0/magit-section >> >> Features: >> (shadow emacsbug git-rebase tabify ert-x python etags fileloop generator >> java-ts-mode c-ts-common sh-script smie executable debian-copyright >> debian-changelog-mode noutline outline shortdoc completion >> debian-control-mode cl-print help-fns radix-tree tramp-cmds >> gitignore-mode conf-mode tramp-container tramp-sh tramp-cache time-stamp >> dockerfile-ts-mode yaml-ts-mode reporter debian-bts-control debian-bug >> reveal mailalias goto-addr vterm tramp tramp-loaddefs trampver >> tramp-integration files-x tramp-compat term ehelp vterm-module misearch >> multi-isearch shr-color flow-fill matlab matlab-scan matlab-syntax >> matlab-compat qp url-http url-gw url-auth url-queue url-cache mm-archive >> sort gnus-cite mail-extr textsec uni-scripts idna-mapping ucs-normalize >> uni-confusable textsec-check gnus-async gnus-bcklg gnus-ml magit-extras >> eglot external-completion array jsonrpc ert ewoc debug backtrace >> find-func xref pcase perl-mode face-remap magit-bookmark magit-submodule >> magit-obsolete magit-blame magit-stash magit-reflog magit-bisect >> magit-push magit-pull magit-fetch magit-clone magit-remote magit-commit >> magit-sequence magit-notes magit-worktree magit-tag magit-merge >> magit-branch magit-reset magit-files magit-refs magit-status magit >> magit-repos magit-apply magit-wip magit-log which-func imenu magit-diff >> smerge-mode diff git-commit log-edit add-log magit-core magit-autorevert >> magit-margin magit-transient magit-process with-editor shell pcomplete >> magit-mode transient format-spec magit-git magit-section magit-utils crm >> dired-aux mule-util jka-compr gnus-topic cursor-sensor utf-7 nnfolder >> gnus-demon nnml ezgnus gnus-delay gnus-draft gnus-agent gnus-srvr >> gnus-score score-mode nnvirtual nntp gnus-cache gnus-msg gnus-art mm-uu >> mml2015 mm-view mml-smime smime dig gnus-sum shr pixel-fill kinsoku >> url-file svg dom nndraft nnmh gnus-group gnus-undo smtpmail gnus-start >> gnus-dbus dbus xml gnus-cloud nnimap nnmail mail-source utf7 nnoo >> gnus-spec gnus-int gnus-range message sendmail yank-media rfc822 mml >> mml-sec mm-decode mm-bodies mm-encode mail-parse rfc2231 rfc2047 rfc2045 >> ietf-drums mailabbrev gmm-utils mailheader gnus-win gnus nnheader >> gnus-util mail-utils range mm-util mail-prsvr windmove flyspell ispell >> gnutls network-stream puny nsm epa-file epa derived epg rfc6068 >> epg-config rcirc parse-time iso8601 time-date term/xterm xterm comp >> comp-cstr server cap-words superword subword vc-hg vc-git diff-mode >> vc-bzr vc-src vc-sccs vc-svn vc-cvs vc-rcs log-view pcvs-util vc >> vc-dispatcher bug-reference disp-table whitespace yasnippet-snippets >> yasnippet cus-edit cus-start wid-edit init zenburn-theme xclip >> treesit-auto treesit treemacs-project-follow-mode treemacs-follow-mode >> treemacs-rendering treemacs-annotations treemacs-async treemacs-visuals >> treemacs-fringe-indicator pulse color treemacs-workspaces treemacs-dom >> treemacs-icons treemacs-themes treemacs-scope treemacs-core-utils >> treemacs-logging treemacs-customization pfuture inline ht s hl-line dash >> keychain-environment exec-path-from-shell corfu-terminal popon >> corfu-popupinfo corfu-echo corfu compat activities-tabs activities >> persist bookmark pp edmacro kmacro advice icomplete cus-load >> flymake-proc flymake project compile text-property-search comint >> ansi-osc ansi-color ring warnings icons thingatpt cl-extra help-mode >> use-package use-package-ensure use-package-delight use-package-diminish >> use-package-bind-key bind-key easy-mmode use-package-core >> display-line-numbers autorevert filenotify >> keychain-environment-autoloads treesit-auto-autoloads xclip-autoloads rx >> info debian-el dired dired-loaddefs finder-inf package browse-url url >> url-proxy url-privacy url-expand url-methods url-history url-cookie >> generate-lisp-file url-domsuf url-util mailcap url-handlers url-parse >> auth-source cl-seq eieio eieio-core cl-macs password-cache json subr-x >> map byte-opt gv bytecomp byte-compile url-vars cl-loaddefs cl-lib rmc >> iso-transl tooltip cconv eldoc paren electric uniquify ediff-hook >> vc-hooks lisp-float-type elisp-mode mwheel term/x-win x-win >> term/common-win x-dnd tool-bar dnd fontset image regexp-opt fringe >> tabulated-list replace newcomment text-mode lisp-mode prog-mode register >> page tab-bar menu-bar rfn-eshadow isearch easymenu timer select >> scroll-bar mouse jit-lock font-lock syntax font-core term/tty-colors >> frame minibuffer nadvice seq simple cl-generic indonesian philippine >> cham georgian utf-8-lang misc-lang vietnamese tibetan thai tai-viet lao >> korean japanese eucjp-ms cp51932 hebrew greek romanian slovak czech >> european ethiopic indian cyrillic chinese composite emoji-zwj charscript >> charprop case-table epa-hook jka-cmpr-hook help abbrev obarray oclosure >> cl-preloaded button loaddefs theme-loaddefs faces cus-face macroexp >> files window text-properties overlay sha1 md5 base64 format env >> code-pages mule custom widget keymap hashtable-print-readable backquote >> threads dbusbind inotify lcms2 dynamic-setting system-font-setting >> font-render-setting cairo move-toolbar gtk x-toolkit xinput2 x multi-tty >> make-network-process native-compile emacs) >> >> Memory information: >> ((conses 16 4151836 235820) >> (symbols 48 38894 35) >> (strings 32 186143 40188) >> (string-bytes 1 6165556) >> (vectors 16 121009) >> (vector-slots 8 3140568 287319) >> (floats 8 1184 5120) >> (intervals 56 274782 3076) >> (buffers 984 145)) > > Adding Philip who may have thoughts regarding ELPA structure. > > > > -- Philip Kaludercic on peregrine