bug#72461: [PATCH] js-ts-mode: Make jsdoc's "description" block a comment

bug#72461: [PATCH] js-ts-mode: Make jsdoc's "description" block a comment

[Damien Cassou]

[-- Attachment #1: Type: text/plain, Size: 405 bytes --]

Tags: patch

Hi,

the c-ts-common part of the patches in bug#71760 was merged into
emacs-30 but not the js one. As a result, filling documentation in
js-ts-mode still doesn't work. I attach the unmerged part again in the
hope it will be merged to both emacs-30 and master.

Best

-- 
Damien Cassou

"Success is the ability to go from one failure to another without
losing enthusiasm." --Winston Churchill

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0001-js-ts-mode-Make-jsdoc-s-description-block-a-comment.patch --]
[-- Type: text/patch, Size: 1067 bytes --]

From e444692026cae97dfaecebf5972507ae95f5e488 Mon Sep 17 00:00:00 2001
From: Damien Cassou <damien@cassou.me>
Date: Sun, 21 Jul 2024 21:32:34 +0200
Subject: [PATCH 1/2] js-ts-mode: Make jsdoc's "description" block a comment

* lisp/progmodes/js.el (js-ts-mode): Add "description" to
`c-ts-common--comment-regexp'.
---
 lisp/progmodes/js.el | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/lisp/progmodes/js.el b/lisp/progmodes/js.el
index f8140c14a49..75c8111035c 100644
--- a/lisp/progmodes/js.el
+++ b/lisp/progmodes/js.el
@@ -3946,7 +3946,9 @@ js-ts-mode
                    :embed 'jsdoc
                    :host 'javascript
                    :local t
-                   `(((comment) @capture (:match ,js--treesit-jsdoc-beginning-regexp @capture))))))
+                   `(((comment) @capture (:match ,js--treesit-jsdoc-beginning-regexp @capture)))))
+
+      (setq c-ts-common--comment-regexp (rx (or "comment" "line_comment" "block_comment" "description"))))
 
     ;; Imenu
     (setq-local treesit-simple-imenu-settings
-- 
2.45.2

bug#72461: [PATCH] js-ts-mode: Make jsdoc's "description" block a comment

[Yuan Fu]

> On Aug 4, 2024, at 6:04 AM, Damien Cassou <damien@cassou.me> wrote:
> 
> Tags: patch
> 
> Hi,
> 
> the c-ts-common part of the patches in bug#71760 was merged into
> emacs-30 but not the js one. As a result, filling documentation in
> js-ts-mode still doesn't work. I attach the unmerged part again in the
> hope it will be merged to both emacs-30 and master.
> 
> Best

Ah sorry, I thought this patch is already merged. I just applied and pushed to emacs-30. Thanks.

Yuan