From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Thuna Newsgroups: gmane.emacs.bugs Subject: bug#72456: [PATCH] rcirc: Fix startup channels triggering flood protection Date: Tue, 06 Aug 2024 20:23:49 +0200 Message-ID: <87wmkty0ga.fsf@gmail.com> References: <87y15dkvhw.fsf@gmail.com> <877ccwz69t.fsf@posteo.net> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="29251"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 72456@debbugs.gnu.org To: Philip Kaludercic Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue Aug 06 20:25:46 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1sbOsU-0007Rs-8C for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 06 Aug 2024 20:25:46 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sbOsP-0007Tw-Qo; Tue, 06 Aug 2024 14:25:41 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sbOsM-0007Ck-Ag for bug-gnu-emacs@gnu.org; Tue, 06 Aug 2024 14:25:38 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1sbOsL-0005v7-T4 for bug-gnu-emacs@gnu.org; Tue, 06 Aug 2024 14:25:38 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debbugs.gnu.org; s=debbugs-gnu-org; h=MIME-Version:Date:References:In-Reply-To:From:To:Subject; bh=4hiYbv8rDttAnipS68mKAJYk/VP4mYeifpiwuCissHc=; b=lHlFXUyuHYbnp7z7BOGJydA7Ln0QYqJrGvg2TU4YDnCe+f2KPintNy0ftQs/8eCtwsAe2gr3pv37JDV2DyG5x64KjVG655MAWRM5kdSLT3gJ1J5IVoYP2x6VvLhHeR0BSu18xXbW5CoiBGLWGF5dXkPv0OAJ2+7fQz+QxG/p2yZd7ozi0TEvllWbja0Qne7HCe3T3hM7zDNkaIa0y2LKHsrgC8A+y6cQgekwN5V4aXiQWSHwR2wsfYoEz+VfwS4PwmyhxcJ6iY28Pj8tUOmSB5EJlP3VhXqsOOkrQlSbf9JFEf7yp9f2R2d1sJAVojgFon38qA7J8UTFQ+d1TN4Rvw==; Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1sbOsj-0005zb-UM for bug-gnu-emacs@gnu.org; Tue, 06 Aug 2024 14:26:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Thuna Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 06 Aug 2024 18:26:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 72456 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 72456-submit@debbugs.gnu.org id=B72456.172296872522989 (code B ref 72456); Tue, 06 Aug 2024 18:26:01 +0000 Original-Received: (at 72456) by debbugs.gnu.org; 6 Aug 2024 18:25:25 +0000 Original-Received: from localhost ([127.0.0.1]:33039 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sbOs8-0005yi-KP for submit@debbugs.gnu.org; Tue, 06 Aug 2024 14:25:24 -0400 Original-Received: from mail-wm1-f43.google.com ([209.85.128.43]:54654) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sbOs6-0005yS-BX for 72456@debbugs.gnu.org; Tue, 06 Aug 2024 14:25:22 -0400 Original-Received: by mail-wm1-f43.google.com with SMTP id 5b1f17b1804b1-42819654737so6840185e9.1 for <72456@debbugs.gnu.org>; Tue, 06 Aug 2024 11:24:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1722968632; x=1723573432; darn=debbugs.gnu.org; h=mime-version:message-id:date:references:in-reply-to:subject:cc:to :from:from:to:cc:subject:date:message-id:reply-to; bh=4hiYbv8rDttAnipS68mKAJYk/VP4mYeifpiwuCissHc=; b=VpE7qaxCqwgjXPT2WtShjVs8vvTVfmcH9C9kAdm4KYSPOvbhESJDo+AY744qD6hGEe joVa+NbdIoOVi24ePMQppCyxsyXSF8kSwU8KMQFXEx/jfW/m41xE4qtI9JysJ3X2QW5h N8SQ7h+X6tIjCGWygmnozGKfA+6gK/vqTVOw7oYnE/mFm+5qolW5RGJmqmS6peNr+1Vw 6PSCTCzmLEfbJ/5rQc3d7AQefK2Z0p49nUSdXS2FrsmTT3xHj5g8Uv5Spm7PjW4gzfOw 0lCyYm+/9NiTamrJDTI8f3PzuRTMAhGgmvJRjswb+DMD9I86VYEcKRrzwLCm2P9E/POy 03MQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1722968632; x=1723573432; h=mime-version:message-id:date:references:in-reply-to:subject:cc:to :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=4hiYbv8rDttAnipS68mKAJYk/VP4mYeifpiwuCissHc=; b=gyBaLuzC0RNPFvCL72CK/hTIn2M3ZP6TW/Hk1smBFaSWysPoFxT/pz3uzOhCfxlM+E qmGdrJPOpcfIhy9S5EwHcNx6t1M6nc4oif3WaiCbmOKWegBxHGwVpU84BoGaNuvqoDWu OVpSIauXC3cTv4NtDlgmAH30vd/fMwRRp/su+6vHFgjvvFapnNeW5EbEefBFgg/EbTa1 FlNli3ZIwzspDnz37NC8LjSL1Dgc/3UTDxOjp8H0evlRUBBTiAmgp0h814qHxNqdQJfd CxMmrzAbIa8x/retoZcnfiGzn6gOsaktPpIsvMYBXAP0hEhjXu+xHhZt90d7nKO+Crb/ oqQw== X-Gm-Message-State: AOJu0YyVcSVEsvznXTfYs6jyZRNfQIxKnn62YyGdT0pNZsQ0ldYTl9YC cDIxap8ddbrs9NRCnJL++BUrdHIrmyPW8WOSlbBSFye31r+5RbxR2RFSZUx7nn0= X-Google-Smtp-Source: AGHT+IEL/UEnjEx74bskC+WaymVn5dSuc37fdVVYAozE7tCqRLunNGxzBweGizrZnpFWVQwUxk6fPQ== X-Received: by 2002:a05:600c:470d:b0:428:10ec:e5ca with SMTP id 5b1f17b1804b1-428e6b0870emr99224715e9.14.1722968631640; Tue, 06 Aug 2024 11:23:51 -0700 (PDT) Original-Received: from thuna-lis3 ([85.106.105.81]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4282bb64952sm254527695e9.37.2024.08.06.11.23.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 06 Aug 2024 11:23:51 -0700 (PDT) In-Reply-To: <877ccwz69t.fsf@posteo.net> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:289853 Archived-At: >> This has a flaw, which is mentioned in the patch in a FIXME, in that if >> the total length of the channels exceeds the maximum length of a message >> then the message will likely split and break. While checking for it >> while joining the channel names is a possibility, it's probably better >> if we split command messages more elegantly in the first place. > > I think we should fix that before applying the change, as I cannot > imagine that the error message in that case will be in any way helpful. Actually, oddly enough, no matter how long I made my JOIN message I was able to send it and have it actually work. I did a hundred channels on tilde.chat which all joined with: (cl-loop initially (insert "/join ") for i from 0 to 100 do (insert "#" (apply #'string (mapcar (lambda (c) (+ c (- ?a ?0))) (append (format "%04d" i) nil))) ",") finally (delete-char -1)) and I did a /join #aaaaaaaaaa,#aaaaaaaaaa,... in libera.chat with the full message more than 3400 characters long. They both seemed to work as you would hope. It would be nice if you could verify that this is the case and furthermore that this is the case in other servers as well. If this is something that can be relied on then we might not need to be concerned with the total message length after all.